Firelight

Actually, just to share from my side, here’s the code.

The challenge I’m having is that this code is simple, correct, and does not have a syntax error. Line 748 is the last line, and the closing parenthesis is required as the closing parenthesis for the wp_enqueue_script() call.

wp_enqueue_script(
  'firelight-block-js',
  $block_js,
  array( 'wp-blocks', 'wp-i18n', 'wp-element', 'wp-components', 'wp-editor', 'wp-hooks' ),
  $version,
  array( 'in_footer' => true ),
);  // <- This is line 748. I cannot remove this closing paranthesis. 

Hmm. Well, that’s concerning.

I did just push a release that imposes full PHP coding standards on that file. Notably, the coding standards did not flag or force any changes to the line above. In any case, feel free to update and confirm the issue is still fixed.

I’m particularly concerned that using the updater may have generated an issue/message that’s not (a) consistent and (b) actually there in the code as far as I can see.

In any case, hopefully this update also resolves things for people.

Please definitely let me know if you continue to see any issues, and I’ll be available to troubleshoot immediately.

Hi! Thanks for the report. This one is puzzling.

Normally, if that error existed, it should be there for everyone (the PHP version should not affect it). I just had a look at line 693 in that file, and there is not an extra parenthesis there (there is a closing parenthesis, but it is needed). I tried it against PHP 7 too, just to be sure.

Can I ask how you uploaded – did you click update from your WP dashboard or download a zip and upload manually?

I had prepped a change to apply PHP coding standards to this file. I was going to put that in the next release, but just as a safety measure, I will prepare a release with that shortly and deploy. In that file, both myself and PHP coding standards agree there are no issues.

Hopefully that will resolve things for you. If not, I may ask if there any chance you can copy the lines of code around that line in your version of the plugin so I can see them. But we can hold on that until after this release..

That release should go out in the next hour.

Wanted to follow up and confirm that we just released the fix for this as part of 2.2.0. Please feel free to check and confirm it is resolved.

I’m going to mark this issue as resolved now, but please feel free to let us know if you have other questions.

Thanks!

Hi Thomas,

Wanted to follow up on this and let you know we’ve just released an option that allows you enable/disable the core lightbox. It is still disabled by default. But you can enable it by going to Lightbox > Miscellaneous > Disable Core Lightbox, and unchecking that box.

Between this new setting and the one above for to apply the lightbox only to images with links, you should be able to return fully to the prior behavior.

I’m going to mark this issue resolved, but definitely let us know if you have other questions.

Thanks!

Great! I am going to mark this resolved. But please feel free to let us know if you have other questions.

We’d love to do this and have looked at it. It is surprisingly more complicated than you might think, mostly because Woo has a lot of it’s own JS / behavior tied to images on product pages and elsewhere.

So for now, that’s not available. We hope it will be in the future, but have no time frame on that.