Firelight
Forum Replies Created
-
Forum: Plugins
In reply to: [Firelight Lightbox] Filename showing instead of title/captionHi @hgsouth! So what happens is that (a) if there’s no title on the image and (b) the ‘Show Title’ option is turned on, Firelight Pro uses the image file name as the title. If you’re seeing that it likely means it is not detecting the title.
Right now, to detect the title, it specifically looking at the title attribute in the image markup. If you were using core image blocks, the only way to add that is via the title attribute field in the block editor settings. I don’t know how Elementor + premium masonry grid adds the title attribute?
In theory, the core image block should offer an option to pull the title from the media library and use that as the title attribute. I don’t think it does.
Since it doesn’t, Firelight Pro should be doing that – it’s on my dev agenda. I’ve already updated the lightbox caption with an option to pull from media library description or caption, EXIF or IPTC, fig caption, or image alt text.
Can you describe what ‘title’ you are expecting to display? Like where does the title live – is it some meta data, or something you are adding in Elementor, etc?
Forum: Plugins
In reply to: [Firelight Lightbox] Request to update DOMPurify to version 3.2.5@lescus – Thanks for raising this! And, yes, I’d be happy to update this. I’ll need to test it, of course, to confirm no issues or conflicts. But assuming not, I’ll include this in the next release. I’ll follow up once I’ve pushed the update to the plugin and I’m sure it’ll be in.
Forum: Plugins
In reply to: [Firelight Lightbox] is firelight working?@vkarta – I see this is marked resolved. Did you figure this out?
Forum: Plugins
In reply to: [Firelight Lightbox] Iframe galleryGreat! Thanks for following up and letting us know!
Forum: Plugins
In reply to: [Firelight Lightbox] -tmp prevents loadingHi @ballzerker! I just tried recreating this set up, and I can see the same thing as you. I’ve never tried this before and I don’t know an immediate fix off the top. The behavior comes from the underlying fancybox lightbox script. Even if I correct the id of the first modal, I find the second link also doesn’t work.
So I’d need some time to troubleshoot the issue. I may not get to it this week.
As a side note, I also tried using the Pro Lightbox in this situation (it is based on Fancybox V5, which is much newer), and it does not have this problem. The first lightbox opens, then the second lightbox opens. When you close the second lightbox, the first lightbox is still there/open and needs to be closed separately. I assume the reason it works is that any logic that fancybox runs during close is being properly executed (vs the free version of the lightbox in your original example, where you never actually close the first lightbox). In any case, if the pro sequence above works for you, that’s also a solution.
Update: Here is a quick demo of how it works with the Pro Lightbox: https://firelightwp.com/modal-within-modal/- This reply was modified 1 year, 1 month ago by Firelight.
Forum: Plugins
In reply to: [Firelight Lightbox] Iframe galleryHi @jonkastonka! In short, yes, it should be possible to open iframes with gallery navigation in the lightbox. I just did a quick test. If I add the following html to a page, the lightbox opens the pages in an iframe with gallery navigation. I just use this as an example of the simplest markup that should work.
As an experiment, can you see if it this works as expected for you on a test page? If so, then we have a starting point and we can see if there’s something else that needs to be adapted to your case.
<p><a href="https://en.wikipedia.org/wiki/France" class="fancybox-iframe" rel="iframegallery">Open France wikipedia page</a></p>
<p><a href="https://en.wikipedia.org/wiki/England" class="fancybox-iframe" rel="iframegallery">Open England wikipedia page</a></p>Note I tested this with Classic Reloaded lightbox. I didn’t double check to confirm the other lightboxes yet. And if you are using pro lightbox, you might need slightly different markup.
Forum: Plugins
In reply to: [Firelight Lightbox] Youtube lightbox – disable next/previousGreat and you’re very welcome!
Forum: Plugins
In reply to: [Firelight Lightbox] Jetpack Galleries@le-tom – I just tested this against Jetpack tiled galleries. I think that’s what you are using. It is working fine for me in both free and pro versions. Images open in the lightbox. A few caveats and notes:
- For it to work, you need to be sure that in the Jetpack gallery settings, you set the image to link to the media file. That may be what @ljosh was referring to above.
- By default, once you do the above, each image will open in the lightbox when clicked, but you won’t be able to navigate between images in the lightbox. That’s because the way our plugin detects images, it doesn’s ‘see’ the images as a group like it does for, say, images inside a ‘wp-gallery-block’ container. There are two solutions to this:
- In the lightbox settings, under the Images section, you can set the lightbox to group all images together. When you do this, it’ll treat all the images on a page as a single gallery, and so you’ll be able to navigate.
- In the Pro version, you can specify custom grouping selectors. So you can tell it to treat all images within a .wp-block-jetpack-tiled-gallery container, for example, as a distinct gallery, and it will just group those together and allow you to navigate between them.
In any case, if you still have a page where you you’ve set the Jetpack gallery to link to media files, and it’s not opening those images in a lightbox individually at least, let me know and we can further troubleshoot what may be going on (it’s likely site specific in this case).
Forum: Plugins
In reply to: [Firelight Lightbox] Jetpack GalleriesHi! Just wanted to acknowledge I’ve seen this. I need to re-check what we may be doing (or not) to handle Jetpack galleries. I’m fairly sure this was working without special integration in the past. If it’s not working now, I’ll definitely want to fix it. We want to be compatible with Jetpack galleries.
Forum: Plugins
In reply to: [Firelight Lightbox] Youtube lightbox – disable next/previousYou can try something like this. You might want to play with this a bit to get it to your liking.
.fancybox-nav {
width: 20% !important; // reduces with of clickable nav areas
height: 40% !important; // reduces height, important to get it off video controls
top: 30%; // since height is different, we need to reposition it
}
.fancybox-next {
right: -50px; // Not needed, but moves nav arrow off the video
}
.fancybox-prev {
left: -50px; // Not needed, but moves nav arrow off the video
}Forum: Plugins
In reply to: [Firelight Lightbox] Youtube lightbox – disable next/previousHmm. I see the issue on your site.
The reason you are seeing it with the Spectra button and not the WordPress button is actually not because of the button type. It’s just you have it set up so the Spectra videos are linked together as one ‘gallery’ and you can navigate between them within the lightbox.
For the WP buttons, each button opens its own video, and you cannot navigate between them in the lightbox. Since there are no nav arrows, you don’t see the issue.
We can probably do a quick fix with CSS. But this is an issue I’ll need to fix with the lightbox. I don’t see too many people set it up so you can navigate videos in the lightbox, so I haven’t noticed this before.
I’ll play with some CSS and follow up shortly.Forum: Plugins
In reply to: [Firelight Lightbox] Lightbox doesn’t open on iPad, iPhone, or Google Pixel@clokendagger – It’s not uncommon for caching plugins to break JavaScript implementations. Most caching plugins will concatenate and minify JS files. This can break JS directly, or more likely in this case, it’s blocking the loading of the JavaScript because of dependencies. Our lightbox scripts depends on a few other JavaScript files or libraries to be present. We specify those in standard wp_enqueue_script calls. If Siteground changes the order of those or fancybox can’t detect them, then our JS won’t load.
The usual way to fix this is to exclude specific JS files from optimization. You can see details on how to do that here:Forum: Plugins
In reply to: [Firelight Lightbox] Lightbox doesn’t open on iPad, iPhone, or Google Pixel@clokendagger – I just checked your link on my laptop (thanks for that, by the way). I’m not able to open images there either at the moment. While there are issues with the lightbox and PDFs on mobile, if we’re just talking about images, the lightbox should work just fine on mobile.
And you appear to be using core gallery blocks, so that rules out a conflict with a third party gallery plugin.
On your page, I actually don’t see fancybox scripts enqueued, and I also don’t see any fancybox classes or attributes applied to the images. Have you disable the plugin? Otherwise, something is preventing the JS from loading at the moment, and that would seem to be the issue.
I see you’re using a caching pluging, and that’s a very possible culprit. I might try without that, or try excluding fancybox scripts.
You can disable the lightbox on mobile using the ‘Minimum viewport width” setting under Lightbox Settings > Miscellaneous. If you had that set large, it would prevent opening on mobile. But I’d be surprised if that’s the issue here given it’s not working on an iPad.
Can you confirm if the plugin is still there and active, and if so, try adjusting caching settings?
Forum: Plugins
In reply to: [Firelight Lightbox] PDF viewer no longer works@troglo88 – Given what you’re saying about a mix of theme and plugin updates, it sounds like we might have a plugin / theme conflict of some kind. The PDF viewer still works as usual for our dev and production sites, and for customer sites I’ve seen recently. Any chance you could provide a link so I can see the behavior? If you’d prefer to keep it private, you can reach out at firelightwp.com/contact.
Forum: Plugins
In reply to: [Firelight Lightbox] Change fancybox size@danstramer – Glad to fine at least a short term solution.
“I would like the fancybox window to resize itself based on the videos proportions” -> I’ll add this to the list of feature requests. I agree this would be ideal, and the lightbox will do that already for images. I just need to explore what’s involved with videos which are obviously a more complex content type.
Since we have a short term fix, and we’re now moving into feature requests, I’m going to mark this resolved for now. But definitely feel free to continue to ask questions or send other good feedback!