Firelight
Forum Replies Created
-
Forum: Plugins
In reply to: [Firelight Lightbox] Native WordPress Lightbox not workingHi @webzunft – Yes, we did recently introduce a change to disable the default lightbox when Easy Fancybox is active. I think our assumption was that if you’re using a lightbox plugin, you don’t want to use the default lightbox.
We can look at introducing an option for this.
To help us think through it, can I ask why you’re using the default lightbox and the plugin at the same time? Do you prefer the style of the core lightbox for single images? Are you using the core for images vs plugin for something else (ie, inline content or modal popup or video)?
Forum: Plugins
In reply to: [Firelight Lightbox] Close button not working on mobile devicesHi! Can I please confirm if you are using Fancybox V2 (vs Legacy or Classic Reloaded)? We can duplicate right now for V2, but not the others. We’d like to be sure we’re solving the same issue you’re seeing. Thanks!
Hi! Just wanted to confirm we’ve prepped a fix for this and it will be in the next release.
It was happening because we tried to consolidate some JS, but as a result we were running some JS for our options page on the main dashboard screen where it is not needed/applicable.
Thanks very much for the report!
Forum: Plugins
In reply to: [Firelight Lightbox] All images that are opened in Easy Fancy BoxHi! Yes we did update this recently.
If you want the plugin to behave as it did before, and detect only images explicitly set to open media files, then go to Lightbox > Images, and look for the “Apply to” settings, and change it from “All Images” to “All Image Links”.
It looks like this: https://d.pr/i/v7iwIWForum: Plugins
In reply to: [Firelight Lightbox] Lightbox image too small@acekin – I just pushed a fix/setting for this (assuming your issue is the same I’m diagnosing now).
Fancybox2, unlike the other lightboxes, will take account of the pixel ratio for retina displays. That means image will display smaller on retina. I added an options for Fancybox 2 > Window > Adjust images for retina. When OFF, fancybox 2 will not take account of retina pixel ratios, and will appear the same large size you’d see with others. With it ON, fancybox 2 will take account of pixel ratios, and images may appear smaller.
Can you give that a try and confirm if it resolves the original issue you reported?
If it doesn’t work initially, please try toggling the setting on, save, then off again, and save. That should not be needed but it was oddly for a site of for me just now when I tested post release.
Thanks!
Forum: Plugins
In reply to: [Firelight Lightbox] Inline content not working with custom blocksHi! Thanks for the report.
Just looked at you demo. Thanks for providing that – it greatly helps troubleshooting.
I think the issue may just be which element you are applying the ‘fancybox-inline’ class to. If you look at screenshot below, you’ll see that in the working examples, the ‘fancybox-inline’ element is the direct parent of the the link. In the non-working example, the ‘fancybox-inline’ element is several levels up from the link.
The fancybox code as currently written expects the ‘fancybox-inline’ tag to be applied to the direct element that contains the link.
I haven’t used Spectra. But with that infobox it’s using, are you able to apply the ‘fancybox-inline’ class to the p tag that contains the link rather than the infobox container div? That will depend on whether that info box contains child blocks that generate markup OR just generates all the interior markup itself.
The solution in code is for us to look for any “.fancybox-inline a” tag rather than “fancybox-inline > a” tag which is what we’re looking for now. That is not a complicated change to make, but I would need to think about and double check that the change wouldn’t create unexpected behaviors for other users given how long it’s worked the way it does.
Forum: Plugins
In reply to: [Firelight Lightbox] Lightbox image too smallHi @acekin – I took an initial look at this and tested locally myself.
Normally the setting to adjust for this is Window > Width. And that setting works fine in classic and legacy.
But I can duplicate something similar to what you are seeing with FB2. The margin setting applies, but Fancybox 2 is effectively limiting width to 960px, no matter the margin. This does not happen with Classic or Reloaded.
Initially I assumed this may be related to some of the options changes we this year. But I just tested with the last 1.9.x version (before we made any recent major changes), and I see the exact same behavior there: FB2 images cannot expand past a certain display width regardless of image size or margin setting.
I don’t know where that limit in FB2 is coming from. It’s not anything we apply in the code, and it’s not some kind of default number in the FB2 script itself. My best guess now is that the FB2 script is doing some calculations somewhere based on window + ratios and calculating a max width.
After an hour or two of looking, I was not able to figure out where the limit is coming from.
We will resolve this as it is not what should be happening. We’ll keep digging this week. And I’ll keep you posted when we figure it out and prep a fix.Thanks for the report.
Forum: Plugins
In reply to: [Firelight Lightbox] doubled video play when using lightboxI can confirm I see the issue with the double playing.
Logically, what’s happening (I think):
1. The Lazy Load plugin provides the thumbnail.
2. The Lazy Load plugin has some JavaScript such that when you click a thumbnail, the video plays embedded on the page.
3. Our plugin has some JavaScript such that when you lick a thumbnail, the video opens in a thumbnail and then plays.You can see the conflict between #2 and #3 above. The only way to prevent this is to stop #2 from happening.
Do you know if that is new behavior on the part of the Lazy Load plugin? Based on what you’re saying, I have to assume that before you had this issue, #3 was happening above, but #2 was not. #2 above is entirely the doing of the Lazy Load plugin. That’s not something our plugin is doing.
A related question: do you know if the Lazy Load plugin has (or has recently added) any settings to dictate what happens when you click a thumbnail? Ideally, you want it to NOT play the thumbnail on click. For example, instead of playing the thumbnail, if it just links to the youtube page, that would fix this issue I thinnk. The video wouldn’t play, but Easy Fancybox would ‘intercept’ the link and open the video in the lightbox.
If there is no setting for what to do when clicking a thumbnail, another way to stop #2 is to dequeue/remove/stop the Lazy Load JS that plays the file. I don’t know how they load their JS. If it’s a separate file that is enqueue, this could be done with a couple simple lines of PHP. It could also likely be done by writing some custom JS/PHP code. Digging into this kind of third party customization is unfortunately well beyond what we can do for plugin support on our side.
If you do reach out to the Lazy Load plugin team, what you want to ask them is: “Is there a way to stop the videos from playing when clicked? Either a setting, or a simple way via code?”
–
The only other question I can raise on our side is whether Easy Fancybox was doing something before to block the default behavior of the Lazy Load plugin. I don’t think that’s the case, and I’m not sure how we would have been doing that, and I don’t think we’ve changed anything recently that would affect something like that.
- This reply was modified 1 year, 12 months ago by Firelight.
Forum: Plugins
In reply to: [Firelight Lightbox] doubled video play when using lightboxHi!
Thanks for your note.
If the video is playing on the page and in the lightbox, presumably that means the full video is embedded on the page? If so, I’d normally expect it to play on the page rather than open in a lightbox. Given that I’m curious how you have it set up.
Can you link to the page with the issue? It might be useful to re-enable the lightbox on that page so I can see the issue. Soon as I do, I’ll post here and you can turn it off again.
One other thing that would be helpful to check: can you duplicate this issue using our plugin alone? Or does it only happen in combination with the Lazy Load plugin? That will help us know if the issue is specifically our plugin, or if it is a plugin conflict (which seems more likely given the description).
Thanks.
We just pushed an immediate fix for this. Thank you very much for the quick report.
Yes. We’ll push an update for this in the next 10 minutes. Rather than update min version, we’ll just confirm the function exists or check WP version before running this.
Forum: Plugins
In reply to: [Firelight Lightbox] Fancybox iframe for productsOh, I’m also going to go ahead and resolve this issue for now since we’ve responded and answered the question (even if it’s not the answer we would both like). You are obviously very welcome to ask any other follow up questions you may have.
Forum: Plugins
In reply to: [Firelight Lightbox] Fancybox iframe for productsHi! We took some time to look at this today. There’s actually a fair amount complexity around this, in part because woocommerce builds in and expects a range of functionality around woocommerce product images in various situations.
It’s still something we’d love to add. But it’s not something we can do quickly. For now, I don’t think what you want to do is effectively possible using our plugin with Woo, at least not in any way that will work nicely.
Sorry about that. If we do work on this any time in the near future, I’ll circle around to this post and share an update. Otherwise, for now, I wish you the best of luck finding a good solution!
Forum: Plugins
In reply to: [Firelight Lightbox] Fancybox iframe for productsHi! Sorry for the delayed response!
I think there may be a way to do this with the plugin as is. Let us play with it a bit, and we’ll follow up shortly.
Apart from that, we’d actually love to do a stronger integration with woocommerce for exactly this kind of use case. We may look at adding a an option to ‘auto-detect’ woocommerce product images. We’ll need to investigate a bit. If we do add this, it will probably be in the pro plugin.
One other note is that your example opens an image but also some extra content on the sidebar beside the image. This is a quite a bit tougher to do than just opening an image (still possible but a lot more work). Are you looking to just open the image, or something more slide-like as an in the examples above?
Forum: Plugins
In reply to: [Firelight Lightbox] Auto-link images possible?Hi! Updates:
First, we am actually going to update the free plugin / free lightboxes to open images in image blocks even if they are not linked. So you’ll also be able to uses the free plugin for this. Should be pushing this release soon.Second, yes, we’re offering to send you a copy of the Pro plugin with a free license for one year. After that you’d need to pay. Price will likely be around $69. I see you’ve reached out via email, so we’ll continue the convo about the pro plugin there.
Thanks!