Firelight
Forum Replies Created
-
Forum: Plugins
In reply to: [Firelight Lightbox] Saving settings don’t work@newsarena – If you are open to it, can you send a note via at firelightwp.com/contact? If you do, reference this thread. We can work through other troubleshooting. I’d like resolve this so you can update, and also make sure it’s not a broader issue that will affect a wider group of users.
Forum: Plugins
In reply to: [Firelight Lightbox] Saving settings don’t workHi @newsarena – I just retested on a few sites to be sure and saving works fine on my sites. So I don’t think it is a general/universal issue.
To confirm: you’re unable to save any options?
Do you know how to check the console in your browser for errors? If you are in Chrome, right click anywhere on the screen. That will bring up a menu. Click “Inspect.” That will bring up Chrome dev tools. Across the top, you’ll see a small menu – click ‘Console’. If there are JavaScript errors, they will show up there in red.
There is a bit of JS on that screen that helps with saving options. If there are console errors (ours or someone else’s), that could interfere with saving.
Forum: Plugins
In reply to: [Firelight Lightbox] ajax no working nextgen galleryThanks for the additional details. I wanted to confirm I can duplicate this issue. I’ll look more in the next 1-2 days to see if I can find a solution.
Forum: Plugins
In reply to: [Firelight Lightbox] ajax no working nextgen galleryHi @sonicgyn – To confirm your question/issue…. The fancybox lightbox is working fine for you, and fine for NextGEN Galleries EXCEPT when using NextGEN Gallery alongside ajax? Is that right?
If so, I’ll play around with that in the next day or two and see what I can figure out. I suspect what may be happening is that Easy Fancybox adjusts the markup using JavaScript to make the lightbox work. That happens once when the page loads. But then NextGEN loads additional images via ajax which do not have the Fancybox markup.
I think we’d need to find a way to re-fire some of our own JavaScript each time NGG adds a new batch of images like that. I just need to explore if that’s possible and how.
Forum: Plugins
In reply to: [Firelight Lightbox] No next and back arrows in galleriesDecided to push this release this evening. So feel free to update and test anytime.
Forum: Plugins
In reply to: [Firelight Lightbox] No next and back arrows in galleriesHi – Just wanted to follow up. I figured this out and prepped a fix. I’m planning to release version 2.2.6 tomorrow which will include the fix. Once you update, feel free to confirm the issues you are both having are fully resolved.
If you are using Pro, I prepped an associated fix and will also release tomorrow, so plan to update both free and pro. (There won’t be any serious issues if you don’t also update Pro, but it’ll work more seamlessly if both are updated).Thanks.
Forum: Plugins
In reply to: [Firelight Lightbox] No next and back arrows in galleriesHi @ukandrzej – Oh sorry! I actually saw just the first part your message above and thought you’d gotten this working. I need to read more thoroughly.
Thanks for the more detailed review above. Given your report and the second report from @7ulien, I will make time today to look at this today.
I will post here when I have an update, and will plan to release a fix this week.
Forum: Plugins
In reply to: [Firelight Lightbox] No next and back arrows in galleriesHi @ukandrzej –
I can see the issue on your site with no nav arrows.The setting for “All Images” to “All Image Links” would not nav arrows. That only determines which images open in the lightbox. As is, all your images are opening in the lightbox, so that setting is non relevant.
What’s happening is that it is not associated the images as being together as a gallery. It’s seeing each image as a lone image.
Can I ask how the gallery is added to the page? Is it via the block editor with a gallery block? Or is it via shortcode?
If shortcode, can you copy the code here?
Forum: Plugins
In reply to: [Firelight Lightbox] Remove Lightbox options from the WordPress editorI just pushed a small release that adds two options: one to hide the lightbox panel entirely, and one to set it so the panel is closed by default and thus less intrusive.
You can find both by going to Lightbox > Miscellaneous (assuming you are using Classic, V2, or Legacy lightboxes). At the bottom of that section, you’ll find two new checkboxes.
In a later release, I will make it so both of those options can be updated directly from the lightbox panel while editing a page or post as well (ie, you’ll see links to ‘close this panel’ or ‘hide this panel’ within the panel.
For now, I did leave the orange accent on the top of the Lightbox panel. I may leave it there for a month or so to ensure people realize the new panel exists, and then remove the extra highlighting.
Thanks for taking time to offer your feedback.
Forum: Plugins
In reply to: [Firelight Lightbox] Remove Lightbox options from the WordPress editor@rfischmann – Following up. I think for now, I’ll look at introducing two changes:
First, I’ll add an option to the plugin settings to disable the panel entirely. So for people who truly do not want to see any lightbox info or settings in the editor, they have that option.
Second, I may try to make it so that (a) the panel is always closed by default or (b) we ‘store’ the open/close status (so if you close it, then the new default will be closed; if you open it, the new default will be open).
The first change is relatively simple, and I’ll try to get it a release in the next week or so.
Forum: Plugins
In reply to: [Firelight Lightbox] Remove Lightbox options from the WordPress editorHi @rfischmann,
Thanks for your note.
The Lightbox Controls panel was recently added to Image and Gallery blocks. Those blocks will both open in the lightbox by default.
This is the first cut for that panel, but we’re intending to add options to enable/disable the lightbox (vs adding custom css classes via the Advanced tab). We are also considering allowing users to customize the lightbox (which one and/or lightbox options) on a per-image or per-gallery basis.
The broader goal is to bring the plugin into the modern block era.
Sounds like you’re not a fan. Would it be sufficient to have that panel be closed by default? Otherwise I suppose we could add an option to “Disable lightbox block editor controls”.Thanks.
Great! Glad it’s resolved.
Forum: Plugins
In reply to: [Firelight Lightbox] Vimeo Autodetect Broken with FancyBox V2Hi @shaunbowen,
I just tested this, and far as we can tell, this is working fine for us.
Questions:
- Can you tell me how you are adding the vimeo link?
- When you say “video just opens with a message saying “sorry we’re having a little trouble” do you mean the lightbox opens and that message shows in the lightbox. Or does the link not open the lightbox (ie, maybe redirects you to vimeo).
- Any chance you can share a link to the page with the issue?
Thanks.
Hi again,
So I understand why you’re getting this message, but I don’t understand how your site got in a state to product it. I want to review in case you might know how you produced it.
Here’s the context:
For each content type (image, pdf, video, etc), you can enable or disable autodetection. For everything but images, the only way to set this is via check box. So by default, it is either true or false (or more accurately 1 or 0).
For images, you can actually set an array of extensions like ‘.jpg,.png’.
In the code, we treat these situations differently. We check if the value of this setting is numeric (1 or 0). If so we know we’re dealing with non-images and proceed. Otherwise, if the value is a string value that is not numeric (ie, a list of file extensions), we know we’re dealing with images, and we proceed based on that.
Somehow your site is in a situation where, for non-images, you have something other than 1 or 0. Again, those values should always be 1 of 0 because they’re based on check boxes. We don’t present any settings or interface that would allow it to be set otherwise.
The question
Given all that, do you have any idea how you might have ended up in that situation? I’m not sure if you’ve tried to customize the plugin by setting custom file extensions for detecting videos or pdfs or other non-image content?
Quick possible fix effort
One way we might be able to fix this is to have you do the following:
- Go to lightbox settings
- One that page, in the top section for Enable, uncheck all the boxes. In effect you are disabling autodetection for all content types. Then save.
- Then you can immediately re-check any boxes you want, and save again. Theoretically, when you update those checkboxes and save, the values in the database should get updated to the right values.
Could you try that and let me know if it works?
Alternative fix with concerns
I mentioned in my first response I can add a check to ensure that if the values aren’t expected, we don’t run the corresponding code. In your case, this would remove the warnings. BUT… because you have an unexpected value stored for a checkbox, the plugin may still not behave quite right for you.
Thanks.
@oldrup – Hi and thanks for the report.
I’m not able duplicate your issue out of the box. And the code in question hasn’t changed in a long time. But all those warnings are inside one conditional block of code. It seems based on your settings you’ve found a way to trigger that block of code in a situation where some of the supporting options aren’t there.
I will play with this today to see if I can duplicate. If so, I’ll prep a fix. If not, at the very least, I can put some extra precautionary checks to confirm the relevant array keys in those warnings are set before using them.
I’ll follow up once I know more.