Firelight

Hi, I just wanted to follow and let you know I pushed a fix for Fancybox2 + Vimeo player links in version 2.2.8. On the assumption the issue is resolved, I’m going to mark this thread resolved. But please feel free to update and let me know if you are still having issues.

@newsarena – I just pushed a release (2.2.8) that fixes some known issues with a few settings not saving. It also ensure a success message shows when settings are saved so you can tell action was taken. If you are up for it, please feel free to try updating and let me know if you’re still having issues. Thanks.

Hi, so I think I understand what is happening. It is an issue with the core Fancybox 2 code. Fancybox2 comes with some media helpers that help with certain media types, especially videos. Those helpers actually adjust/change the vimeo url. The changes they make are fine for the vanilla vimeo links (vimeo.com/123456), but they break player links (player.vimeo.com/123456).

I will include this in the next release, but if you would like to try the fix on your site in the meantime: access your website via FTP, go to wp-content/plugins/easy-fancybox/fancybox/2.2.0/helpers/jquery.fancybox-media.js, and change line 96 as below.

Change it from this:

matcher : /(?:vimeo(?:pro)?.com)\/(?:[^\d]+)?(\d+)(?:.*)/,

to this:

matcher : /(?<!\.)(?:vimeo(?:pro)?.com)\/(?:[^\d]+)?(\d+)(?:.*)/,

You are adding an extra (?<!\.) right after the first /.

If you get a chance to test it before release, please let me know if it works. Otherwise just let me know after the release is out and you update.

It’s unusual that we are fixing vimeo by adjusting lines that Fancybox itself specifically added to make vimeo work.

Hi – sorry for delayed response on your earlier reply. Looking at this now. I can duplicate the issue on your link. I’m wondering if it has to do with the type of link. We usually anticipate standard Vimeo share links like https://vimeo.com/181645979, while yours is a vimeo player link.

I’ll investigate with this particular link, and see if I can duplicate and fix. Will reply again when I have an update.

Hey @ukandrzej – Thanks for the detailed follow up. There is a lot in your reply.

1) On documentation. I actually agree. Easy Fancybox has complex settings that are hard to understand, and the documentation needs a major overhaul. Related to this, many of the options could use in-line explanatory notes directly on the settings page. Working on both of those.

2) On the Choose Lightbox setting, I must admit I this one was clear. It’s just ‘which lightbox do you want’. It may be confusing because Fancybox Legacy vs Classic Reloaded vs V2 are nearly the same. I’ll consider adding a small explanatory note. I’m also considering adding an additional, free, non-“Fancybox” lightbox like PhotoSwipe.

3) Good to here the Automatically group images setting is working.

4) On the ‘Apply to’ setting, I didn’t realize that wasn’t saving too. That was working like 2 weeks ago, so not sure what I did, but I can duplicate. I’ll start on a fix tomorrow morning, and will include it in the next release.

Thanks again for your diligent reporting.

I just prepped a fix for this and pushed it to the main code base. It will go out with the next release. Given that, I’m going to go ahead and mark this as resolved. Thanks again.

Ok, that’s good information. So it sounds like it was a change in 2.2.2 that broke things for you. I’ll review changes in that version and see if I have thoughts on possible causes.