petschko

Lately I was a bit more busy doing other stuff, so I temporary disabled Antispam-Bee. I will write here once I have a bit time to look into that issue

(Should be next week, sorry for making you wait =()

We are using the default Theme of WooCommerce (Storefront)

I disabled all Plugins except Antispam-Bee and WooCommerce and Commenting was possible, maybe it has some issue with an other Plugin, I write here once I find out which one

Thank you so far!

Does this Plugin need write-access on some directories on the Server?

• This reply was modified 6 years, 7 months ago by petschko. Reason: Found the conflicting Plugin
• This reply was modified 6 years, 7 months ago by petschko.
• This reply was modified 6 years, 7 months ago by petschko.

Der Hotfix ist denke ich nicht die eleganteste Lösung, sprich man kann das sicherlich anders lösen. Ich habe einfach nur ein kleines JavaScript geschrieben, welches das PayPal-Iframe versteckt, bis alle variationen ausgewählt sind.

Am liebsten würde ich den Button deaktivieren, da es aber ein IFrame ist, war es das leichteste dieses einfach zu verstecken.

Wer Lust hat, kann sich das snippet hier einfach nehmen, die Funktion addPPPExpressValidation() muss noch nachdem sie Seite geladen hat, gecalled werden.
Das Script sollte man ggf nur auf Produktseiten einbinden, ist aber auch dazu fähig in eine globale JS eingebunden zu werden. Die Funktionen verhindern weiteres ausführen, wenn es sich um eine nicht Produkt-Seite bzw um eine einzel Produkt-Seite handelt.

/**
 * Adds the PayPal-Express button Validation
 */
function addPPPExpressValidation() {
	let variationForm = document.getElementsByClassName('variations_form cart');

	// Exit on any other product/page which dont have this element
	if(! variationForm.length)
		return;

	// Make sure to get only the variation selects
	let variationTable = document.getElementsByClassName('variations');

	// Add Event-Listener to all variation selects
	let variationSelects = variationTable[0].getElementsByTagName('select');
	for(let i = 0; i < variationSelects.length; i++) {
		variationSelects[i][window.addEventListener ? 'addEventListener' : 'attachEvent'](window.addEventListener ? 'change' : 'onchange', function (variations) {
			return function (ev) {
				disablePPPExpressButtonOnEmptyVariation(variations);
			};
		}(variationSelects), false);
	}

	// Also run once to ensure the pp button is vanish before (if no user interaction)
	disablePPPExpressButtonOnEmptyVariation(variationSelects);
}

/**
 * Disables (aka hide) the PayPal-Plus-Button, when a variation is not filed out
 *
 * @param {HTMLCollection} variations - Variation-selects Element-list
 */
function disablePPPExpressButtonOnEmptyVariation(variations) {
	if(! variations || ! variations.length)
		return;

	// Get all variation selects and check if they are filled
	let variationsFilled = true;
	for(let i = 0; i < variations.length; i++) {
		if(! variations[i].value) {
			variationsFilled = false;
			break;
		}
	}

	// Get the Paypal-"Button"-Container
	let paypalExpressContainer = document.getElementsByClassName('woo-paypalplus-checkout-button');

	if(paypalExpressContainer.length) {
		paypalExpressContainer = paypalExpressContainer[0];

		// Disable/show the button
		if(variationsFilled)
			paypalExpressContainer.style.display = '';
		else
			paypalExpressContainer.style.display = 'none';
	}
}

Sofern da irgendwo nen wurm drinnen ist einfach schreiben, ich fixe und update dann den Code hier (soweit lief aber alles 1A)

• This reply was modified 6 years, 7 months ago by petschko.
• This reply was modified 6 years, 7 months ago by petschko.

Ärgerlich, leider wird man hier gerne abgewimmelt mit “Paypal will das so”, sodass man sich selbst nen Hotfix-Script schreiben muss, ich kann dies gerne teilen wenn ich dazu komme

Ansonsten erst mal überall Default-Werte einstellen (nervig aber kann auch helfen bei wenig Produkten)

• This reply was modified 6 years, 7 months ago by petschko.

Was ist jetzt hiermit?

We decided to still use this Plugin, also we still want to use an Opt-In, so we created this using the “OptOut” method to “hack” into it via the functions.php

/**
 * Creates an GA-OptIn for the User to prevent tracking unless they allow this
 */
function gaOptIn() {
	$optOutCookieName = 'ga-disable-UA-xxxxxxxx-x';
	$optOutCookie = (! isset($_COOKIE[$optOutCookieName])) ? false : $_COOKIE[$optOutCookieName];

	if(! isTrackingAllowed() && ! $optOutCookie)
		setcookie($optOutCookieName, 'true', time() + 307584000); // Add the opt-out cookie to simulate an opt-in
	else if(isTrackingAllowed() && $optOutCookie)
		setcookie($optOutCookieName, '', 0); // Remove cookie if tracking is now allowed
}
add_action('init', 'gaOptIn');

We basically create the Out-Out Cookie by default on the user device, once they allow us to track them, we delete the opt-out cookie =)

And with that solution we have an Opt-In for this Plugin, just wrote it here in case someone else want an Opt-In for this Plugin~ This function need to be called before any HTML output

PS: The isTrackingAllowed() function is basically the source wherever you get value if the User allows tracking or not.
In our case its a mix of getting the DoNotTrack-HTTP-Header and if the user itself allow us to track them~

• This reply was modified 7 years ago by petschko.