sabkor

I’ve thrown some debug lines in appropriate spots in /tpls/wpdm-all-downloads.php and am trying to track down the bug. Currently here it gets set correctly:

$ext = $ext.".svg"; //isset($data['icon']) && $data['icon'] != ''?$data['icon']:$ext.".svg";

here it gets set to the correct, full URL:

                if($ext==basename($ext) && file_exists(WPDM_BASE_DIR."assets/file-type-icons/".$ext))
                    $ext = plugins_url("download-manager/assets/file-type-icons/".$ext);
                else
                    $ext = plugins_url("download-manager/assets/file-type-icons/unknown.svg");

On one of these lines:

                if(isset($data['icon']) && $data['icon'] !== '') $ext = $data['icon'];

                if(isset($params['thumb']) && (int)$params['thumb'] == 1) $ext = wpdm_thumb($post, array(96,104), 'url');

I get this notice:

PHP Notice: Trying to access array offset on value of type bool in wpdm-functions.php on line 980.

And in there the $ext variable gets set to blank. Since those are the last steps before outputting the $ext variable, the background url is blank. I’ll see if I can add some more debugging to better figure out what is going wrong, unless you have ideas.

Yes, the sort icons are there again with the update. However the package icons are still missing. For each of these, I have selected the PDF.svg icon and it was working prior to these updates.

I don’t know how to upload an image here, but here’s a link to illustrate what I’m talking about:

https://ibb.co/RCPqfLk

Bootstrap 4 was already selected. I also upgraded to v3.1.0 and it still does not work. Please note that the background URL still shows empty. It was all working fine before this latest round of updates. Here is what I see in the TD tags:

class="__dt_col_0 __dt_col __dt_col_title" style="background-image: url('');background-size: 36px;background-position: 5px 8px;background-repeat: no-repeat;padding-left: 52px;line-height: normal;"

Figured it out with the help of this bug post:
https://github.com/WordPress/gutenberg/issues/3369

Using the REST API for the custom post type also requires that the taxonomy itself be registered to use the REST API.

So, along with:
/includes/sp-news-post-type.php
Line 45 (from): ‘taxonomies’ => array(‘post_tag’)
Line 45 (to): ‘taxonomies’ => array(‘post_tag’, WPNW_CAT)

the following line has to be added to the taxonomy registration in the $args = array( section:
‘show_in_rest’ => true,

All is working as expected now (for me).

Thanks! I’ve updated and it’s all working now. I have found another issue though, I’ll create a new post for that.