mkilian
Forum Replies Created
-
Forum: Plugins
In reply to: [Disqus Comment System] Bogus DB query introduced in 2.78Just go ahead and use the diff. I’m too lazy to clone and create a pull request (it’s weekend, after all) 😉
– kili
You may want to try this one (it’s a fork of ngg based on ngg-1.9.13):
http://wordpress.org/plugins/nextcellent-gallery-nextgen-legacy/
Someone stepped up and created a fork based on ngg-1.9.13:
http://wordpress.org/plugins/nextcellent-gallery-nextgen-legacy/
Let’s hope it will be well maintained.
amphibol (and others): there’s a fork based on ngg-1.9.13: http://wordpress.org/plugins/nextcellent-gallery-nextgen-legacy/
It’s probably an alternative to keeping stuck at ngg-1.9.13.
If you give it a try, be sure to follow the instructions, especially do *not* remove ngg from within the wordpress backend, because this would trigger ngg’s deinstallation hooks and remove all your galleries. You have to remove it manually from the filesystem (using ssh, ftp or whatever you use to access your document root).
“All – Please update to version 2.0.27 as soon as you are able to. This should resolve the CRON jobs issue that was recently introduced.”
Whow! It *should*? And did your developers test it as thoroughly as the previous versions since 2.0?
And what the heck did drive your developers to fuckup the plugin by letting it create an insane number of transients and then “fix” this by introducing a cleaning cron task? This is not a proper way to handle bugs nor to develop software. If some change breaks things backout the change (instead of adding piles of additional changes which try to cleanup the fallout from former changes).
Aren’t you aware that you’re throwing shit for about 50 days now at people using ngg (and used to be happy with ngg before the 2.0 disaster)?
Seriously: may I ask you to resign from maintaining this plugin? Just release a final ngg-2.1 that’s identical to 1.9.13 and do your own fancy and new stuff under a new name. Wether something like ngg-2.1 (based on 1.9.13) will be maintained or just bitrot is another question, but *please* keep your hands out of this plugin..
— kili
ps: no, I’m not going to maintain this in any way; instead I’m going to migrate away from it
Forum: Plugins
In reply to: [Spam Free WordPress] Update broke my sitesSorry, I missed that post.
In this case, I see two possible ways to fix it:
If you have ftp or ssh access (or can remove files by other means other then using the wordpress backend), just remove the plugin.
Else, if you have some way to change or override php.ini values, try enabling PHP output buffering (output_buffering = On in php.ini). This may workaround the error you see.
Otherwise, I’m sorry i’m running out of ideas.
Forum: Plugins
In reply to: [Spam Free WordPress] Update broke my sitesWild guess (no guarantee that it works): When you load BLOG-URL/wp-admin/ (where BLOG-URL is — well — the URL of your blog), are you able to log in?
Regarding the latest updates of this plugin: I’ll send a mail to the plugin people @wordpress.org and suggest to remove it.
Ping. The plugin still needs the patch to work correctly in a multisite wordpress. Updated Patch for version 1.7 ((also available at the URL mentioned above):
Index: tweet-like-plusone.php =================================================================== --- tweet-like-plusone.php (revision 738211) +++ tweet-like-plusone.php (working copy) @@ -315,6 +315,98 @@ $ord=implode(",",$ordarr); return $ord; } +function social4i_install() { + add_option('s4pabovepost'); + add_option('s4pbelowpost'); + add_option('s4pgabovepost'); + add_option('s4pgbelowpost'); + add_option('s4habovepost'); + add_option('s4hbelowpost'); + add_option('s4aabovepost'); + add_option('s4abelowpost'); + add_option('s4_twitter'); + add_option('s4_fblike'); + add_option('s4_plusone'); + add_option('s4_fbshare'); + add_option('s4onpost'); + add_option('s4onpage'); + add_option('s4onhome'); + add_option('s4onarchi'); + add_option('s4iconsize'); + add_option('s4iconalign'); + add_option('s4excludeid'); + add_option('s4_fbsend'); + add_option('s4optimize'); + add_option('s4twtvia'); + add_option('s4excludecat'); + add_option('s4defthumb'); + add_option('s4onexcer'); + add_option('s4fblikelang'); + add_option('s4ccss'); + add_option('s4_linkedin'); + add_option('s4scripthead'); + add_option('s4allscripts'); + add_option('s4dmob'); + add_option('s4cblarge'); + add_option('s4cbsmall'); + add_option('s4_cbtn'); + add_option('s4dispord'); + add_option('s4onexcererr'); + add_option('s4nofbjava'); + add_option('s4nometa'); + add_option('s4analytics'); + add_option('s4vbhide'); + add_option('s4dispvb'); + add_option('s4vbmargin'); + add_option('s4vremove'); +} +register_activation_hook(__FILE__,'social4i_install'); +function social4i_admin_init() { + register_setting('social4i', 's4pabovepost'); + register_setting('social4i', 's4pbelowpost'); + register_setting('social4i', 's4pgabovepost'); + register_setting('social4i', 's4pgbelowpost'); + register_setting('social4i', 's4habovepost'); + register_setting('social4i', 's4hbelowpost'); + register_setting('social4i', 's4aabovepost'); + register_setting('social4i', 's4abelowpost'); + register_setting('social4i', 's4_twitter'); + register_setting('social4i', 's4_fblike'); + register_setting('social4i', 's4_plusone'); + register_setting('social4i', 's4_fbshare'); + register_setting('social4i', 's4onpost'); + register_setting('social4i', 's4onpage'); + register_setting('social4i', 's4onhome'); + register_setting('social4i', 's4onarchi'); + register_setting('social4i', 's4iconsize'); + register_setting('social4i', 's4iconalign'); + register_setting('social4i', 's4excludeid'); + register_setting('social4i', 's4_fbsend'); + register_setting('social4i', 's4optimize'); + register_setting('social4i', 's4twtvia'); + register_setting('social4i', 's4excludecat'); + register_setting('social4i', 's4defthumb'); + register_setting('social4i', 's4onexcer'); + register_setting('social4i', 's4fblikelang'); + register_setting('social4i', 's4ccss'); + register_setting('social4i', 's4_linkedin'); + register_setting('social4i', 's4scripthead'); + register_setting('social4i', 's4allscripts'); + register_setting('social4i', 's4dmob'); + register_setting('social4i', 's4cblarge'); + register_setting('social4i', 's4cbsmall'); + register_setting('social4i', 's4_cbtn'); + register_setting('social4i', 's4dispord'); + register_setting('social4i', 's4onexcererr'); + register_setting('social4i', 's4nofbjava'); + register_setting('social4i', 's4nometa'); + register_setting('social4i', 's4analytics'); + register_setting('social4i', 's4vbhide'); + register_setting('social4i', 's4dispvb'); + register_setting('social4i', 's4vbmargin'); + register_setting('social4i', 's4vremove'); +} +add_action('admin_init', 'social4i_admin_init'); function social4ioptions(){ ?> <h2>Tweet, Like, Share and Google +1 Option Page</h2> @@ -459,9 +551,7 @@ z-index: 9999; } </style> -<?php wp_nonce_field('update-options'); ?> -<input type="hidden" name="page_options" value="s4pabovepost,s4pbelowpost,s4pgabovepost,s4pgbelowpost,s4habovepost,s4hbelowpost,s4aabovepost,s4abelowpost,s4_twitter,s4_fblike,s4_plusone,s4_fbshare,s4onpost,s4onpage,s4onhome,s4onarchi,s4iconsize,s4iconalign,s4excludeid,s4_fbsend,s4optimize,s4twtvia,s4excludecat,s4defthumb,s4onexcer,s4fblikelang,s4ccss,s4_linkedin,s4scripthead,s4allscripts,s4dmob,s4cblarge,s4cbsmall,s4_cbtn,s4dispord,s4onexcererr,s4nofbjava,s4nometa,s4analytics,s4vbhide,s4dispvb,s4vbmargin,s4vremove"> -<input type="hidden" name="action" value="update" /> +<?php settings_fields('social4i'); ?> </form> </td><td width="2%"> </td><td width="20%"><b>Follow us on</b><br/><a href="http://twitter.com/techxt" target="_blank"><img src="http://a0.twimg.com/a/1303316982/images/twitter_logo_header.png" /></a><br/><a href="http://facebook.com/techxt" target="_blank"><img src="https://secure-media-sf2p.facebook.com/ads3/creative/pressroom/jpg/b_1234209334_facebook_logo.jpg" height="38px" width="118px"/></a><p></p><b>Feeds and News</b><br /><?php get_feeds_s4() ?> <p></p> @@ -839,4 +929,4 @@ } return $ismob; } -?> \ No newline at end of file +?>How about applying the above diff and fixing the plugin instead of releasing a new version which only contains your stupid advertising links?
Better (removes obsolete hidden input fields, those are now created by settings_fields()):
--- google-adsense-plug-and-play.php.orig Thu Jan 10 13:00:15 2013 +++ google-adsense-plug-and-play.php Thu Jan 10 16:31:02 2013 @@ -11,13 +11,26 @@ if (!class_exists("GoogleAdsensePlugAndPlay")) { class GoogleAdsensePlugAndPlay { function GoogleAdsensePlugAndPlay() { //constructor - + add_action('admin_init', array(&$this, 'admin_init')); } function addHeaderCode() { ?> <?php } + function admin_init() { + register_setting('google_adsense_plug_and_play', 'google_adsense_plug_and_play_backgroundcolor'); + register_setting('google_adsense_plug_and_play', 'google_adsense_plug_and_play_bordercolor'); + register_setting('google_adsense_plug_and_play', 'google_adsense_plug_and_play_bottomadtype'); + register_setting('google_adsense_plug_and_play', 'google_adsense_plug_and_play_displaypages'); + register_setting('google_adsense_plug_and_play', 'google_adsense_plug_and_play_displayposts'); + register_setting('google_adsense_plug_and_play', 'google_adsense_plug_and_play_publisherid'); + register_setting('google_adsense_plug_and_play', 'google_adsense_plug_and_play_support'); + register_setting('google_adsense_plug_and_play', 'google_adsense_plug_and_play_textcolor'); + register_setting('google_adsense_plug_and_play', 'google_adsense_plug_and_play_titlecolor'); + register_setting('google_adsense_plug_and_play', 'google_adsense_plug_and_play_topadtype'); + register_setting('google_adsense_plug_and_play', 'google_adsense_plug_and_play_urlcolor'); + } function addContent($content = '') { global $wp_query; global $post; @@ -261,7 +274,7 @@ <h2>Google Adsense Plug and Play - Settings</h2> <form method="post" action="options.php"> -<?php wp_nonce_field('update-options'); ?> +<?php settings_fields('google_adsense_plug_and_play'); ?> <table width="850"> <tr valign="top"> @@ -369,9 +382,6 @@ </tr> </table> - -<input type="hidden" name="action" value="update" /> -<input type="hidden" name="page_options" value="google_adsense_plug_and_play_publisherid, google_adsense_plug_and_play_bordercolor, google_adsense_plug_and_play_titlecolor, google_adsense_plug_and_play_backgroundcolor, google_adsense_plug_and_play_textcolor, google_adsense_plug_and_play_urlcolor, google_adsense_plug_and_play_topadtype, google_adsense_plug_and_play_bottomadtype, google_adsense_plug_and_play_displayposts, google_adsense_plug_and_play_displaypages, google_adsense_plug_and_play_support" /> <p> <input type="submit" value="<?php _e('Save Changes') ?>" /> @@ -382,4 +392,4 @@ <BR><BR> <?php } -?> \ No newline at end of file +?>See this ticket (includes a patch): http://plugins.trac.wordpress.org/ticket/1618
I’d suggest to not come back.
Looks like the plugin maintainer already changed it.
See http://plugins.trac.wordpress.org/changeset/608549/embed-youtube
He also rolled a new .zip file for download, but unfortunately didn’t bump the version.
FWIW, the previous code did add some HTML text likek this to every footer:
<style type=”text/css”>.credits_off {display:none;}</style><center><small class=”credits_off”>pseudo random text</small></center>
That’s why I called it “hidden” (because of the display:none).
Oh, well, I’m sure the hidden link your plugin adds to the footer of *every* post and page is also only to help people.
Or is it just a lame attempt to trick people into doing some SEO for you?
I also wonder why the Plugin name in the meta data is “Youtube” and not something like “Embed Youtube”. So people who have installed the former “Youtube” plugin (which had been removed from the plugins repository) automatically now get “upgrades” to your plugin.