Leon

Hi Richard,

Sorry for the delay getting back to you!

I can see that the issue seems like it is resolved. Is that the case or do you need me to look into it further?

Cheers

No worries 🙂

Ok, well that gives me more info to look at. So it seems the issue is when deleting all players. There is always one left?

Checking/unchecking players updates the wpcm_players array dynamically using javascript. I expect that’s where the issue is rather than caching.

I’ll look into it but I am curious to know how often this issue is a problem?

I can’t imagine why you would need to delete all players after a game has been played so I’m interested to know when this occurs and if I can improve the plugin, besides fixing the deleting the last player issue?

Cheers

Hi,

I’ve just done some testing and deleting (unchecking) players from the Player selection list on the match page works as expected.

If you uncheck a player they are removed from the wpcm_players array and any stats they acquired during that match are removed from their stats.

Have I misunderstood something? Are you referring to deleting players from the roster list or something else?

Cheers

Hi,

1. I’ll test that out. Unchecking the player should remove them from the player stats array for that match so if that isn’t happening I’ll fix it asap.

2. Nothing has changed to the template system for a long time so I don’t know what could be happening there. I’m not having this issue and I’ve not had any other reports of this (which I would have done by now) so I’m not sure what’s going on there. I do notice you are using a child theme so maybe you are changing the wrong templates?

Cheers

Hi,

No problem, you’re welcome 🙂

Thanks for the review, it is very much appreciated.

Cheers

Hi,

Thanks for letting me know, I’ll add the un-minimized versions in the next release.

Cheers 🙂

Hi janustudios,

No problem. This template should give you what you are after:

<?php
/**
 * Standings
 *
 * @author 		Clubpress
 * @package 	WPClubManager/Templates
 * @version     2.1.0
 */

if ( ! defined( 'ABSPATH' ) ) exit; // Exit if accessed directly ?>

<div class="wpcm-standings-shortcode wpcm-standings">

	<?php echo ( $title && ! $type == 'widget' ? '<h3>' . $title . '</h3>' : ''); ?>
	
	<table>
		<thead>
			<tr>
				<th>Rank</th>
				<th>Team</th>
				<th>Team Color</th>
				<?php
				foreach( $columns as $column ) { ?>
					
					<th class="<?php echo $column; ?>"><?php echo $stats_labels[$column]; ?></th>
				
				<?php } ?>
			
			</tr>
		</thead>
		<tbody>
		
		<?php foreach ( $clubs as $club ) {
			
			$club_stats = $club->wpcm_stats; ?>
			
			<tr class="<?php echo ( $default_club == $club->ID ? 'highlighted ' : '' ); ?>">

				<td class="pos">
					<?php echo $club->place; ?>
				</td>

				<td class="club">
					<?php 
					echo $club->thumb;
					if( $default_club == $club->ID ) {
						if( $abbr == 1 ) {
							$club_abbr = get_club_abbreviation( $club->ID );
							echo $club_abbr;
						} else {
							if ( $team_label ) {
								echo $team_label;
							} else {
								echo $club->post_title;
							}
						}
					} else {
						if( $abbr == 1 ) {
							echo ( $link_club == 1 ? '<a href="' . get_the_permalink( $club->ID ) . '">' : '' );
							$club_abbr = get_club_abbreviation( $club->ID );
							echo $club_abbr;
							echo ( $link_club == 1 ? '</a>' : '' );
						} else {
							echo ( $link_club == 1 ? '<a href="' . get_the_permalink( $club->ID ) . '">' : '' );
							echo $club->post_title;
							echo ( $link_club == 1 ? '</a>' : '' );
						}
					} ?>
				</td>

				<td>
					<?php $color = get_post_meta( $club->ID, '_wpcm_club_primary_color', true ); ?>
					<span style="background: <?php echo $color; ?>; color:#fff; display: block; width: 35px; height: 35px;  border-radius: 25px;"></span>
				</td>

				<?php foreach( $columns as $column ) { ?>
					
					<td class="<?php echo $column; ?>"><?php echo $club_stats[$column]; ?></td>

				<?php } ?>

			</tr>

		<?php } ?>

		</tbody>
	</table>
	<?php if ( isset( $linkpage ) ) { ?>
		<a href="<?php echo get_page_link( $linkpage ); ?>" class="wpcm-view-link">
			<?php echo $linktext; ?>
		</a>
	<?php } ?>
</div>

Hope that helps 🙂

Will do Gilles, no probs 🙂