Forum Replies Created

Viewing 15 replies - 226 through 240 (of 1,766 total)
  • Theme Author Creative Themes

    (@creativethemeshq)

    Hi @zax007,

    Thanks again for the reply.

    1. Yes, correct, both actions will have $type as they argument
    2. Why you call this action if the element itself is not present on the page? If you need to put something even if hero isn’t present, you need a more higher level action, not the one tied to that element.
    3. Disabled means fully removed from HTML
    4. I totally understand your concern about default values, but in your case you were already playing with the framework internals. And when you start to do that, you need to take care of doing things exactly like the framework is doing. You can copy a half solution and then hope everything will just work.

    I hope this makes sense.

    Theme Author Creative Themes

    (@creativethemeshq)

    @zax007 Thanks for your reply.

    1, 2. If blocksy_get_page_title_source is null then you can be sure that the page title is disabled. If blocksy_akg_or_customizer('hero_section', blocksy_get_page_title_source()); returns null, then this means that the value hero_section is not present yet in the resulting array (user didn’t make any changes to that option) so you need to supply the default. This is not pure guessing, this is how the Blocksy’s options system works. If you want your custom code to work correctly, you need to respect these rules, this was done so to not compromise on performance issues.
    3. Yes, blocksy:header:after would be also covered by this change, you’ll be able to access it as an argument so you don’t have to go through the hassle of computing it yourself. If the hero is disable, this action won’t be called at all obviously. This change will be available in the next release, if you need it earlier — please let me know.

    Hope this makes sense.

    Theme Author Creative Themes

    (@creativethemeshq)

    Hi @zax007,

    Sorry for the delayed reply.

    It’s totally normal that you get null in response for this function. First of all, you need to understand that blocksy_get_page_title_source() function is dependent on the current page and it returns null if the page title is disabled for the page you’re currently on.

    That is, before attempting to even call blocksy_akg_or_customizer, you need to make sure blocksy_get_page_title_source() is non-null.
    Also, blocksy_akg_or_customizer() has a 3rd argument, which is absolutely needed to cover all the cases — the default value.
    If you’d look in inc/components/hero-section.php, we provide a correct default value when attempting to compute the hero type (type-1 or type-2):

    		$actual_type = blocksy_akg_or_customizer(
    			'hero_section',
    			blocksy_get_page_title_source(),
    			$default_type
    		);
    

    But, to make things easier for you, we could supply the hero type as an argument to the blocksy:hero:after action, so you don’t have to compute it yourself.

    Please let me know if this sounds good and I’ll prepare this small improvement for the action for the next update.

    Sorry again for the delayed reply. All the best!

    Theme Author Creative Themes

    (@creativethemeshq)

    Hi @zax007,
    We received your request, please be patient, we will reply as soon as possible.

    We are giving more importance to real support tickets and reply to feature request once we have time.

    Hope you will understand me right.

    Plugin Author Creative Themes

    (@creativethemeshq)

    Hi @ruianacleto,
    Thank you very much for your kind words 🙂

    Theme Author Creative Themes

    (@creativethemeshq)

    Hi @prabuddh09,

    Please note, you don’t have to share the credentials of your site in a public forum, that is agains WordPress forums rules.

    Theme Author Creative Themes

    (@creativethemeshq)

    Hi @prabuddh09,
    Could you please share a link to the page where this happens?

    Theme Author Creative Themes

    (@creativethemeshq)

    Hi @zax007,
    Could you please share a link to your website so we could see the result you are getting?

    Plugin Author Creative Themes

    (@creativethemeshq)

    @crewstyle thanks for the reply. That one has a good value too… Very strange…

    Is the Olympus framework that you mentioned public? How can we test it on our end?
    Or, if you could do a minimal setup in LocalWP and send us over an export of the setup with reproduction, we’ll take care of the fix from the Companion side.

    Waiting for your reply and thanks again for your messages!

    Theme Author Creative Themes

    (@creativethemeshq)

    @errorbook, thank you very much for your kind words, we are really glad that you like our theme 🙂

    Have a wonderful and productive week!

    Plugin Author Creative Themes

    (@creativethemeshq)

    Hi Achraf,

    Thanks a lot for the research that you’ve done.

    If BLOCKSY_PATH has a good value, then, most likely, the read_installed_extensions() method gets a null from somewhere. Can you please post here the output of glob($single_path . '/*', GLOB_ONLYDIR) from this method? We will see which of the returned values cause the issue with trying to read the config.php file of the extension.

    I’m thinking there is a small miss (like an empty directory or an unusual file) in your filesystem that is breaking the extensions discovery mechanism that we use.

    If you could dig a little deeper in this direction and post your findings, that would be great.
    Of course we can just blindly add the is_null() check, this is not hard, but first we want to understand the situation that we are dealing with.

    Also, besides that, could you please reach out at hq at creativethemes dot com? We have a small proposal for a potential colaboration between us.

    Thanks and looking forward to hear from you soon.

    Plugin Author Creative Themes

    (@creativethemeshq)

    Hi Achraf,

    Thanks a lot for the feedback and for going into details.
    Both of these are confirmed and we will have a fix for them in the next public release.

    Thanks again and have a great day!

    Theme Author Creative Themes

    (@creativethemeshq)

    Hello @acejou,
    As I can see you are using the pro version of our theme, in this case please submit a support ticket on this link because this forum is for free users only.

    Plugin Author Creative Themes

    (@creativethemeshq)

    Hello @larsvonhierblau,
    That’s weird, everything works fine on our end, no errors in the console.

    Could you please share your website url so we could take a closer look at your setup?

    Theme Author Creative Themes

    (@creativethemeshq)

    I understand what do you mean now 🙂

    Well, in past we had our own lazy load functionality and we where able to add a CSS transition/animation to all images that are in the process of lazy loading.

    In the previous update we got rid of our solution and implemented the WordPress native lazy loading functionality because it has already a very good support in all browsers.
    The only thing is that the WordPress native lazy loading doesn’t have a transition applied to all images while they load, but this doesn’t mean that your images are not lazy loaded 🙂

    If you will take a closer look at your website source code, you can see that all images have an attribute loading="lazy", please see this video – https://d.pr/v/lUBbHp

    So, to sum up, everything works like it should, the only thing is that there is no image animation when the image is loaded, but that’s not a problem from our side, this is how WordPress lazy load works.

    Hope this makes sense.

Viewing 15 replies - 226 through 240 (of 1,766 total)