Diana van de Laarschot
Forum Replies Created
-
Forum: Plugins
In reply to: [Category Posts in Custom Menu] Undefined Index?Hi John and tyarnn0us,
thank you for your messages. I’m afraid in my test environment I don’t see this problem at all. I’m guessing there’s some default parameter that isn’t being set properly, but at first glance I don’t see where the problem is.
Which actions are you performing when you see this error? Editing the menu or viewing the website? (Both?)
Kind regards,
DianaForum: Plugins
In reply to: [Category Posts in Custom Menu] Undefined Index?Hi John,
I’m sorry you’re experiencing this, I thought I had tackled this. I will look into it ASAP.
Kind regards,
DianaForum: Plugins
In reply to: [Category Posts in Custom Menu] Throws some PHP errors but worksHi tyrann0us,
thank you for reporting back.
I thought I had edited the changelog but apparently I haven’t, I’ll update it!Kind regards,
DianaHi xaver,
thank you for reporting, it was indeed a bug in the default value. This will be fixed in the next release, or you can grab the Development Version if you need it right now.
Kind regards,
DianaHi funorang,
I have just created a ticket (https://core.trac.wordpress.org/ticket/32918) to request changes to _wp_menu_item_classes_by_context in order to fix this.
Kind regards,
DianaHi funorang,
I *think* I have found the cause. There is a standard WordPress function _wp_menu_item_classes_by_context, that builds up these classes. (CPCM does not do this, but instead calls _wp_menu_item_classes_by_context.) It might be the case that this function assumes the menu structure was unchanged, because I see it reading some values from the original structur (via the database), so it does not know about the changes CPCM has made.
I will try to fix this after CPCM has called _wp_menu_item_classes_by_context.
Kind regards,
DianaHi,
I understand you’re missing the class “current-menu-ancestor”
So you have
– PROJECTS which is a WordPress Page
– COMMERCIAL which is a Taxonomy
– COMPLETED which is also a Taxonomy, so I’m guessing it’s a subtaxonomy
– PROJECT20, which is a postEdit: I have been able to reproduce this, I’ll see what I can do.
Kind regards,
DianaHi funorang,
I’ve had some troubles with the CSS classes in the past, it’s true. Could you please tell me which class you are missing exactly?
Kind regards,
DianaHi xaver,
thank you very much for reporting this. You are saying Skip was set to 0 in the previous version and after update it became -1? I will look into it, thank you for reporting!
Kind regards,
DianaHi funorang,
no problem, I’m glad your problem is solved! 🙂
Good luck with your site, it’s looking good.Kind regards,
DianaHi funorang,
hm, it should really not have lost its settings, 1.2.0 should fix that… Or are you saying the checkbox was unticked but you other CPCM setting were still preserved?
Anyway, as for the behavior on your site, I’m really gonna have to ask you to perform steps 1,2,3 in my earlier post and then tell me what your menu settings are, so that I can reproduce the issue here and help you
Kind regards,
DianaForum: Plugins
In reply to: [Category Posts in Custom Menu] After Upgrade Plugin not workingHi funorang,
is this the same issue as you reported in the other topic?
Could you please go to Appearance > Menus and tell me if your settings have been preserved in the update to 1.2.0?Kind regards,
DianaHi funorang,
I’m not sure what I’m looking at. From what I understand, you mean that on the project page, the full menu is not showing. As far as my plugin is concerned, it receives the menu structure from WordPress and then adapts it according to its settings. I cannot straightaway explain why options are missing, the result should be the same on every page, unless another plugin or the theme are conflicting.
Can you
1. Go back to the default WordPress theme.
2. Disable all other plugins.
3. Reproduce this with a regular WordPress Post, not a custom post type.Can you also give me exact and specific instructions on what your settings are for my plugin, so that I can reproduce it? (Note that I will be using the default WordPress theme.)
Kind regards,
DianaForum: Plugins
In reply to: [Category Posts in Custom Menu] After Upgrade Plugin not workingHi funorang,
version 1.1 indeed has a problem, I’ve retracted it and have brought out version 1.2.0. Have you updated to 1.2.0?
Kind regards,
DianaForum: Plugins
In reply to: [Category Posts in Custom Menu] Version 1.1 retracted due to upgrade problemI’ve just released 1.2.0 which fixes this issue.
This has been tested for both an upgrade path with the (now retracted) version 1.1 and a direct update from 1.0.1:- 1.0.1 -> 1.1 -> 1.2.0
- 1.0.1 -> 1.2.0
My sincere apologies to all who experienced this issue.
Kind regards,
Diana