ulicgn
Forum Replies Created
-
Hello @duracelltomi , the problem still persists even with the current version. Would it help to attach the output of wp post get / wp post meta list of a post that has the garbled output?
( To the moderators: please consider unlocking me, I can’t see a reason why my posts are being held for moderation. Thanks. )
- This reply was modified 9 months ago by ulicgn. Reason: moderator comment
The ACF WYSIWIG component allows to switch between a visual and a text view (similar like the old classic editor). With some, not all, of the “broken” posts the visual preview is empty, while the text view has text and wp-paragraph tags. We can not really track how the broken code got into the ACF fields, but in the first place it might be a broken validation / sanitation within the WYSIWIG component.
Nevertheless, I think that whatever is placed in that field, broken or not, should not be trusted and not lead to this sort of site-breaking output with gtm4wp, so thanks for your effort to find the cause.
I will try to prepare a dump of the ACF field content from our staging site where we possibly still have unfixed “broken” content.
Forum: Fixing WordPress
In reply to: 6.8 squishes post plugins into bottom scroll boxI ended off here being affected (and annoyed) by this design decision. It is surprising that “commenting on a closed issue” is a recommended thing to to – feels like beating a dead horse. So I will add a suggestion there to make this change hackable with a filter hook for people who are not willing to adopt it, or if there are plugins involved that create their metaboxes in an incompatible way.
Quite lot of css hacks can already be found in the wild, and creating an official one might do the trick.
That is good to hear, thanks! We are looking forward to the fix.
- This reply was modified 1 year, 1 month ago by ulicgn.
Oh, and regarding your demo with the repeating event – see the difference between the <title> of
view-source:https://demo.theeventscalendar.com/events/
and the <title> of
view-source:https://demo.theeventscalendar.com/
The second one is right, the first one broken. So: fix instead of filter needed 😉Thank you for pointing out the relevant code and filter hooks. So yes, there may be ways to override the title. The filter examples simply use static text. But calculating a correct date range to display with a filter would be quite complex to say the least – it would mean to repeat all the (many) calculations that are already done in the code.
Instead, the broken / incorrect title generation should be fixed. Like in your demo – the page does not show events from 2022, but from today on, and so the title must reflect this. This is IMHO a bug, not a customization that can be fixed on a filter level.
According to our Analytics data (where the <title> is displayed in some reports) the title was correct up to the beginning of March. Only after deploying the latest updates it changed to suddenly show past dates.
So I quickly created a sandbox site at https://s-qwjsxpj4snb5l.eu1.wpsandbox.org
Steps:
1) Create sandbox site with 2020 theme, generatepress theme and TEC plugin2) import a handful events from CSV, one of them being old (April 2024)
3) See event start page at : https://s-qwjsxpj4snb5l.eu1.wpsandbox.org/events/
Visible Content is ok, Events from today on. HTML title content is wrong:
<title>Events from April 17, 2024 – April 17 – My WPSandbox site</title>So from here on you should take over, clearly an issue with TEC and not our environment. Also see your own demo at https://demo.theeventscalendar.com/events/
Regards Ulrich
( NB the demo site will only survive for 8 hours, however it has proven that the problem occurs with the stock version of TEC in a clean environment)
Hi @tristan083 ,
it was probably not a good idea to mix both bugs regarding the translation and the content of the <title> tag in one ticket. For now I would like to focus on the wrong content of this field, so let’s leave the language aside. The problem with the wrong date in the <title> occurs regardless of the site being set to german or english.
So have you looked at https://demo.theeventscalendar.com/events/ ? This is probably a place where you can get access easily. The title there goes back to December 2o22!
<title>Events from December 1, 2022 – April 20 – The Events Calendar</title>So I think that obsoletes the need for a screen cast, does it? Whether or not you can reproduce the wrong <title> may depend on the date of the events you have in your DB. If you have old (past) events, then the <title> shows the date of the oldest event.
Regarding the theme used: the date range that is shown in the <title> changes from theme to theme. In my dev site:
Theme: Our custom child theme of GeneratePress (Free) with custom code and templates:
<title>Veranstaltungen aus 16. Januar – 17. Januar – Stadtportal koeln.de</title>
Theme: GeneratePress (Free) stock version:
<title>Veranstaltungen aus 16. Januar – 17. Januar – Stadtportal koeln.de</title>
Theme: Twenty-X ( all stock WP themes from 2023 to 2025)
<title>Veranstaltungen aus 8. Februar – 18. März – Stadtportal koeln.de</title>Strange enough that the output differs, but it is wrong in both variants. The correct title would be a <title> that contains TODAYs date, not a past one.
Regards
Ulrich(N.B. We meanwhile replaced the wrong translation with a filter hook on the title, so you can not see it any more, but the root cause (wrong translation) should be fixed anyway.)
Forum: Plugins
In reply to: [The Events Calendar] lots of 404 errors generated for non-existing CSSThat’s great! So closing here. Thanks!
Forum: Plugins
In reply to: [The Events Calendar] lots of 404 errors generated for non-existing CSSHi there,
@tristan083 thanks for your reply and code suggestion. And yes, it works, using this code will make the 404s go away. (I tried it, and just to be safe added a wp_deque_style(), and then 404s are gone.) However I would not like to use this code in production for a longer time – the overhead of executing it for every WP request is IMHO probably larger than dealing with the 404s.
Actually I was hoping for a bug fix – it is definitely a bug in wp-content/plugins/the-events-calendar/src/Tribe/Editor/Blocks/Featured_Image.php , and should be fixed there. Will you take care of enquing this for a fix? Thanks.Regards Ulrich
Wow, that was fixed very quickly – it looks OK in the frontend output now, Thanks!!
Forum: Plugins
In reply to: [WooCommerce] New “LIVE” label on wordpress toolbar, why?I hated this live badge from the very first second I saw it. And yes I had clients being concerned since the LIVE label of course appeared in dev and stage sites, causing confusion. I disapprove plugin authors acting as if their plugin is the only one in the world and cluttering the global menu, and I already have more than enough workarounds for useless stuff like this.
Having a sign popping up only if CommingSoon is active might be a good compromise if they insist to have a badge, but even better to put it into the dedicated Woo screen space like in the woo admin screens, not in the global menu.Forum: Plugins
In reply to: [The Events Calendar] ORM examples not working as described@eventsbtz I never used 5.x, but from what I read on several forum threads things must have been much less complex back then. The same is true for using WP-all-import which did work for some people before 6.x.
I would not recommend going back though, given that meanwhile WordPress and PHP versions have evolved and you might run into other problems.
So we are doomed to wait until this functionality is fixed and works as documented with their new table structure.
As stated in Darians response, the number of users impacted is a factor for prioritizing, so all you can do is to report the problems that you are facing so that they know.
And, @d0153 , you also said that “how the bug impacts one’s ability to sell tickets” does matter for priority. I can tell you that all the bugs that keep us from regularly importing events from our ticket vendor (this one being one of them) are severely impacting our ticket sale commissions.
So I am very interested about how things are going regarding BTRIA-2310
Forum: Plugins
In reply to: [The Events Calendar] ORM examples not working as describedHello @jdbeacham,
thanks for your suggestions! Regarding the content of my custom field, the key to retrieve it with get_post_meta() is autogenerated, in my case it was _ecp_custom4 , not my given field name “_rawdata”. But yes, it did work this way.
Regarding wp_set_post_terms(31028,’Konzerte’,’tribe_events_cat’,true) and tribe_update_event() – that did not work for me. See reports at:
https://wordpress.org/support/topic/programatically-create-and-update- events/ for another example.So what is the current status of methods to change/update existing events programatically ?
Regards
Ulrich