trusktr
Forum Replies Created
-
Forum: Plugins
In reply to: [eShop] BUG: The javascript for eShop is not defined properly.That’s alright, I can use my modified version until then. 😉 If my fix makes it into the source it’d be cool to know that I contributed. 😀
Forum: Plugins
In reply to: [eShop] BUG: The javascript for eShop is not defined properly.Alright, I fixed it. The variables are added dynamically while still using wp_enqueue_script().
So basically, I swapped line 134 with 135 in eshop.php, then on line 135 I changed ‘wp_head’ to ‘wp_print_scripts’ so in eshop.php we have this:
http://pastie.org/3886667Then I removed the script from the eshop_action_javascript() function and put it in a seperate file called ‘eshop-cart.js’. Now the eshop_action_javascript() function in public-functions.php looks like this:
http://pastie.org/3886677The wp_localize_script() function writes the parameters to the HTML before the script is included on the page. So inside eshop-cart.js we use ‘eshopCartParams.addfadein’ (etc) to use the php-generated variables.
The generated HTML looks like this:
http://pastie.org/3886686and eshop-cart.js looks like this:
http://pastie.org/3886689Now the script is properly registered and so it follows wordpress standards. It works now with plugins like “JavaScript to Footer”.
Below is a zip file containing the modified plugin. Can you checkout the differences and apply a patch to the plugin here on wordpress.org?
Forum: Plugins
In reply to: [eShop] BUG: The javascript for eShop is not defined properly.Hello esmi, I moved the script to the footer and it works just fine. After moving all other scripts to the footer, I changed ‘wp_head’ to ‘wp_footer’ on line 134 in eshop.php as a temporary fix. It works perfect.
I’ll make a working solution and post it in a little while.
Forum: Plugins
In reply to: [eShop] BUG: The javascript for eShop is not defined properly.Why not do something like
<script src="eshop_action_javascript.php?addfadein=100&addfadeout=3000&etc"></script>then include it with wp_enqueue_script()?
Forum: Plugins
In reply to: [eShop] BUG: The javascript for eShop is not defined properly.For example, you need to do something like this:
// activate modified Shutter reloaded if not use the Shutter plugin <?php if ( ($this->options['thumbEffect'] == "shutter") && !function_exists('srel_makeshutter') ) { wp_register_script('shutter', NGGALLERY_URLPATH .'shutter/shutter-reloaded.js', false ,'1.3.3'); wp_localize_script('shutter', 'shutterSettings', array( 'msgLoading' => __('L O A D I N Ghello', 'nggallery'), 'msgClose' => __('Click to Close', 'nggallery'), 'imageCount' => '1' ) ); wp_enqueue_script( 'shutter' ); } ?>You must use the wp_enqueue_script() function.
Does it take time for the posts to be published (for example every 15 min, or once per day, etc)?
Forum: Fixing WordPress
In reply to: How to move a page between custom post types?I’m betting that the simple solution is to do a search and replace through the database to change the types of your posts to whatever you like.
Sorry about the cross posting. Thanks for the details!
So why does this happen? Perhaps Rols Scoper should follow the settings established by Capability Manager (or similar plugins) unles otherwise manually configured?
Forum: Plugins
In reply to: [Plugin Notes] code is eatenThat’d be cool… seems easy enough to add it!.. you should add it and send the mod over!
Forum: Plugins
In reply to: [WP Popular Posts] Errors with timthumb!Oops, nevermind, I was mistaken. There’s nothing wrong with the plugin…
However, I do get many errors like this:
PHP Warning: touch() [<a href='function.touch'>function.touch</a>]: Unable to create file ./cache/c5add1575fe9c81d0261195f9626f5ef.png because Permission denied in /var/www/vhosts/sk8earth.com/httpdocs/wp/wp-content/plugins/wordpress-popular-posts/scripts/timthumb.php on line 236, referer: http://sk8earth.com/wp/All in all, not a big deal. You’ll just get two emails, and you have to click the link from the correct email each time (its easy to differentiate).
FOr the most part, it continues to work along side of Peter’s Collaboration Emails….
There’s one caveat though: When a user makes a revision, Revisionary plugin will send and email and so will Peter’s Collaboration Emails plugin.
The link sent from Revisionary looks like this:
http://sk8mappr.com/wp/wp-admin/admin.php?page=rvy-revisions&action=view&revision=157And the link from Peter’s Collaboration Emails looks like this:
http://sk8mappr.com/wp/wp-admin/post.php?action=edit&post=157The difference is that with second link you will be taken to the WordPress interface for editing the post instead of Revisionary’s interface… and when you publish via WordPress’s interface, it has the effect of not putting the revision into effect. You can of course “restore” the revision through Revisionary’s interface to put it into effect.
It’d be super awesome if you can modify Revisionary so that it will redirect revisors if they happen to land on the WordPress interface instead of the Revisionary interface, or something along those lines.
Also, I’ll try and see If I can talk to Peter about detecting if Revisionary is active, then having his plugin avoid sending the Collaboration email.
Yeah, that might be it. Thanks for the tip.
Forum: Requests and Feedback
In reply to: How much lines of code are allowed in a WP.org forum post?“Good idea. Done”…. Yes, a good idea indeed… but I don’t see the “Done” part? I don’t see any such notification anywhere near this post edit box… ???
Here’s a few lines of code I’m working on:
[edited]Forum: Fixing WordPress
In reply to: Why is my loop exhibiting strange behavior? Please help!Ok, so I determined what the difference is between TwentyTen and my theme that causes this bug:
My code:
<div class="entry-content"> <?php the_content( __('<p>Expand →</p>', 'whatever') ); ?> </div>TwentyTen’s code:
<div class="entry-content"> <?php the_content( __( 'Continue reading <span class="meta-nav">→</span>', 'twentyten' ) ); ?> <?php wp_link_pages( array( 'before' => '<div class="page-link">' . __( 'Pages:', 'twentyten' ), 'after' => '</div>' ) ); ?> </div><!-- .entry-content -->This tiny small difference is the difference between bug and no bug. If i replace my three lines with TwentyTens, all is well.
Why would mine (simpler) produce 4 (four) .more-link anchor tags???
I think this might be a bug. It’s so weird!!! Switching between those snippets inside my loop is the only difference that toggles this problem.