staze
Forum Replies Created
-
Forum: Plugins
In reply to: [WP Resume] [Plugin: WP Resume] Summary ProblemBenjamin,
Just updated to 2.0, and it’s STILL got the double $’s for the summary. =P Somehow your change didn’t make it into Trunk it seems.
Forum: Plugins
In reply to: [WordPress HTTPS (SSL)] Login subdomainMike,
What settings are used for this? I’ve enabled and set shared SSL to be “https://admin.example.com”, and then enabled “force shared ssl admin”, but I don’t see any change.
Thanks!
Forum: Plugins
In reply to: [WP Resume] [Plugin: WP Resume] Summary ProblemBenjamin,
This still seems to be broken, though I just upgraded to 1.6.6. Seems the extra $ is still there.
Forum: Plugins
In reply to: [Bit.ly Shortlinks] BUG? using WP shortlink to generate bit.ly link…coffeemonk,
I’m seeing this too, but with a bit more info. When I create a post, and save a draft, it seems bit.ly shortlinks generates a link with the WP shortcode rather than the clean-url. When I then publish the post later, it generates ANOTHER bit.ly link with the clean-url. So bit.ly has two links for most of my posts…
That said, the “bit.ly stats” link in the admin bar seems to always go to the bit.ly link based on the WP shortlink, not the clean-url based one.
Looking at the code, it seems Yoast knew this might happen, and has an if that says
if ( ( is_singular() && !is_preview() ) || $context == 'post' ) {
but either WordPress changed something, or “!is_preview” isn’t doing what it should be doing.Maybe a check to see if the post is a draft would be better… something like:
if ((is_singular() && !is_preview() && $post['post_status'] == 'publish')Oh, crap… I know what the problem is… it’s a typo. It SHOULD read:
if ( ( is_singular() && !is_preview() ) || $_context == 'post' ) {Notice the $_context and not just $context. I don’t know if that’ll fix this issue, but it is a typo, as $_context is a real variable used for what a post is doing, displaying, posting, saving, etc.
Hopefully Joost will be able to confirm/deny this…
Sweet. Just installed 0.2.3.3.
Thanks!
Forum: Plugins
In reply to: [Bit.ly Shortlinks] [Plugin: Bit.ly Shortlinks] Error in headerdidn’t think it would.
the change does indeed seem to have fixed the issue. Thanks for the detective work. Hopefully Yoast will integrate this, or something similar, into his codebase.
Forum: Plugins
In reply to: [Bit.ly Shortlinks] [Plugin: Bit.ly Shortlinks] Error in headerTesting blogologist’s fix… so far, so good… but then, I didn’t see the error consistently.
mbartizmo,
Good to know. Though it _shouldn’t_ matter in this case, it’s probably safer for the real fix by Yoast to be single quotes.
Also glad to know I’m not the only one that saw this issue. If it weren’t for my site being in Google’s webmaster tools, I would have never known the issue existed (Webmaster Tools was nice enough to warn me that there was a bad date in my sitemap).
looks like the change was made in rev 315637. switched from using the php date() function to using mysql2date, but didn’t change what $time was equal to.
What I still can’t figure out is why I only hit this bug today… I’ve updated my site between this change (and my update of wordpress-seo) and now, yet I only hit it today.
Weird weird weird. Anyway, thanks for the awesome product. I’m just happy I can contribute back a bit. =)
AH HA! Typos be damned!
On line 96 of xml-sitemap-base-class.php you have:
$time = time();
This is incorrect, as mysql2date is expecting a mysql statement. It SHOULD read:
$time=”time()”;
What I can’t figure out is how that typo got in there, since the svn change logs don’t seem to indicate you did anything with that line. And if it’s been that way for a while, then what changed? time() is a php function… so really, this never should have worked.
Anyway… fixed!
I attempted adding “$url[‘mod’] = ”” to the initial blog stuff (under “//Add the homepage first”) in xml-sitemap-base.php, but that seems to make no difference.
If I could figure out where the initial date comes from, I might be able to better debug this… could you fill me in on where the blog “last modified date” comes from?
Also, I’ve noticed that wordpress-seo doesn’t give an error if it can’t generate the sitemap due to a permissions error. it just acts like normal, but doesn’t actually write out the new sitemap.xml(.gz).
Thanks!
Forum: Plugins
In reply to: [Link Library] [Plugin: Link Library] Doesn't support wp_plugin_urlOkay, I responded to this a couple days ago, but it didn’t post. Weird.
Anyway, WP_CONTENT_URL points to static.hostname.org, and WP_PLUGIN_URL points to http://www.hostname.org.
static.hostname.org is just for static content (images, css, js, etc)… but WP_PLUGIN_URL has to be set so things like wordpress-seo work.
The only thing that seems broken with link library is the icon on the admin page is a “?” since it’s trying to connect over HTTPS to static.hostname.org, when the SSL cert is for http://www.hostname.org.
That said, I was able to work around that just now by changing line 539 in link-library.php to:
$pagehooktop = add_menu_page(__('Link Library General Options', 'link-library'), "Link Library", 'manage_options', LINK_LIBRARY_ADMIN_PAGE_NAME, array($this, 'on_show_page'), WP_PLUGIN_URL . '/link-library/icons/folder-beige-internet-icon.png');It’s ugly, but it allows that icon to load. Not sure what else might be broken, but the only thing obvious is the admin menu icon.
it works! setting to resolved. Thanks!
heh. no problem. it’s easy enough to fix it myself for now.
Thanks!
still broken in 0.2.0.