professor99

Hi gpsake.

You probably know this already but have some info that may be useful to you and others.

Done a bit more investigation of what is really going on and have noted the differences between WordPress 3.4.2 and 3.5.1.

Basically WordPress 3.5.1 uses a new “Insert Media” interface for posts. This uses it’s new wp.media interface and that’s what creates our problem.

For both WordPress 3.4.2 and 3.5.1 the WPUF Rich Text editor option results in wp_editor being called which in turn calls the function wp-admin/includes/class-wp-editor.php:editor(). This in turn invokes the action ‘media_buttons’ which results in the function wp-admin/includes/media.php:media_buttons() being called.

From here on WordPress 3.4.2 and 3.5.1 differ.

For WordPress 3.4.2 the following excerpt shows wp-admin/includes/media.php:media_buttons() calling get_upload_iframe_src(..) which for WPUF results in the link wp-admin/media-upload.php?post_id=0 being added to the “Upload/Insert” button. This results in the attachment not being added to the Add/Edit Post Form.

wp-admin/includes/media.php
=============================

function media_buttons($editor_id = 'content') {
	$context = apply_filters('media_buttons_context', __('Upload/Insert %s'));

	$img = '<img src="' . esc_url( admin_url( 'images/media-button.png?ver=20111005' ) ) . '" width="15" height="15" />';

	echo '<a href="' . esc_url( get_upload_iframe_src() ) . '" class="thickbox add_media" id="' . esc_attr( $editor_id ) 

. '-add_media" title="' . esc_attr__( 'Add Media' ) . '" onclick="return false;">' . sprintf( $context, $img ) . '</a>';
}
add_action( 'media_buttons', 'media_buttons' );
...
function get_upload_iframe_src( $type = null, $post_id = null, $tab = null ) {
	global $post_ID; /** Set to new post id by edit-form-advanced.php. Null for WPUF Add/Edit Post **/

	if ( empty( $post_id ) ) /** Null for WPUF Add/Edit Post **/
		$post_id = $post_ID;

        /** For $post_id = null => (int)$post_id = 0 **/
	$upload_iframe_src = add_query_arg( 'post_id', (int) $post_id, admin_url('media-upload.php') );

	if ( $type && 'media' != $type )
		$upload_iframe_src = add_query_arg('type', $type, $upload_iframe_src);

	if ( ! empty( $tab ) )
		$upload_iframe_src = add_query_arg('tab', $tab, $upload_iframe_src);

	$upload_iframe_src = apply_filters($type . '_upload_iframe_src', $upload_iframe_src);

	return add_query_arg('TB_iframe', true, $upload_iframe_src);
}

For WordPress 3.5.1 the following excerpt shows wp-admin/includes/media.php:media_buttons() calling wp_enqueue_media(..). However at the beginning of media_buttons() it calls get_post() which gets the loop page which for WPUF is either the Add or Edit page with the shortcodes. This is the cause of our problems with WordPress 3.5.1.

wp-admin/includes/media.php
===========================

/**
 * Adds the media button to the editor
 *
 * @since 2.5.0
 *
 * @param string $editor_id
 */
function media_buttons($editor_id = 'content') {
	$post = get_post(); /** Gets the loop page. For WPUF this is the pages with the Add/Edit shortcodes **/
	if ( ! $post && ! empty( $GLOBALS['post_ID'] ) )
		$post = $GLOBALS['post_ID'];

	wp_enqueue_media( array(
		'post' => $post
	) );
...
}
add_action( 'media_buttons', 'media_buttons' );

The possible workarounds are numerous.

1. Add a custom editor (like you have done)
2. Replace the media_buttons action
3. Use the media_view_settings filter in the function wp-includes/media.php:wp_enqueue_media() to set the settings as desired for WPUF. This is probably the easiest option.
4. Use a filter or action further down the call stack to achieve the desired result.

Below is the relevant excerpt from wp-includes/media.php:wp_enqueue_media()

wp-includes/media.php
======================

function wp_enqueue_media( $args = array() ) {
...
	$post = null;
	if ( isset( $args['post'] ) ) {
		$post = get_post( $args['post'] );
		$settings['post'] = array(
			'id' => $post->ID,
			'nonce' => wp_create_nonce( 'update-post_' . $post->ID ),
		);

		if ( current_theme_supports( 'post-thumbnails', $post->post_type ) && post_type_supports( 

$post->post_type, 'thumbnail' ) ) {
			$featured_image_id = get_post_meta( $post->ID, '_thumbnail_id', true );
			$settings['post']['featuredImageId'] = $featured_image_id ? $featured_image_id : -1;
		}
	}
...
	$settings = apply_filters( 'media_view_settings', $settings, $post );
	$strings  = apply_filters( 'media_view_strings',  $strings,  $post );

	$strings['settings'] = $settings;

	wp_localize_script( 'media-views', '_wpMediaViewsL10n', $strings );
...

Ultimately this is a WordPress bug as attachments shouldn’t be linked to the post till the user has pressed the “Insert Post/Page” button. I am probably putting in a WordPress trac bug report on this.

For gpsake I am posting you my complete function trace so you can see what’s going on.

Cheers
The Professor

To WPChina,

To save yourself some work you could also use the WordPress “Permalink Settings” option to set all permalinks to a default of your own choosing

%home%/wp-admin/options-permalink.php

The only thing that I can think of in WPUF that may be causing your problem is the option ‘Admin area access’. Try disabling this to see if it solves your problem.

Im thinking $wp_admin_bar->remove_menu(‘wp-logo’) removes the admin bar for the duration of your session hence why it persists despite the deactivation of WPUF.

I do a similar thing but without problems as follows. Try this and see if it fixes your problem.

global $user_login;
get_currentuserinfo();

/* Hide admin bar for non-admins */
if ( $user_login != 'admin' ) {
	add_filter( 'show_admin_bar', '__return_false' );
}

I haven’t heard of this before. Please post the code you are using to do this in functions.php and we might be able to see what is causing it.
Strange the problem persists after deactivating WPUF. This would point to another plugin causing this problem so I would deactivate all other plugins first to see if this fixes the problem.

Edit wpuf_edit_user.php and change wpuf_user_edit_profile_form() to show_form().

Fixed this a while back in the development version

Don’t have this problem myself but Im using WordPress 3.4.2. Is this just a WordPress 3.5.1 problem? Is it a problem with everybody that’s using WordPress 3.5.1?

Do you have the search plugin Relevanssi installed? We have had very similiar problems with this