Forum Replies Created

Viewing 9 replies - 1 through 9 (of 9 total)
  • Hi spswm,

    I’m not using the plugin anymore, so I don’t know if anything has changed. At the time it was a bug in the plugin.

    I also think it’s a bug. The plugin does not seem to honor its own “Force rewrite titles” setting.

    Above suggestion is a good workaround.

    In the plugin code, the __constructor function of WPSEO_Frontend needs to be changed so that add_filter( 'wp_title' ... ) is only run when ‘forcerewritetitle’ is ON.

    Hello Sang,

    Tested latest in Safari and Chrome on Mac OS X with WP 3.3.1 and it works!

    Nice fix. Thanks!

    Super!

    I can recommend my hacks above 😉

    Hi Tien,

    Thanks for the update.

    I’m afraid that the new version still does not work on/with:

    • Chrome browser (tested on both Windows and Mac OS X)
    • Safari browser (tested on Mac OS X)

    It does work in FireFox (tested on both Windows and Mac) and Internet Explorer.

    What I did:

    1. Open an existing Post to edit.
    2. Drag a new Text widget from the “Available Widgets” window
    3. Edit the new widget and click “save”

    Ok, error in the pw_fix_widget_forms function. Improved version below:

    function pw_fix_widget_forms( $list = '' ) {
    	ob_start();
    	switch( $list ) {
    	case 'wp_list_widgets':
    		wp_list_widgets();
    		break;
    	default:
    		wp_list_widget_controls($list);
    		break;
    	}
    	$output = ob_get_contents();
    	ob_end_clean();
    	$output = str_replace ( array('<form action="" method="post">','</form>'), array('<div class="pw_postbox">','</div>'), $output );
    	echo $output;
    }

    Hi all,

    Scoe’s solution did not work for me, so I investigated a little further.

    Found that Webkit browsers (Safari, Crome) don’t allow for nested form elements to be created using javascript. That is what the “add widget” drag-drop does.

    I’ve changed the plugin PHP (see below) so that it transforms the <form> elements into <div> elements. Next changed the plugin JavaScript to conform to that change.

    It works for me on Safari, Chrome, FireFox and IE.

    Please test some more 🙂

    Hope Metalscorpion or CodeAndMore are following…

    Edit wp-page-widgets.php
    1. add new function

    function pw_fix_widget_forms( $list = '' ) {
    	ob_start();
    	switch( $list ) {
    	case 'wp_list_widgets':
    		wp_list_widgets();
    		break;
    	default:
    		wp_list_widget_controls($list);
    		break;
    	}
    	$output = ob_get_clean();
    	ob_end_clean();
    	$output = str_replace ( array('<form action="" method="post">','</form>'), array('<div class="pw_postbox">','</div>'), $output );
    	echo $output;
    }

    2. Change line 245 to
    <?php pw_fix_widget_forms('wp_list_widgets'); ?>

    3. Change line 260 to
    <?php pw_fix_widget_forms('wp_inactive_widgets'); ?>

    4. Change line 283 to
    <?php pw_fix_widget_forms( $sidebar ); // Show the control forms for each of the widgets in this sidebar ?>

    Edit page-widgets.js
    Change line 191 to
    var sb = widget.closest('div.widgets-sortables').attr('id'), data = widget.find('.pw_postbox').find('input, textarea').serialize(), a;

    macjoost

    (@macjoost)

    Hi,

    Like the plugin a lot, but have the same problem as lucasmartins

    Spend some time on it and finally discovered that the plugin works fine in FF, but doesn’t work with Safari or Chrome on the Mac.

    Somehow when dragging a “simple” widget like the Text widget to the sidebar, in the resulting HTML the <form> tags are missing.

    When dragging a more complex widget like the Tags widget to the sidebar, all works fine.

    I’m completely puzzled by this. I did quite some testing, checking the loaded JS libraries etc. but I can’t find any solution.

    Hi,

    Got the same problem with WordPress 2.6.5 and some .htaccess redirection like Trevor had. The problem is in sitemap-core.php in the function GetBackLink(). This function uses $_SERVER['PHP_SELF'] which is not correct in my and Trevors setup (it includes the sub-directory which we hide with redirection).

    Fixed it differently:
    Changed line 2433 of sitemap-core.php from:
    return $_SERVER['PHP_SELF'] . "?page=" . $page;
    to:
    return admin_url(basename($_SERVER['PHP_SELF'])) . "?page=" . $page;

    I’m not quite sure if this is valid for all the times the GetBackLink function is called, but it works for updating the settings and manually updating the sitemap.

Viewing 9 replies - 1 through 9 (of 9 total)