Forum Replies Created

Viewing 15 replies - 1 through 15 (of 19 total)
  • Plugin Author Frederick D.

    (@freddyware)

    This plugin has been deprecated by built-in WordPress support for oEmbed: http://codex.wordpress.org/Embeds#Can_I_Use_Any_URL_With_This.3F

    Thread Starter Frederick D.

    (@freddyware)

    Actually, I fixed it. On line 56,

    Changing
    define('CJTOOLBOX_URL', WP_PLUGIN_URL . '/' . CJTOOLBOX_NAME );
    and the block immediately after it to

    define('CJTOOLBOX_URL', plugin_dir_url(__FILE__) );
    define('CJTOOLBOX_MEDIA_URL', CJTOOLBOX_URL . 'public/media');
    define('CJTOOLBOX_CSS_URL', CJTOOLBOX_URL . 'public/css');
    define('CJTOOLBOX_JS_URL', CJTOOLBOX_URL . 'public/js');

    seems to work.

    Plugin Author Frederick D.

    (@freddyware)

    Hi Faisal,

    There is no longer a need to use Simpler iPaper with the newest versions. See http://codex.wordpress.org/Embeds

    Hi,

    I’m running into the same problem, BUT…

    I’m pretty sure it only affects CSS files where the image path is specified as background-image: url('images/header.jpg'); and not files where the URL is in the form of background-image: url(images/header.jpg);. Weird bug, but probably a regular expression issue.

    For the moment I’ve chosen not to include those stylesheets in minification, but I would like to be able to include them.

    Frederick D.

    (@freddyware)

    Hi,

    While it seems possible to do damaging things with CSS expressions, there’s nothing in the plugin currently to deal with this.

    There’s the WordPress.com-released Safe CSS plugin (http://wordpress.org/extend/plugins/safecss/) which uses its regular expressions combined with CSS Tidy to clean up and optimize CSS code. I’d recommend using that if you’re serious about duplicating the functionality they have on WordPress.com.

    It’s a little difficult to deal with CSS expressions in regular expressions, but looks like they’ve managed to find a way to clean expressions by leveraging CSS Tidy.

    Hi Ovidiu,

    The 4th parameter in htmlspecialchars() is a boolean flag to re-encode entities that are already encoded. However, this flag only exists on PHP versions 5.2.3 and above.

    I’ve just realized that I made a foolish mistake by using it, since I was setting it to FALSE anyways (the default value). I am pushing out a maintenance version today to fix this bug, and to update compatibility to 3.0-alpha.

    Regards,
    Frederick Ding

    I think the most important three items for me are items that plugins don’t do or don’t do well:

    1. Merge with WordPress µ and support for multiple blogs on subdomains/domains (like @donnacha proposed)
    2. Easier linking to internal content so that the links will update if permalinks change and will be disabled if the content is deleted
    3. For new installations, a built-in Welcome Guide that displays a checklist like configuring settings and setting up categories.

    Generally, though, I would agree that it’s better not to make WordPress too bloated. There’s a lot of plugins for some of these features, like an admin bar.

    Alternatively, a lot of these features could be plugins that are bundled with the distribution (canonical plugins?) so that users who don’t want them can turn them off. Kind of like Akismet.

    Thread Starter Frederick D.

    (@freddyware)

    Awesome! Glad to see that this helped other users.

    Hi,

    — is the HTML entity for the em-dash which looks like this: —. It’s wider than a hyphen (just compare — to -).

    This shouldn’t be a problem unless your browser doesn’t support the — entity.

    Regards,
    Frederick

    Hello,

    I’ve verified that the regular expression pattern used,

    /@import.+;( |)|((?:\/\*(?:[^*]|(?:\*+[^*\/]))*\*+\/)|(?:\/\/.*))/i

    indeed strips out ALL CSS that includes a URL — it’s the last condition: (?:\/\/.*) . Originally I used this to prevent users from inserting external CSS that couldn’t be controlled by a WordPress mu admin — for example, @import url(http://example.com/badstyles.css) or abusing background-image: url(http://photosite.com/notsafeforwork.jpg) .

    Seeing this problem, I’m planning on loosening the restrictions in the regular expressions in the next minor version (0.4) to allow background image URLs.

    Given the seriousness of this bug, as compared to the other aesthetic issue you mentioned in your other post, I’ll be releasing 0.4 with the fixed regex pattern today.

    Regards,
    Frederick

    Hi,

    There does appear to be an XHTML error, with a <td> tag that is mistakenly not closed. I’ve fixed the issue on my local copy and will be committing it as 0.3.1 soon.

    This doesn’t seem to be relevant to the code you copied above, though, so please let me know if there is another issue.

    On another note, I would recommend that you upgrade from WordPress 2.7.1 to WordPress 2.8. I’m not seeing any obvious cosmetic issues on WordPress mu 2.7.1 nor on WordPress 2.9-rare.

    Regards,
    Frederick

    Hi Ovidiu,

    About enqueue-ing styles, that only works with external CSS files, so the plugin would have to generate static files to be loaded by wp_enqueue_style(). Since the CSS is being filtered and outputted in the <head> section, it’s not possible to use the enqueue function.

    Regarding things being stripped out: I don’t think url() properties should be stripped out; only loading external CSS is supposed to be stripped out. Right now it’s 11 p.m. where I am, so I’ll have to examine this in detail when I wake up tomorrow.

    Regards,
    Frederick

    Hi Ovidiu,

    Thanks for your feedback. I’ll look into this soon and post a fix when I see the problem.

    Regards,
    Frederick

    Frederick D.

    (@freddyware)

    Hi.

    Thank you for your feedback. Having looked through the other CSS plugin, it seems that it adds a reference to the custom stylesheet in the <head> section and provides a backend to edit that stylesheet file. (Actually, the database solution is much easier to manage and code, and more compatible — no FTP access or read/write privileges required.) Since the other plugin only adds a <link href /> to the external stylesheet, it is not possible to filter that CSS file except upon save.

    I understand what you’re saying about one file for each theme — that plugin provides the functionality to override the styling of a particular theme, while Simpler CSS applies site-wide. Would you be in support of a possible feature in my plugin, Simpler CSS, to support saving multiple stylesheets and enabling one of them?

    Thank you for using Simpler CSS.

    Regards,
    Frederick

    Thread Starter Frederick D.

    (@freddyware)

    @richschmidt: I had already disabled Post Revisions when I was using 2.6. PodPress will not work with Post Revisions on, unless you apply Andrew Ozz’s patch.

Viewing 15 replies - 1 through 15 (of 19 total)