Firelight
Forum Replies Created
-
Forum: Plugins
In reply to: [Firelight Lightbox] Inline Content Pop Up IssueGreat! Very glad we managed to get this resolved.
Forum: Plugins
In reply to: [Firelight Lightbox] Inline Content Pop Up IssueHi there – We have progress because the JS for our plugin is actually loaded on your page independently now rather than being bundled with something else from Siteground Opimizer.
I can still see the error on your page, and it is still going to be a conflict with siteground optimizer.
The next thing to try is please exclude jquery in the section about excluding files from defer / render blocking javascript.
You will need to exclude:
/wp-includes/js/jquery/jquery.min.js
/wp-includes/js/jquery/jquery-migrate.min.js
It will look like this when done (arrows show what to click on).
https://d.pr/i/WUmI1lForum: Plugins
In reply to: [Firelight Lightbox] Inline Content Pop Up IssueActually, I think I know what is going on. I think you are using a plugin that is minifying and concatenating javascript files, and thus changing how they are loading. It is taking our javascript, which should be loaded after jquery, and it is combining it with other JS and loading it before jquery.
Looking at your site and what’s loaded, I suspect it may be the site ground optimizer. Can you confirm if you’re using that plugin?
If so, please try excluding our javascript.I think you could do it like this:
- From dashboard, go to SG Optimizer Settings
- Go to Frontend tab
- Scroll down to the ‘Minify JavaScript Files’ section, and in the ‘Exclude from Minification’ and ‘Exclud from Combine JS’ sections, you can add a file or ‘handle’. The handle for our file is ‘jquery-fancybox’ so add that in both fields. You can also try the file path, which should be ‘/wp-content/plugins/easy-fancybox/fancybox/1.5.4/jquery.fancybox.min.js’
- Save
There are also some code base ways to do this outlined here:
https://www.siteground.com/tutorials/wordpress/speed-optimizer/custom-filters/Forum: Plugins
In reply to: [Firelight Lightbox] Inline Content Pop Up IssueOne small finding that’s really confusing me is that jquery IS loaded on your page. So jQuery is there is there, but you are still somehow getting a ‘jQuery is not defined’ error.
Forum: Plugins
In reply to: [Firelight Lightbox] Inline Content Pop Up IssueHey – This not something I can duplicate, and I also can’t understand or think of a reason it would be happening. I’m wondering if you’d be willing to reach out to me at firelightwp.com/contact to coordinate on some more in-depth troubleshooting? Please just reference this thread if so.
Otherwise, I may need to suggest some code edits/changes (if you know a bit of PHP) so we can try to eliminate some possible causes.Forum: Plugins
In reply to: [Firelight Lightbox] Inline Content Pop Up IssueHi @sitenex –
Sorry for the delay. Ok, so we just need to figure why jquery is not loading (or if it is, why our lightbox is not seeing it. I just checked your home page based on your link above, and I *do* see jquery on the page. I don’t see any galleries on that page. Could you provide a link to a page with a gallery? I’d like to see the console error and double check if jquery is loading or not.- This reply was modified 1 year, 6 months ago by Firelight.
Forum: Plugins
In reply to: [Firelight Lightbox] Lightbox doesn’t work with Tablesome tableSo I (kind of) have a fix for this. The catch is that it is in the Pro version. I’m not sure if I’m going to fix this for the free lightboxes or not. Pro is using more modern JavaScript and is easier to work with and improve for situations like this.
I know you’re not a Pro user, and since I feel bad I’m not fixing it in the free version for you, I’m willing to offer you 6 months free for Pro. If interested, reach out at https://firelightwp.com/contact/
Otherwise, I’ll think about if I’m going to extend this to the free lightboxes and get back to you!
I’d like to add to this.
We need to be able to refire the JS for Firelight Lightbox when a new Tablesome page is loaded. If ajax is always being fired, we may be able to hook onto a generic even like ajaxComplete. That would be good, because the solution would apply not just to Tablesome, but to other plugins using ajax to update page content.
But I’m testing this now on a production site, and I actually don’t see an ajax request being made. So I’m wondering if, in at least some cases, pagination does use an ajax request. Maybe all needed data needed for a table is already fetched on initial page load, and is just being broken into page using frontend JS.In that case, the simplest solution here would be if Tablesome fires it’s own event each time a page is updated, ie like ‘tablesomePageChange’. If so we could simply do something like this:
document.addEventListener('tablesomePageChange', function() {
// Reinitialize lightbox after pagination
});But I haven’t been able to find such a an event either in the docs or by digging through the code.
Can you confirm if there’s an event being fired? If not, would you consider adding one?
Forum: Plugins
In reply to: [Firelight Lightbox] Lightbox doesn’t work with Tablesome tablePokemon site! I love it. It makes me very happy to see the plugin used on a nice looking pokemon site.
I can confirm what you’re seeing and I understand the root issue. I see the links are opening the image on the first page, but for me, any page after that, the links no longer open in the lightbox.
The reason is we’re using ajax are something similar to load fresh content on the page. Our plugin is JavaScript based. When your page first loads, it looks for certain markup on the page, and updates that to make the lightbox work.
When the ajax call on later pages updates the markup, there’s nothing telling the plugin to fire again, and re-check and re-adjust markup for the lightbox to work.
So…. we need a way to make our plugin essentially re-fire its JS on each page reload for you. I’ve updated the code to specifically do this for certain common plugins, like NextGEN. Theoretically, I could update the code for this case.
But a more scalable solution is to allow users to somehow do this themselves. Otherwise, next week, someone with another plugin doing ajax calls could have the same problem.
I’ll spend some time thinking about this today and get back to you. I’ll also try to think of or prep a quick fix at the least so you can get this working.Forum: Plugins
In reply to: [Firelight Lightbox] Inline Content Pop Up IssueHi,
Yes, the lightbox requires jquery to work. There appear to be two issues:
1. First your site is not loading jquery. It should load by default on most WordPress sites. We / you need to figure out why it is not loading on yours.
The only way to produce that using our plugin is to toggle the option to not use jquery. Can you please be sure that this option is not checked? https://d.pr/i/UKfbfA
Otherwise, please check if you have any other plugins or code that would be preventing jquery from loading.
2. Second, and a bit more confusing… Normally, if jquery is not there, we simply will not load the fancybox scripts. So if everything is working as expected, and jquery is not there, you shouldn’t get the console error. What should be happening is… just nothing. The link simply won’t work because we detect jquery is not there as a dependency and do not load our scripts.
The only way to load our scripts without jquery is to toggle the option I mentioned above. So I’m hoping that’s what you’ve done somehow. Otherwise, I probably need to figure how you are getting the lightbox to load without jquery.Forum: Plugins
In reply to: [Firelight Lightbox] Lightbox doesn’t work with Tablesome tableHi – sorry for the delayed response on this. Just wanted to let you know I’m having a look now. thanks for providing the link!
Forum: Plugins
In reply to: [Firelight Lightbox] Plugin Not workingHi I just wanted to follow up and see if you had a chance to check the setting above?
Just wanted to follow up and see if you had a chance to try the change above?
Forum: Plugins
In reply to: [Firelight Lightbox] navigate between modal popupsHey Dan – Great! Glad you got this worked out.
And yes, we are thinking the same way about making it easier to add custom rels. When doing that, I may also add the ability to add other custom attributes (like data-fancybox-group) which are used in various situations.
For now, since we’ve resolved this immediate issue, I’m going to mark this resolved. If I get the features above added in the relative near future, I’ll also follow up here.Hi – I’m wondering if you can please try going to your dashboard > Lightbox to get to the plugin settings page. In the first accordion panel at the top for ‘Enable’, can you expand that and check if Enable for Youtube is turned on? If not, please try selecting that and check if the issue is resolved for you?
The issue may be a combination of a small logical change in how that settings works, combined with the addition of the new script as a dependency.