Ben Cary

Taking a closer look at your plugin code.

convert_single_image() Properly receives one attachment ID. And it seems to work properly, it converts the single physical file from PNG to JPG as expected.

update_image_data() Seems to discard the directory. It begins to only identify the file by the basename:

<?php
$old_name = basename( $this->image['link'] );
$new_name = basename( $this->image['new_url'] );

Then it performs the global replacements:

<?php
WHERE meta_value LIKE '%/filename.png%'
REPLACE( meta_value, '/filename.png', '/filename.jpg' )

It looks like this would impact:

• Other attachments’ _wp_attached_file metadata
• Other attachments’ serialized image metadata
• Post content and excerpts
• Options and third-party plugin tables
• Any URL ending with the same filename, regardless of directory

So one physical PNG file is converted and then several unrelated files are changed to .jpg resulting in 404’s.

Appreciate your quick responses.

I have done some further troubleshooting and confirmed that when we have files that use the same filename and convert a single file from PNG to JPG, the plugin is changing the file extension of all the filenames to end in .jpg in the Media Library.

Here’s an example:

/wp-content/uploads/2023/11/Screen-Shot-2023-10-31-at-3.53.44-PM.png
/wp-content/uploads/2023/10/Screen-Shot-2023-10-31-at-3.53.44-PM.png
/wp-content/uploads/2017/07/Screen-Shot-2023-10-31-at-3.53.44-PM.png

Those are the 3 original files. They all exist in different directories, they all have unique IDs. It’s a bit of a mess because this client is essentially uploading the same image with same filename (a mess we are attempting to clean up – and your plugin has come in very handy btw).

But when I only convert one file, say:

/wp-content/uploads/2023/11/Screen-Shot-2023-10-31-at-3.53.44-PM.png

That will convert all of the files to have the .jpg extension when viewing the Media Library. And this is resulting in some 404’s because I believe the plugin is actually only converting one file to JPG (as it should). But it seems to be changing the URLs in the DB for all of the images, pointing to .jpg files that don’t exist for 2 of the images.

In regard to the issue where the plugin would display the ‘server is not powerful enough’ message – I knew this was not directly related to server resources. I can throw an abundance of resources at the server and still get the same results. I think this is happening when files are corrupted or have a .png extension and may not actually be PNG files. I’m still looking into this further and it’s possible the message may occur for various reasons. I’ll keep looking at this & checking the logs to see what I find. I believe it was just coincidence that when I originally ran into the issue it was only on these files that had the same filename.

• This reply was modified 6 days, 4 hours ago by Ben Cary.

Double checked my local sever and I’m definitely running PHP 7 via MAMP. Went ahead and restarted the server and tried again. Still receiving the following error:

Fatal error: Cannot use BracketSpace\Notification\Core\Notification as Notification because the name is already in use in /Applications/MAMP/htdocs/wh/wp-content/plugins/notification/class/Abstracts/Trigger.php on line 14
The site is experiencing technical difficulties. Please check your site admin email inbox for instructions.

Thanks,
Ben