archon810
Forum Replies Created
-
Should it be the same button, with a dropdown selector for the specific forms? The plugin already fetches a list of forms as you can select a default one in the settings, so why not just show it here too and allow the user to select one?
We decided to abandon the plugin and roll our own simple one, so I won’t be sending a PR, but hope that you fix it yourself at some point. Good luck.
Forum: Plugins
In reply to: [Broken Link Checker] Update 1.11.13 broke the siteHi Nithin,
To confirm, there was a new release – will it wreak havoc if we roll it out? It doesn’t mention any improvements related to db.
Forum: Plugins
In reply to: [Broken Link Checker] Update 1.11.13 broke the siteI believe we could create a new ticket and our developers can take a closer look at this too.
I agree, and I thought this ticket here was serving this purpose until it got closed.
Basically, the idea is to never perform queries that would affect the whole db due to a public visitor visiting the site and only limit those to admin users, preferably with locking so that only one maintenance query could execute at a time (add locking via an expiring after 10 minutes Transient, for example).
Can you please start a new ticket so that this issue is given the top priority for the next release, or else I’m afraid we and many other users are going to end up with downed sites again?
Thanks.
Forum: Plugins
In reply to: [Broken Link Checker] Update 1.11.13 broke the siteHi Patrick,
You can navigate to Advanced Tools and limit the plugin usage:
This does not work in this scenario and isn’t part of the issue because these db queries get fired for every client connecting to the site independent of the performance settings on that page and all queue up long before there’s any sort of load.
In fact, the plugin wrongly assumes what the server’s purpose may be and that the db resides on the same servers, whereas in reality, web and db are always separated on large sites. The load on the web server may remain low because all threads are stuck waiting for db queries to finish forever.
Forum: Plugins
In reply to: [Broken Link Checker] Update 1.11.13 broke the siteIn the end, I had to blow up all the data directly in MySQL and restart from scratch. I hope this issue will be resolved by the next update because it just wasted half of my day.
Forum: Plugins
In reply to: [Broken Link Checker] Update 1.11.13 broke the siteLiterally all you have to do is not make any admin calls decisions when not in wp-admin. I only briefly skimmed the code, but my guess is that adding
is_admin()around//Ensure the database is up to date if ( BLC_DATABASE_VERSION !== $blc_config_manager->options['current_db_version'] ) { require_once BLC_DIRECTORY . '/includes/admin/db-upgrade.php'; blcDatabaseUpgrader::upgrade_database(); //Also updates the DB ver. in options['current_db_version']. }would fix the issue and prevent every single visitor from running the db upgrade flow.
Forum: Plugins
In reply to: [Broken Link Checker] Update 1.11.13 broke the siteIn addition, now activating the plugin results in this (I cut out a huge list of IDs there) and then shows up on every backend page for every user: https://gist.github.com/7401da917e1b639540add23721ce7320.
- This reply was modified 5 years, 8 months ago by archon810.
Forum: Plugins
In reply to: [Broken Link Checker] Update 1.11.13 broke the siteI momentarily forgot about this and updated the plugin on our site, and all hell broke loose, taking down our site and making the db slaves lag for an hour after I disabled the plugin due to slaves executing the hundreds of OPTIMIZE queries one by one.
What’s been the progress of preventing updates from trashing the database?
Forum: Fixing WordPress
In reply to: Cannot type a space at the end of last lineIs this the same issue? https://core.trac.wordpress.org/ticket/47187
Forum: Plugins
In reply to: [Contact Form 7] Notice: Trying to access array offset on value of type nullThanks, looking forward to this fix before we update every server to PHP 7.4.
Forum: Plugins
In reply to: [Broken Link Checker] db migration run to oftenThe other issue was closed, and I don’t really understand what you’re doing now to correct this one.
Please address the fact that you run db migration when any visitor comes to the page rather than only doing it for the first access to wp-admin. Your approach makes no sense.
Db migrations are fine and are necessary sometimes, but performing them in the way you’re doing now is unacceptable.
Can we expect a fix for this procedure in a future update?
Forum: Plugins
In reply to: [Broken Link Checker] db migration run to oftenIt happened again (judging by the comments at least – we haven’t updated yet for this reason) https://wordpress.org/support/topic/update-1-11-13-broke-the-site/.
- This reply was modified 5 years, 11 months ago by archon810.
Forum: Plugins
In reply to: [Broken Link Checker] Update 1.11.13 broke the siteLooks like the same issue we warned you about here after the last update https://wordpress.org/support/topic/db-migration-run-to-often/.
Forum: Plugins
In reply to: [Post Snippets - Custom WordPress Code Snippets Customizer] PHP 7.4 supportSolving this issue would be a good start.