Support » Plugin: Broken Link Checker » Update 1.11.13 broke the site

  • Resolved selycha

    (@glashsix)


    Hi just wanted to give a heads up.

    After doing something today, that you should never do! ( learned this the hard way )… I updated the plugin to the new version in the morning in production, and ended up breaking things pretty badly.

    The new update changed something that caused our server to become unresponsive. Couldn’t really investigate what and why, but php-fpm didn’t function properly after the update.

    We removed the plugin completely until we are sure it’s going to be fine to put it back.

    Good Luck

Viewing 12 replies - 16 through 27 (of 27 total)
  • archon810

    (@archon810)

    In addition, now activating the plugin results in this (I cut out a huge list of IDs there) and then shows up on every backend page for every user: https://gist.github.com/7401da917e1b639540add23721ce7320.

    • This reply was modified 10 months ago by archon810.
    archon810

    (@archon810)

    Literally all you have to do is not make any admin calls decisions when not in wp-admin. I only briefly skimmed the code, but my guess is that adding is_admin() around

    
    			//Ensure the database is up to date
    			if ( BLC_DATABASE_VERSION !== $blc_config_manager->options['current_db_version'] ) {
    				require_once BLC_DIRECTORY . '/includes/admin/db-upgrade.php';
    				blcDatabaseUpgrader::upgrade_database(); //Also updates the DB ver. in options['current_db_version'].
    			}
    

    would fix the issue and prevent every single visitor from running the db upgrade flow.

    archon810

    (@archon810)

    In the end, I had to blow up all the data directly in MySQL and restart from scratch. I hope this issue will be resolved by the next update because it just wasted half of my day.

    Plugin Support Patrick – WPMU DEV Support

    (@wpmudevsupport12)

    Hi @archon810

    Sorry to hear you are having this issue.

    You can navigate to Advanced Tools and limit the plugin usage:

    https://monosnap.com/file/jCruGlXRtLJGywV59lIAGp2uKRwC88

    In case the issue persists, could you please create a new ticket and we can take a closer look?

    Best Regards
    Patrick Freitas

    Plugin Support Patrick – WPMU DEV Support

    (@wpmudevsupport12)

    Hi @archon810

    Sorry, I didn’t see page two on this ticket.

    You can try to limit the usage as I suggested.

    But I checked your code and the case, I believe we could create a new ticket and our developers can take a closer look at this too.

    We are already working on a new version for the plugin that will have some performance fixes.

    Best Regards
    Patrick Freitas

    Hi Patrick,

    You can navigate to Advanced Tools and limit the plugin usage:

    This does not work in this scenario and isn’t part of the issue because these db queries get fired for every client connecting to the site independent of the performance settings on that page and all queue up long before there’s any sort of load.

    In fact, the plugin wrongly assumes what the server’s purpose may be and that the db resides on the same servers, whereas in reality, web and db are always separated on large sites. The load on the web server may remain low because all threads are stuck waiting for db queries to finish forever.

    I believe we could create a new ticket and our developers can take a closer look at this too.

    I agree, and I thought this ticket here was serving this purpose until it got closed.

    Basically, the idea is to never perform queries that would affect the whole db due to a public visitor visiting the site and only limit those to admin users, preferably with locking so that only one maintenance query could execute at a time (add locking via an expiring after 10 minutes Transient, for example).

    Can you please start a new ticket so that this issue is given the top priority for the next release, or else I’m afraid we and many other users are going to end up with downed sites again?

    Thanks.

    Plugin Support Nithin – WPMU DEV Support

    (@wpmudevsupport11)

    Hi @archon810,

    I do understand you, we have already escalated your feedback and suggestions into our developer’s attention and we’ll be looking further regarding what could be done in improving the anomalies noticed in the plugin side.

    Really appreciate your feedback. Have a nice day ahead.

    Kind Regards,
    Nithin

    Hi Nithin,

    To confirm, there was a new release – will it wreak havoc if we roll it out? It doesn’t mention any improvements related to db.

    Plugin Support Adam – WPMU DEV Support

    (@wpmudev-support8)

    Hi @archon810

    This last release was indeed “additional” one to improve WordPress 5.5 compatibility. While it most likely won’t help with the DB issue (unless as a “side-effect”) it shouldn’t cause any additional problems.

    Kind regards,
    Adam

    diegoms

    (@demssite)

    Hi @wpmudev-support8 I don’t really understand. We have two sites down yesterday.We have last version installed (1.11.14).

    As long as I understand there’s no fix for this yet. What can we do?

    When are you planning on solve this issue?

    What can we do meanwhile?

    I attach a link to the issues we are facing.

    https://imgur.com/hHozD4n

    • This reply was modified 9 months ago by diegoms.
    Plugin Support Prathamesh – WPMU DEV Support

    (@wpmudev-support7)

    Hello @demssite,

    Could you help me with a few things to try and replicate the issue on my lab site?
    Here is all I need:

    1. WordPress Version
    2. PHP Version
    3. Does your server have object caching or Static Server Cache enabled?
    4. Did you enable the debug log and then check if you see any errors logged?
    5. Did you take a plugin conflict test?

    Kindly consider doing point 3 and 4 once on your staging site. If you would be planning to do that on the live site, please make sure you have a full site backup before you do that. We do not recommend you to do the tests on the live site unless very much necessary.

    Also, prefer opening a new thread next time when you have a fresh issue or even if it is existing to what you see on forums and the solutions there did not work as this thread was opened by some other member who may get disturbed by the emails being sent due to the replies being made under their thread.

    Thank you,
    Prathamesh Palve

Viewing 12 replies - 16 through 27 (of 27 total)
  • The topic ‘Update 1.11.13 broke the site’ is closed to new replies.