shortcode issues

I’ve noticed that the plugin uses only the administrative settings. Overrides on these settings using the shortcode options does not work. This appears to be caused by some of the logic statements in the wp-gpx-maps.php file.

For example, I have the default to have the summary “true” which works. Shortcode summary=false or summary=”false” does not override this setting. This is because the value is passed as a string from WordPress. The code, however, assumes a logical value. PHP assumes a string is “true” unless it is empty. Changing the conditional statement for the summary from if ( true == $summary (which is always true unless $summary is ”) to if ( $summary = “true” fixes the issue.

There are several other shortcode logic statements that have this same issue.

Am I missing something? Or is this a correct explanation?

I was going to open this issue on github but did not see an issues option on the project page (https://github.com/devfarm-it/wp-gpx-maps). Is that the right project? I also did not see a way to contribute a change. Looks like this would require a fork and then submit those back as suggested changes?

Thanks!