Hi,
It happened to me too. I looked at the plugin code.
Function name changed to
postexpirator_schedule_event
-
This reply was modified 4 years, 11 months ago by
mtyaad.
@mtyaad @midwestdev thanks for reporting this. We’ll fix it in a follow-up release early next week.
@mtyaad @midwestdev We’ve had a discussion on our team about this.
We think this function name change was a positive move as we work to clean up the codebase.
We’re prepared to roll back this change if needed, but wanted to ask … are you able to update your code for the new function?
If you can’t, could you explain your use-case a little? Maybe we can support it and still clean up the codebase.
@stevejburge Function name changes are pretty common, so I understand, and luckily, I am able to change it in my case.
However, that being said, I didn’t do any dives into the code to find what the new function name was, there was no notes about it in your changelog, and as far as I can tell, there was no deprecation process to let developers know that it was changing, and what it was changing to.
Maybe adding a passthrough function with the old function name with a deprecation warning and adding something about it in your changelog would be a good first step and then drop it when you feel you’ve given enough warning? Just a suggestion.
thanks @midwestdev. 100% agree on the changelog. Sorry, we messed up on this one. We normally do a detailed log with “Added”, “Changed”, and “Fixed”.
We are leaning towards leaving this change in place, but adding legacy support in the next release.
@stevejburge No worries, I’m just glad you’re responsive! Dealt with a lot of un-responded support tickets in my day. Love the plugin and keep up the good work!
Thanks @midwestdev
We took over maintaining the plugin a couple of months ago, and are moving slowly, learning more about what existing users are doing with the plugin. This kind of feedback is super-helpful.
Sure, in case it’s more helpful, one of the uses I have that wasn’t working is adding a custom length of time per post created on a Gravity Forms submission. The blanket post expiration isn’t what was requested, so I had to resort to setting the expiration programmatically after the form is submitted and the post is created. Otherwise, I typically use it as an admin tool on most other sites, so that level of programming isn’t needed. Hope this information helps.
@midwestdev 150% it’s helpful. Thanks for sharing that with us.
