Fatal error: Cannot redeclare DNH function

@tokyoprogressive Thanks.

@tezalsec Correct. Hopefully not many other plugins use an outdated version, the check should have been in there from the beginning as it was intended to be used by multiple plugins/themes.

sorry to keep approaching you about this this way, hope you will pick it up.

OH really are you? Why you people keep ignoring the support site. What is so hard to register and post there?

It’s not my code you looked at but the code of the dev who wrote that library. But I guess this is what you meant.

Holy fuck I included that library because like 3 people had issue with admin messages and I thought I included some code from someone else because WP in 2021 stick lacks a basic API for something as basic as admin messages.

And turns out that lib fucking sucks.

The DNH function should be either in a class or have a unique function name, like “ARVE_DNH”. The check for double occurrence of functions happens by php itself before processing logic, so an if then statement at the start of the include file does not sufficiently solve this.

I think you are on the right track but you not really got it. Its just that the library needs to wrap ALL functions with

if ( function_exists( 'EVERY_FUNCTION_IN_THAT_FILE' ) ) {

There should be no need at all to rename anything. I do not know what you are talking about runtime … I know for a fact that wrapping functions with if ( function_exists works and I it and have seen lot of uses of this.

I still a bit confused about why exactly, but I fixed it, tried this file with the wps-hide-login. After confirming the issue I applied this.

https://github.com/julien731/WP-Dismissible-Notices-Handler/pull/14/files

So not sure what you go on about renaming and putting it into a class, but THIS is how you do it.

https://github.com/julien731/WP-Dismissible-Notices-Handler/blob/6907cc917b4c580515b8bd798d5294ccff5f37c4/includes/helper-functions.php

The problem with this is every other plugin dev needs to update this flawed code. And the wps-hide-login dev actually uses a forked version of the library from another dev …

What a mess just by using one tiny lib … I will completely rename everything in that lib I guess …

both still at fault

Well, not really. I guess for using a “library” assuming it can actually be used as one but if you want to blame someone blame the person who wrote it. Mistakes happen, but it’s strange that this it not even fixed in the latest versions of this lib (even in different forks)

• This reply was modified 5 years, 3 months ago by Nico.

You need to also apply it to ARVE in libs I tested it and it for sure works!

Will fix this soon with a renamed version of that class without the helpers altogether.