Conflict with WP_DEBUG

  • Resolved daviorocha

    (@daviorocha)


    11 years, 4 months ago

    Hi, I am using your plugin, which is awesome. But I am developing a theme for a client and I was fighting here to debug my template with flag WP_DEBUG = true inside wp-config.php. Then I did a backtrack what was going on and found that your plugin was the problem. Inside the index.php on line 47 you have checks for debug mode, but you are not checking for WP_DEBUG, so what happens? everything is turned off and the debug mode for wordpress does not work. To correct, just check for WP_DEBUG flag if is true, leave settings as they are, or do another solution, after all you are the developer of the plugin and you know better than I… 🙂

    Thanks,
    –Davi

    https://wordpress.org/plugins/wp-ultimate-csv-importer/

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author Smackcoders Inc.,

    (@smackcoders)

    11 years, 4 months ago

    @daviorocha, thanks for the update on this. We will check this and do all necessary update in future version

    Thread Starter daviorocha

    (@daviorocha)

    11 years, 4 months ago

    This is what I did, it’s working fine, but you may find a better solution.

    File: wp-ultimate-csv-importer/index.php on line 47

    $get_debug_mode = get_option('wpcsvfreesettings');
if(isset($get_debug_mode['debug_mode']) && $get_debug_mode['debug_mode'] != 'enable_debug' && !WP_DEBUG) {
        error_reporting(0);
        ini_set('display_errors', 'Off');
}

    Thanks

    Plugin Author Smackcoders Inc.,

    (@smackcoders)

    11 years, 4 months ago

    Sure, the work has been scheduled. Will be updated soon. Thanks for your kindness.

    jorgeorpinel

    (@jorgeorpinel)

    11 years, 2 months ago

    I found that your plugin (also) interferes in the opposite way. index.php:49-50 has

    error_reporting(0);
ini_set('display_errors', 'Off');

    which turns off my php errors >:(

    jorgeorpinel

    (@jorgeorpinel)

    11 years, 2 months ago

    Those functions shouldn’t be used lightly in plugin releases, it messes up everyone’s debugging. Unfortunately you’re not the only plugin doing it…

    So for others who read this consider disabling the ini_set and error_reporting functions completely, at least on production.

    Plugin Author Smackcoders Inc.,

    (@smackcoders)

    11 years, 2 months ago

    There is an option available under additional feature in Settings menu of our plugin.You can choose to enable the debug mode & save it.

    jorgeorpinel

    (@jorgeorpinel)

    11 years, 2 months ago

    OK but by default the plugin disables debug output when activated. What if I bulk activate it on 100 sites? I’m not going to manually re-enable debug mode in the plugin page > settings > additional features a hundred times.

    I think the point of WordPress having WP_DEBUG on is so that debug output is shown, the plugin is interfering with that expected behavior. I suggest you change that.

Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘Conflict with WP_DEBUG’ is closed to new replies.