wpweaver
Forum Replies Created
-
Forum: Plugins
In reply to: [Weaver II Theme Extras] Birchpress booking formWe do not support this theme or plugin here.
Please see http://forum.weavertheme.com
For more help, see the forum, but your slider works fine on Chrome on my Mac.
Forum: Plugins
In reply to: [Weaver Show Posts] v1.3.1 breaks embedded videoMy bad – must have incorrectly typed the search string because I only found the first one.
Forum: Plugins
In reply to: [Theme Check] WP_DEBUG warningsVery cool.
I’m working on a last pre-Customizer requirement of the theme right now.
I think this new feature will be a big help.
I do think, however, that this issue does bring up an inconsistency in the theme requirements: https://make.wordpress.org/themes/handbook/review/required/
One requirement in the Language section is:
Use a single unique theme slug – as the theme slug appears in style.css. If it uses a framework then no more than 2 unique slugs.
This is about the language slug, and says a 2nd slug for a framework is allowed – but the new INFO message from Theme Check indicates that a 2nd slug can break compatibility with the language pack. This seems like an inconsistency. I think this brings up something that needs attention from the theme review team.
Forum: Plugins
In reply to: [Weaver Show Posts] Style of Displayed Postsissue solved on the forum.
Forum: Plugins
In reply to: [Weaver Show Posts] v1.3.1 breaks embedded videoThank you!
As you suspected, I simply added the code from the previous pull request. That did fix the issue with the light box, but your solution seems to still fix that, too.
I will post updated versions of Show Posts and Show Sliders soon with your fix to the fix.
Let me know if that fixes your issues.
If you have other issues or suggestions for these plugins, do let me know and I will consider incorporating them into these plugins.
Forum: Plugins
In reply to: [Theme Check] WP_DEBUG warningsThanks, Otto.
Unfortunately, a simple search/replace for ‘tgmpa’ to ‘theme-slug’ will not work as the library uses ‘tgmpa’ for other purposes as well.
I think I’ll pass along your recommendation to TGMPA about the translation issue, perhaps they can provide a workaround. Perhaps a defined CONSTANT that could be unique, and more easily replaced. But no matter what, needing to manually update this string for each new version will be a hassle.
What do other theme libraries do about translation strings? Certainly this must come up with other theme support frameworks or libraries?
And, the fact that you were able to detect different translation variants would be a great diagnostic addition to Theme Check.
All the weaver variants you found were really leftovers from the required addition of admin side translations a while back – didn’t get them all done right.
And you might even add a special message for ‘tgmpa’ if that is what you guys really consider important.
Forum: Plugins
In reply to: [Theme Check] WP_DEBUG warningsThanks for your response.
I knew about the missing text domains in the tgmpa code on the _n_noop calls – this is being discussed on the tgmpa site, and is a result of them being missing in earlier versions of their sample code and the recent improvement in Theme Check with translation strings and calls.
And it would be good to get a clarification on the ‘tgmpa’ text domain issue. That string is in the tgmpa library code directly, and I think they switched to that over a variable used in earlier versions to get around Theme Check, and that you would find that ‘tgmpa’ remains in a lot of themes that use tgmpa (and a lot do). So, what would be your recommended practice on this? Replace the ‘tgmpa’ text domain with the theme/plugin text domain in the library, leave it as ‘tgmpa’ and register it as an additional text domain, or something else. I think a lot of people would be happy to get this issue settled once and for all.
I know you aren’t fond of tgmpa, and in many ways I agree suggested plugins could be presented much more compactly. But it does offer some very nice features, and handles all the messages and plugin loading code without much thought by theme developers.
For me, the hardest thing with tgmpa over time has, in fact, been dealing with the text domain name for it, and how Theme Check handles that.
Forum: Plugins
In reply to: [Theme Check] WP_DEBUG warningsThanks, Otto.
With a thousand translation calls (Weaver Xtreme), it does seem likely that there could be an extra argument.
Forum: Plugins
In reply to: [Weaver Show Posts] v1.3.1 breaks embedded videoThis is getting pretty complicated for a forum-type discussion.
This whole issue is related to this discussion on my forum:
http://forum.weavertheme.com/discussion/comment/59800#Comment_59800
It might give some insight.
It is indeed likely that the direct call to atw_slider_sc is the issue as the fixes added as a result of the referenced discussion would involve order of execution, and more important, end-of-the-loop adjustments due to calls the do_shortcode. Could also have something to do with the echo as that would tend to bypass nested filtering on the shortcode.
There is little overhead in shortcode processing, so perhaps you could simply replace your direct call with a do_shortcode().
Forum: Plugins
In reply to: [Weaver Show Posts] v1.3.1 breaks embedded videoFollow up:
I cannot duplicate this issue.
I have a URL-only video as the only content of a post.
That post in a slider by defining a slider that uses a post filter that includes the video url only post. It displays fine. It works fine with Twenty Eleven using both native support and Show Posts display support.
Do be sure you have Show Sliders 1.3.1 and Show Posts 1.3.1.1.
What theme are you using?
Forum: Plugins
In reply to: [Weaver Show Posts] v1.3.1 breaks embedded video1.3.1.1 was needed due to an update mistake for 1.3.1 – failed to update the latest version field.
The the_content filters were changed, and what you described was not supposed to be a side-effect. There did seem to be an issue with the_content filters, however, when some plugins added filters at lower priorities.
The low priority filter issue affected only one plugin as far as I know, while the existing show posts code has worked for years with no other reported issues.
Let me look into this, and I may have to add an option to add the new the_content low priority filtering as an option.
The whole thing with the_content filtering is quite a mess – one that I literally would use as a case example of how not to do something if I were writing a book. It is clear that logically the_content() should be recursive, but it isn’t, and in some cases, things get “broken” – low priority filters.
I will see if I can reproduce the plain just a YouTube URL issue, and if I can, then I will try to find a workaround for this mess.
Forum: Plugins
In reply to: [Weaver Show Posts] Conflict in display Sidebars on right vs. leftPlease post this question on http://forum.weavertheme.com.
This is related to Weaver II Pro most likely, and we do not support that theme on the WP.org forum.
The issue is almost certainly related to the content in you sidebars, and not Show Posts. But we will need more details about how your are using [show_posts]. It is almost certainly the content of one of the posts displayed by the shortcode – a missing </div> is the usual case.
Forum: Plugins
In reply to: [Weaver Show Sliders] Slider in Header cannot link to HomepageFor the mutual benefit of the Weaver community, it is our policy to not answer general support questions about Weaver on the WordPress Forum. Please use the Weaver Forum at http://forum.weavertheme.com – anyone can join. If you can’t find the answer already there (try using the “Search Support Forum First!” box in the upper right), then ask your question in the appropriate discussion group.
The “Start a New Discussion” button is on the right side, just below the pink and yellow box. This allows the entire community to benefit from the answer.
Weaver Theme
Forum: Themes and Templates
In reply to: [Weaver Xtreme] Fonts?There has been nothing lost or changed in Weaver II. There is no forcing a switch to Weaver Xtreme – other than Weaver Xtreme is simply a better, more modern theme.