walkinverse

@rynald0s The issue is with the foreach as you are not checking the next. As soon as you see an item on sale you are exiting the code (BREAK). That is a bug in the logic. What needs to happen is to check all the items in the cart before breaking out because you never get to the second item if the first hit in the loop is flagged as a sale item. Hence, this is a bug.

/**
	 * Ensure coupon is valid for sale items in the list is valid or throw exception.
	 *
	 * @since  3.2.0
	 * @throws Exception Error message.
	 * @param  WC_Coupon $coupon Coupon data.
	 * @return bool
	 */
	protected function validate_coupon_sale_items( $coupon ) {
		if ( $coupon->get_exclude_sale_items() && 'fixed_product' !== $coupon->get_discount_type() ) {
			$valid = true;

			foreach ( $this->get_items_to_validate() as $item ) {
				<strong>if ( $item->product && $item->product->is_on_sale() )</strong> {
					$valid = false;
					break;
				}
			}

			if ( ! $valid ) {
				throw new Exception( __( 'Sorry, this coupon is not valid for sale items.', 'woocommerce' ), 110 );
			}
		}

		return true;
	}

• This reply was modified 7 years, 8 months ago by walkinverse.

@rynald0s I am curious, how is it suppose to work? If a customer wants to buy two items. One item is on sale, and one item is not, and they add both to the cart shouldn’t the one that is not on sale take the discount when you set the coupon to only be able to be used on items that are not on sale?

Shouldn’t the nonsale item get the 20% discount? Currently, if any item that is on sale in the cart with a non-sale item, the coupon is automatically removed and cannot be used.

How can I test this fix? Will an update be available as 3.4.6?

Thank you for your response.

• This reply was modified 7 years, 8 months ago by walkinverse.

I had to use wp rollback to roll back to the previous version of 3.3.1 unfortunately.