walkinverse

@ryanhungate any update for the update to the plugin? I’ve been holding off doing newsletters, but I need to send something. Thanks!

Where do I run this from?

Once I ran this below – everything synced up perfectly:

delete_site_transient( ‘http_worker_lock’ );

@claudiulodro IN case I am not making sense, the issue with the coupon is that you can add a non-sale item and a sale item. You have a coupon set to percentage and to ignore on sale items and only allow it to be used with 1 item in the cart. In 3.4.4 no issue, everything works are expected. 3.4.5 it does not. Currently (3.4.5) if you try to apply the coupon it kicks out and will not work on the non-sale item. If you remove the sale item and try again the coupon works. You add the sale item back to the cart with the non- sale item it throws an error saying coupon cannot be used, which is incorrect. Please see the video. 3.4.4 is normal behavior, 3.4.5 is not.

https://www.dropbox.com/s/vikywyz8945z804/Recording%20%2332.mp4?dl=0

In the foreach loop it does not consider all the items in the cart. It kicks out as soon as it sees an item flagged as on sale. It should first make sure that one of the items are valid for coupon use.

Function: protected function validate_coupon_sale_items( $coupon )

Look at the foreach loop in this code and you will see the logic that is causing it. If you first got the count then had a tracking count that each time you hit a sale item increment by 1. Then at the end of the foreach if those numbers do not match then that means one item was valid for coupon use. If both numbers matched the that implies all items are on sale items.

Example:

$total_items = count(items);
$onsale_item = 0;

foreach(items as $item)
  if($item->onsale)
      $onsale_item++;

if($onsale_item != $total_items)
  coupon can be used
else
  all items in the cart are on sale.

I hope this helps. Thank you again.

• This reply was modified 7 years, 8 months ago by walkinverse.

@rynald0s Thank you so much. This might help with the fix. Have not tested thoroughly, but run it a few time on the test site.

$total_items = count($this->get_items_to_validate());
$item_count = 1;
foreach ( $this->get_items_to_validate() as $item ) {
	if ( $item->product && $item->product->is_on_sale() ) {
		if($item_count > $total_items) {
			$valid = false;
			break;
		}
	}
	$item_count++;
}

• This reply was modified 7 years, 8 months ago by walkinverse.
• This reply was modified 7 years, 8 months ago by walkinverse.