Toby Cryns (@themightymo)
Forum Replies Created
-
Forum: Plugins
In reply to: [Simple Pull Quote] Security Vulnerability@rodeboy, Thanks again for letting me know about this security vulnerability. It is fixed now with version 1.6.4.
Forum: Plugins
In reply to: [Simple Pull Quote] Security VulnerabilityHi @rodeboy, Thanks for letting me know (saw the message in the wp.org Slack today). Yes, I’ll implement a fix.
Yeah it’s been a while since the last big update! I’m happy to fix that bug (with your help – thanks again!). Let me know if you have ideas for improvement.
Toby
Version 1.6.3 should fix the bug you experienced. Let me know how it goes!
@rodeboy @pharmabiz, Thanks for letting me know. I removed the call to that folder, but aparently that was not enough. I’ll implement your solution.
Forum: Plugins
In reply to: [This Day In History Widget] Patch for PHP 8+Great! Thanks @scheeeli!
-Toby
Forum: Plugins
In reply to: [This Day In History Widget] Patch for PHP 8+Hi @scheeeli. Yes, I’d love to contribute directly to the plugin here on wp.org (I think you can add me as a co-owner via the “Contributors” meta in the plugin file). I don’t foresee adding any features – I’ve been using it for years on my personal blog – but I’d definitely keep it up to date in terms of PHP and WP standards. I remember presenting at Minnebar years ago, and I told the audience it was my favorite plugin (probably still is!).
@atousanajafi, Yes I believe that’s it. The WAVE tool is flagging both “Multiple Form Labels” and “Missing Form Labels” for the date picker area in the following markup:
<label
class="tribe-events-c-top-bar__datepicker-label tribe-common-a11y-visual-hide"
for="tribe-events-top-bar-date"
>
Select date. </label>
<input
type="text"
class="tribe-events-c-top-bar__datepicker-input tribe-common-a11y-visual-hide"
data-js="tribe-events-top-bar-date"
id="tribe-events-top-bar-date"
name="tribe-events-views[tribe-bar-date]"
value="8/1/2024"
tabindex="-1"
autocomplete="off"
readonly="readonly"
/>Thanks, Victor!
Thanks for your reply, @fesupportteam. The issue is as follows:
In order to achieve more accessibility compliance, the search.php file noted on https://filtereverything.pro/resources/templates-overriding/ needs an html “label” tag attached to the search field. For example:
<input type="text" class="wpc-search-field" id="filter-search-field" placeholder="<?php echo $placeholder; ?>" value="<?php echo $search; ?>" name="srch">
<label for="filter-search-field" class="screen-only">Email</label>I understand that I can override via the method you mentioned, but imho this minimal accessibility compliance should be added to the core of the plugin.
Thanks again for your help,
Toby
When do you expect this fix to be merged into an official release?
That’s very helpful. Thanks @wfphil.
- This reply was modified 2 years, 1 month ago by Toby Cryns (@themightymo).
@jorritschippers, @newvibe, @rodeboy – Thank you for sharing this issue + solution. I’ll test it out thoroughly next week and push with an update at that time if all checks out.
Thanks, @dimitrycleantalk – That’s very helpful. I added the exclusion to the javascript files. Rather than turn off preloading cache in WP Rocket, I disabled the cache on a couple of my specific form pages (which I forgot I could do).
Thanks again!@katereji, Thanks for your reply. The issue is caused by how Cleantalk interacts with the WP Rocket plugin. Do you have any specific guidelines for that plugin or, more generally, recommendations for how to make caching plugins play nice with Cleantalk?
- This reply was modified 2 years, 11 months ago by Toby Cryns (@themightymo).
- This reply was modified 2 years, 11 months ago by Toby Cryns (@themightymo).