tbenyon

Hey @raider1967,

Could you open up the dev tools in your browser and got to the network tab.

I’d be interested to know about the request that appears in there when you hit the test button.

What are the headers and what comes back in the response?

Make sure to hide anything that may give people information you might not want shared (possibly such as your live domain name).

Thanks,

Tom 🙂

Hi @matrixmedia,

Apologies for the delayed response.

The plugin just hooks into the authentication hook so using another plugin to generate a different form should make no difference.

Is my plugin definitely working without the other two installed?

Is it when you install both of those other plugins that it stops working or does one being installed break it?

Thanks,

Tom

Hey @cramaekers,

Apologies for the delay in getting back to you.

I don’t believe the plugin will currently work with Azure SQL Server.

To be upfront, this is not something I’m realistically going to be able to tackle in the near future due to my wife’s desire for a kitchen and having to take on more private work than I’d like : P

My goal is to get some good testing in the plugin and swap out the custom database type queries to use a PDO but this won’t happen any time soon.

However, if you’re interested in tackling adding Azure support yourself the good news is the key concepts have been previously created.

I had a pull request previously and you can see how I tweaked their code to add MSSQL support on July 13th 2019 here:
https://github.com/tbenyon/wordpress_external_login_plugin/commits/master
– ae31634a7f94e60bb1dcc5c84fadac13392bf636
– 4e4ec5e33dd76c09d7e9e5b0b1a937e2f2672675
– 71f39db4202e95dd4c20dad496bfff308aa0ad41

Without knowing your understanding of PHP I am unsure if this is something you’re comfortable to tackle. However, if you wanted to make a pull request and add this feature I’d be happy to look at integrating it into the plugin 🙂

Let me know your thoughts.

Thanks,

Tom 🙂

Really glad it’s all working for you John and thanks for taking the time to write a review 🙂

Hey @johnfields,

Great find!

This is a relatively new feature so it is certainly possible this is not working. It has only been tested by me and I have not had anyone reported it working yet.

Could you give me an example of what worked and what didn’t work so that I can try to replicate?

Thanks,

Tom

Doesn’t appear to be. Could you send me screenshots of your settings? I really need to write a feature to make a nice output to make this easier. Apologies to have to ask this way 😛

Hey John,

1. I have another user in my DB and if the password is encrypted with bcrypt and i introduce the plain text password in the form it won’t recognize it.

Understood. Why this is happening is something we’ll need to determine. If you could create a new user in your external database with the password password so and send me the created hash that’d be awesome.

2. If the password for that user is in plain text it will recognize and will do the login correctly.

Some clarification needed here. Some of your users have passwords stored as a bcrypt hash and some of them have passwords stored in plain text?

3. If i activate the hash option for bcrypt it won’t recognize either my admin user or another one i have (both for password encrypted or in plain text)

Understood.

As per my comment to your point one. Let’s start with you sending me an example bcrypt hash generated with your code and I can see if I can replicate this my end. I’ll assume you’re using the latest version of the plugin (1.7.3).

Hey @johnfields,

Great question!

You’ll want to use the default WordPress way of doing this.

I’ve tried to write the plugin to stick to the standard WordPress flow as much as possible. For this reason, using someone else’s plugin to customise the look or writing your own modification in the standard WordPress way, as you plan to do, should work just fine. 🙂

For now I’ll close the ticket. If you have any issues feel free to get back to me.

If you get a chance to write a review I’d be very grateful.

Thanks John,

Tom 🙂