sipium
Forum Replies Created
-
Forum: Plugins
In reply to: [The Events Calendar] Error on WP Cron run deleting task logsI hope you’ll understand, I am reluctant to add the code snippet you suggested. This is because I think it is a good idea to continue deleting obsolete task and task-log records, but your code snippet looks like it would stop that cleanup process.
Your suggestion led me to look closely at the code referenced. I can see that the Herding class decides which table holds the task log records on the basis of the configured Logger class. If the Logger is ActionScheduler_DB_Logger, then it will go looking for obsolete log records to delete from the actionscheduler_logs table. Only if the configured Logger is DB_Logger will it try to delete records from the
shepherd_tec_task_logstable. In short, attempts to delete from theshepherd_tec_task_logstable are conditional. I expect the creation of that table will also be conditional. Therefore, I think it would be wise if the code I disabled (using a very simple “if (false) …” condition) was made more intelligently conditional like the code in the Herding class. I might try this myself.Am I right in guessing that the StellarWP Shepherd code is bundled 3rd-party code that you have no influence over? Which would mean that you are relying on StellarWP to fix bugs in their own code on which TEC depends?
Happy to discuss further in more technical detail if necessary.
Forum: Plugins
In reply to: [The Events Calendar] Error on WP Cron run deleting task logsBecause the table doesn’t exist and that causes an exception to be thrown, the next very important line doesn’t get run to clean out the
<wpdbprefix>_shepherd_tec_taskstable. In TEC 6.15.11 the crucial line is #144 in <common/vendor/vendor-prefixed/stellarwp/shepherd/src/Provider.php>. I prefixed this line with “if (false) ” as a *very* temporary fix. I know it will be overwritten by the next TEC update. But in the meantime, it is a better workaround than rolling back to an older version.