ralbatross

Aha! I re-installed WordPress and that fixed it. I must have been hacking at core files while troubleshooting something.

Something like this inside of a function seems to do the trick:

global $as3cf;

if ( $as3cf ) { // Make sure WP Offload S3 is there

    $url = $as3cf->get_s3client($as3cf->get_setting('region'))
                 ->get_object_url( 
                        $as3cf->get_setting('bucket'), 
                        <object key>, 
                        time()+900 
                    );
}

This grabs a pre-signed url for <object key>, independent of any attachment ids in WordPress

• This reply was modified 7 years, 8 months ago by ralbatross.
• This reply was modified 7 years, 8 months ago by ralbatross.

The link in my previous message goes to the bug report, but I’ll link it again here 🙂

https://core.trac.wordpress.org/ticket/34976

After more research I have found the following:

In wp-admin/includes/class-wp-uploader.php, lines 531-535:

//Create destination if needed
if ( ! $wp_filesystem->exists( $remote_destination ) ) {
	if ( ! $wp_filesystem->mkdir( $remote_destination, FS_CHMOD_DIR ) ) {
		return new WP_Error( 'mkdir_failed_destination', $this->strings['mkdir_failed'], $remote_destination );
	}
}

The exists call is returning false when I try to update a plugin. This is wrong. I am able to see the directory referred to by $remote_destination in my OS shell, and it obviously does exist because the failure occurs on the mkdir call—it is unable to make the directory because it already exists.

Digging deeper, in wp-admin/includes/class-wp-filesystem-ftpext.php, lines 329-338:

public function exists( $file ) {
	$path = dirname( $file );
	$filename = basename( $file );

	$file_list = @ftp_nlist( $this->link, '-a ' . $path );
	if ( $file_list ) {
		$file_list = array_map( 'basename', $file_list );
	}
	return $file_list && in_array( $filename, $file_list );
}

If I add the following line just before the return statement…

error_log(debug_backtrace()[1]['function'] . ": \npath: $path\nfilename: $filename\nfile list:\n" . print_r($file_list, true) . "\n");

… I see this output…

[11-Dec-2015 18:42:19 UTC] install_package:
path: <the expected path>
filename: <the expected filename>
file list:
Array
(
)

The file list is empty! It should not be. What’s going on here?