Marcus

Hello. Thanks i update plugin to latest version and issues is resolved now)

There are also many other errors and memory leaks. The main problem is that when cleaning thumbnails, it does not clean everything and many original (sizes) thumbnails remain in the library.

SOLUTION:

Add to generate_webp in after

foreach ( (array) $metadata['sizes'] as $key => $value ) {code} 

$this->delete_old_thumbnails( $path, $metadata['file'], $metadata['sizes'], $pluswebp_settings['types'] );

private function delete_old_thumbnails( $path, $original_file, $sizes, $types ) {
   $base_name = pathinfo( $original_file, PATHINFO_FILENAME );
   $dir = opendir( $path );
   if ( $dir ) {
       while ( ( $file = readdir( $dir ) ) !== false ) {
           $file_info = pathinfo( $file );
           if ( $file_info['basename'] !== $original_file &&
                in_array( $file_info['extension'], $types ) &&
                strpos( $file_info['filename'], $base_name ) !== false ) {
               wp_delete_file( $path . $file_info['basename'] );
           }
       }
       closedir( $dir );
     }
   }

Maybe u help that in next update )

“Maybe you can try replacing the images that generate the error manually and see if the plugin starts working correctly again.” – you must make “if” for solution skip TrueColors file:

My solution in another plugin i used:

private function create_webp(string $filename, string $mime_type, string $filename_webp): bool {
    if (!file_exists($filename) || file_exists($filename_webp)) {
        return false;
    }

    $pluswebp_settings = get_option('pluswebp');
    @set_time_limit(60);
    wp_raise_memory_limit('pluswebp');

    $src = null;
    $img = null;
    $ret = false;

    try {
        switch ($mime_type) {
            case 'image/jpeg':
                $src = imagecreatefromjpeg($filename);
                break;
            case 'image/png':
                $src = imagecreatefrompng($filename);
                break;
            case 'image/bmp':
                if (function_exists('imagecreatefrombmp')) {
                    $src = imagecreatefrombmp($filename);
                }
                break;
            case 'image/gif':
                $src = imagecreatefromgif($filename);
                break;
            default:
                return false; // Unsupported MIME type
        }

        if (!$src) {
            return false; // Failed to create source image
        }

        $img = imagecreatetruecolor(imagesx($src), imagesy($src));
        if (!$img) {
            imagedestroy($src);
            return false; // Failed to create destination image
        }

        switch ($mime_type) {
            case 'image/jpeg':
                $bgcolor = imagecolorallocate($img, 255, 255, 255);
                imagefill($img, 0, 0, $bgcolor);
                imagealphablending($img, true);
                break;
            case 'image/png':
                imagealphablending($img, false);
                imagesavealpha($img, true);
                break;
            case 'image/gif':
                $bgcolor = imagecolorallocatealpha($img, 0, 0, 0, 127);
                imagefill($img, 0, 0, $bgcolor);
                imagecolortransparent($img, $bgcolor);
                break;
        }

        imagecopy($img, $src, 0, 0, 0, 0, imagesx($src), imagesy($src));
        $ret = imagewebp($img, $filename_webp, $pluswebp_settings['quality']);
    } catch (Exception $e) {
        // Handle exception if needed
    } finally {
        if ($src) {
            imagedestroy($src);
        }
        if ($img) {
            imagedestroy($img);
        }
    }

    return $ret;
}

And maybe you help that

Colleague, in my opinion, I believe that for such operations, everything needs to be at hand, and making this plugin all in one click would be great. Additionally, simply adding these options from your other plugin as a paid option would be perfect. That would be awesome. You could also add support for AVIF and name it “Plus WebP and AVIF.”

Hard work for class-pluswebp.php

• Enhanced Stability and Code Structure:
  Started improvements in the main plugin file and CLI classes to enhance stability. Worked on organizing the code for better readability and modularity.

Main Plugin File:

The provided code ensures correct dependency loading. The approach using a function to check and include classes optimally manages dependencies. Next CLI Name: Plus WebP CLI Improvements:

• Readability and Modularity:
  Extracted file missing messages into generate_missing_file_message function for better readability in pluswebp_cli_command.
• Optimized Message Handling:
  Updated messages once after the main loop to minimize database calls.
• Documentation and Comments:
  Added comments for improved code understanding and documentation for new functions.

Further Improvements for class PlusWebp:

1. function generate_webp:

• Modern array syntax used for clarity and optimized image handling to avoid potential memory leaks with large files.
• Helper Functions: Extracted reusable logic into separate helper functions.
• Readability: Improved readability by breaking down long functions into smaller, focused functions.
• Maintainability: Easier to maintain and update specific parts of the code without affecting others.
• Error Handling: More structured approach allows easier integration of error handling.

1. function thumbnail_urls:

• Optimized checks to prevent memory leaks and considered scenarios where image attribute values are in $image_attr_thumbnail.

1. function output_datas:

• Updated to PHP 8 syntax, replacing array() with [], optimized checks, and memory leak prevention for modern project compatibility.
• Helper Functions: Extracted logic into separate helper functions get_original_image_info and get_file_size.
• Readability: Improved readability by breaking down the function into smaller, focused parts.
• Error Handling: More structured error handling for file size retrieval.
• Descriptive Variable Names: Used more descriptive variable names for clarity.

1. function mail_messages:

• Enhanced stability and modern PHP practices. Utilizes $message variable for message storage and returns an array with the latest message and an array of all messages for further processing.
• Initialization of Variables: Initialized $messages to an empty array to ensure it’s always available.
• Improved Readability: Used sprintf to construct the message in a more readable and maintainable way.
• Consistent Message Formatting: Ensured consistent formatting by using sprintf for all parts of the message.
• Edge Case Handling: Added checks to handle potential empty values, ensuring the function behaves correctly even if some metadata is missing.

1. function create_webp:

• Changes:
  • Parameter and return types updated to string for $filename, $mime_type, $filename_webp, and bool for return value.
  • Memory leak prevention with imagedestroy() after GD image processing.
  • Memory management using wp_raise_memory_limit() for increased memory limit if needed.
  • Replaced array() with [] for improved readability and PHP 8 compatibility.
  • Returns false for unsupported MIME types or unsuccessful image creation attempts.
  • Error Handling: Using try-catch-finally ensures that resources are properly managed and potential errors are caught.
  • Resource Management: Added checks and ensured that both $src and $img are always destroyed properly to prevent memory leaks.
  • Simplified Control Flow: Reduced duplication by moving common operations outside of the switch statement.
  • PHP 8.3 Compatibility: Ensured compatibility with PHP 8.3 by handling exceptions and potential errors more robustly.

1. function change_ext:

• Changes:
  • Parameter types updated to strict PHP types (string for $before_file_name, $ext, bool for $addext) for clarity and type safety.
  • Utilizes pathinfo() for retrieving file extensions instead of explode() and end(), ensuring reliable extension retrieval.
  • Error Handling: The method now uses a try-catch block to handle potential exceptions that might arise, particularly when retrieving the file extension.
  • Logging: The method logs both successful extension changes and errors. This is useful for debugging and monitoring the application.
  • Return Original Filename on Error: If an error occurs, the method returns the original filename instead of potentially corrupting the filename.
  • Usage of error_log: error_log is a simple and effective way to log messages to the server’s error log. It helps in tracking what went wrong if something doesn’t work as expected.

1. function change_db:

• Updates:
  • Parameter types: $before_url and $after_url declared as string for PHP 8 standards, enhancing type safety and clarity.
  • Uses $wpdb->update() for safe database updates instead of direct SQL queries via $wpdb->query(). Includes data sanitization via prepare() for secure WordPress table operations.
  • Added WHERE clause to restrict updates to posts containing $before_url, improving query efficiency.
  • Key Improvements:
  • Error Handling: The method now uses a try-catch block to handle potential exceptions that might arise during the database query.
  • Validation: Checks to ensure that the URLs are not empty before proceeding with the query.
  • Logging: Logs both successful operations and errors, providing more insights into the function’s execution.
  • Descriptive Exception Messages: Provides detailed error messages to help diagnose the specific issue.
  • Usage of error_log: error_log is used to log messages to the server’s error log, which helps track and diagnose issues.
  • Example Log Messages:
    • Success: “Successfully replaced URLs in the database: {before_url} to {after_url}”
    • Error: “Error changing database content: {error message}”

1. function upload_dir_url_path:

• Changes:
  • Uses [] instead of array() for returning arrays, adhering to modern PHP syntax.
  • Utilizes wp_normalize_path() for path normalization.
  • Memory leak prevention with realpath() for obtaining the real path.
  • Checks HTTPS connection with is_ssl() for protocol correctness.
  • Conditional upload_path determination based on relative path availability.

1. function realurl:

• Enhancements:
  • Replaces array() with [] for declaring arrays.
  • Uses string type hinting for function parameters for improved clarity.
  • Utilizes wp_parse_url for parsing base URLs.
  • Uses double quotes for better readability when concatenating strings with variables.
  • Simplified Logic: The function logic is simplified to handle base URLs with relative paths more effectively, using realpath() and wp_normalize_path() to ensure paths are correctly resolved.
  • SSL Handling: set_url_scheme() is used to ensure URLs are HTTPS if the site is accessed over SSL, replacing manual string manipulation.
  • Path Calculation: upload_path is calculated relative to site_url() for consistency and proper URL handling in WordPress.
  • Usage of wp_parse_url and set_url_scheme:
  • wp_parse_url: Used to parse and manipulate URLs in a WordPress-safe manner.
  • set_url_scheme: Ensures URLs are properly prefixed with https:// if the site is accessed over SSL, handling security considerations automatically.
  • Overall:
  • This version of upload_dir_url_path ensures better compatibility with PHP 8.3, improves clarity and efficiency in handling paths and URLs, and adheres to best practices in WordPress development.

1. function raise_memory_limit:
   • Improvements:
   • Added type hinting for parameter $filtered_limit to ensure it’s a string.
   • Directly returns '256M' for clarity and consistency.
2. function control_mime_type:
   • Improvements:
   • Added type hinting for parameters $image_mime_transforms (array) and $attachment_id (int) for PHP 8 compatibility.
   • Returns an empty array [], ensuring clear function purpose and return type.

These enhancements aim to make the code more structured, maintainable, and compatible with modern PHP versions, particularly PHP 8.

This comprehensive report outlines the detailed improvements made across various functions and classes in your plugin, focusing on enhancing stability, readability, and compatibility with modern PHP standards.

I want to inform you that in this version, the correct logging approach has been implemented. Now, the logs will show the process of what it converts and what actions it performs.

New version: for test.. 4.09 https://www.sendspace.com/file/oxa040

PS. Maybe you have a Hook for delete all original files + thumbnails from uploads ?? I see more thumbnails files what not deleted after convertion.. How can i remove that from you plugin?