Marcus

In new update 9.2.2 – is not fixed( lol…

This is own fix i do for 2min

/**
 * Update script tag.
* The vue code needs type=module.
*/
public function script_loader_tag( $tag, $handle, $src ) {

    if ( ! in_array( $handle, $this->own_handles ) ) {
        return $tag;
    }

    // Check if the 'monsterinsights-vue-frontend' script is the target
    if ( 'monsterinsights-vue-frontend' === $handle ) {
    // Remove any existing type attribute
    $tag = str_replace( 'text/javascript', 'module', $tag );
    }

    // Change the script tag by adding type="module" and return it.
    $html = str_replace( '></script>', ' type="module"></script>', $tag );

    $domain = monsterinsights_is_pro_version() ? 'ga-premium' : 'ga-premium';
    $html   = monsterinsights_get_printable_translations( $domain ) . $html;

    return $html;
} 

Bug Report: Conflict in Script Tag Type Modification for Module Scripts

Description:

During independent testing, a bug was identified involving the function public function script_loader_tag( $tag, $handle, $src ) located in admin-assets.php. This function is intended to set specific scripts as modules by modifying the <script> tag. However, an issue was observed, where despite modifications from the filter, the <script> tag’s type remains as text/javascript instead of module.

Log results indicate that the filter correctly applies changes to the <script> tag. Nevertheless, the script type is not updated to module because an existing type="text/javascript" attribute is likely predefined, either within the plugin code or influenced by browser behavior. Consequently, for the file js/frontend.min.js, the script type remains incorrect, causing the module-based script not to load as intended.

Proposed Solution:

To address this issue temporarily, I suggest modifying the function in admin-assets.php under the path /wp-content/plugins/google-analytics-for-wordpress/includes/admin as follows:

/**
 * Update script tag.
 * The vue code needs type=module.
 */
public function script_loader_tag( $tag, $handle, $src ) {

    if ( ! in_array( $handle, $this->own_handles ) ) {
        return $tag;
    }

    // Check if the 'monsterinsights-vue-frontend' script is the target
    if ( 'monsterinsights-vue-frontend' === $handle ) {
        // Remove any existing type attribute
        $tag = preg_replace( '/\stype="[^"]+"/', '', $tag );
    }

    // Change the script tag by adding type="module" and return it.
    $tag = str_replace( '></script>', ' type="module"></script>', $tag );

    $domain = monsterinsights_is_pro_version() ? 'ga-premium' : 'ga-premium';
    $tag    = monsterinsights_get_printable_translations( $domain ) . $tag;

    return $tag;
}

This modification removes the type="text/javascript" attribute and correctly sets type="module". It temporarily resolves the console errors and ensures proper functionality of the plugin. We hope the development team can review and implement a permanent fix to detect and set the correct module type without conflict.

Impact:

This issue affects both the Pro and Lite versions of the plugin, preventing the script and its dependencies from executing correctly.

Results After the Fix:

1. Pro Version: <script src="DEMOSITE/wp-content/plugins/google-analytics-premium/pro/assets/vue/js/frontend.min.js?ver=9.2.1" id="monsterinsights-vue-frontend-js" type="module"></script>
2. Lite Version: <script src="DEMOSITE/wp-content/plugins/google-analytics-for-wordpress/lite/assets/vue/js/frontend.min.js?ver=9.2.1" id="monsterinsights-vue-frontend-js" type="module"></script>

The monsterinsights-vue-frontend script is set with the type text/javascript, likely due to the following reasons:

1. Lack of initial check for type in the script_loader_tag function: The MonsterInsights plugin might explicitly set text/javascript for all scripts if the type was not previously modified. The script_loader_tag function may trigger after the type has already been set.
2. Conflicts with wp_enqueue_script(): If the script is registered with the standard WordPress function wp_enqueue_script() or a similar method without the type="module" attribute, WordPress will automatically apply the text/javascript type.

the monsterinsights-vue-frontend script is registered in google-analytics-premium/includes/frontend/frontend.php using the wp_register_script() and wp_enqueue_script() functions:

wp_register_script( 'monsterinsights-vue-frontend', $frontend_js_url, array( 'wp-i18n' ),  monsterinsights_get_asset_version(), true );
 wp_enqueue_script( 'monsterinsights-vue-frontend' );

It’s important to note that the wp_register_script() and wp_enqueue_script() functions do not set the type attribute, so by default, WordPress adds type="text/javascript".

This second solution:

* Update script tag.
* The vue code needs type=module.
*/
public function script_loader_tag( $tag, $handle, $src ) {

    if ( ! in_array( $handle, $this->own_handles ) ) {
        return $tag;
    }

    // Check if the 'monsterinsights-vue-frontend' script is the target
    if ( 'monsterinsights-vue-frontend' === $handle ) {
    // Remove any existing type attribute
    $tag = str_replace( 'text/javascript', 'module', $tag );
    }

    // Change the script tag by adding type="module" and return it.
    $html = str_replace( '></script>', ' type="module"></script>', $tag );

    $domain = monsterinsights_is_pro_version() ? 'ga-premium' : 'ga-premium';
    $html   = monsterinsights_get_printable_translations( $domain ) . $html;

    return $html;
} 

I hope this helps the development team address this critical issue. Thank you!