Darren Ethier (nerrad)
Forum Replies Created
-
Hi,
The fix I posted should work for the issue with saving icons on the manage series page.
As for the other issue you posted. I need a bit more details as I’m unable to reproduce.
Where are you using the %series_icon_linked% token? In one of the series template fields on the series options page? If so I’m assuming within the field that customizes the output for the Series Table of Contents page.
Also, what view are you expecting this on the front end? If you could give me your url structure or even a link to the page that’d be very helpful in trying to narrow down this issue.
The fix for this has been posted here -> http://wordpress.org/support/topic/compatibility-with-organize-series?replies=4#post-3719249
I’m going to do more thorough testing on this and hopefully include the fix in the next release.
Forum: Plugins
In reply to: [Editorial Calendar] Compatibility with Organize Seriesthe other thing I noticed is AFTER your implementation of the
do_actionhooks. You runwp_update_post(). Are you aware thatwp_update_post()in turn triggerswp_insert_postwhich in turn has thedo_action('save_post')anddo_action('insert_post')hooks in it. So really, there’s no need for you to add your do_actions.Anyway, just thought of a possible solution, I’ll run an isset check for the $_POST key I’m looking for. If it’s not present then I’ll skip the Organize Series stuff – I still think Editorial Calendar doesn’t need those do_actions tho
Anyways me@michaelsheridan.com.au, can you try this in your install of Organize Series:
On (or around) line 439 of the file
orgSeries-taxonomy.phpyou’ll see the following line:
if ($post->post_type == 'revision' || ( isset($_GET['bulk_edit_series']) && $_GET['bulk_edit_series'] == 'bulk' ) ) {Change it to:
if ($post->post_type == 'revision' || ( isset($_GET['bulk_edit_series']) && $_GET['bulk_edit_series'] == 'bulk' ) || !isset($_POST['post_series']) ) {Try saving and editing posts that are part of a series via the regular post interface and make sure nothing is broken. Then you can try the post within editorial calendar and see if this fixes the problem you were having.
If it does, let me know and we’ll work this fix (or something similar) into the next release of Organize Series.
Forum: Plugins
In reply to: [Editorial Calendar] Compatibility with Organize SeriesI’m just pointing out the problem… I’m still trying to think of a solution, either on my end or your end. But at least wanted to record what I think is the cause of the problem so other minds can be thinking about a solution too 🙂
BTW, I love your editorial calendar plugin, I use it on other sites – of course I’ve never noticed the series problems before because typically I use the editorial calendar for just planning basic post ideas.
Forum: Plugins
In reply to: [Editorial Calendar] Compatibility with Organize SeriesI realize these are standard wp_hooks. However, you are using it in a different manner than WP uses. When you set the hooks up in that location all that is available to the caller is the $post_id and the $post object. With WP’s usage, the hook is called when there is also a $_POST array available from the add/edit post screen (which includes other things such as set categories, custom taxonomies, custom fields etc.)
There is no other information available for that post in Editorial Calendar’s usage. In most cases this would be fine because if the caller needed other info (such as the taxonomies attached to the post etc. then it would just use the relevant WP function to pull that info. However, in my case (and probably some other plugins cases, we are EXPECTING the $_POST array to have other info. Particularly in my case, because it is possible for users to remove a post from a series (we check to see if $_POST[‘post_series’] is empty and compare it with the current series attached to the post, if empty then we remove the post from series). BUT since you use the
do_action('save_series')hook in a context that doesn’t contain the extra $_POST array information ANY post running through Editorial Calendar’s saves is losing any series data.Forum: Plugins
In reply to: [Editorial Calendar] Compatibility with Organize SeriesI think I may have found the problem
on line 1258 to 1260 of edcal.php (version 2.5) is the following:
do_action('edit_post', $edcal_postid, $post); do_action('save_post', $edcal_postid, $post); do_action('wp_insert_post', $edcal_postid, $post);This means that any other plugins hooking into the edit_post, save_post or wp_insert_post actions are ONLY getting what is in the $post object that is provided by editorial calendar. If that post object doesn’t include any of the custom_field data or the custom taxonomies then these plugins will not be able to do anything (and potentially have the taxonomies reset). I’m not saying this is definitely the problem but highly possible and would point to a fix.
Forum: Plugins
In reply to: [Editorial Calendar] Compatibility with Organize SeriesZack, Organize Series hooks into the custom taxonomy system of WordPress. Does Editorial Calendar support WordPress custom taxonomies?
The Series part info is saved as a post custom field. So Organize Series is using all WordPress API for saving its information.
Organize Series hooks into the custom taxonomy system. So it is possible that Editorial Calendar doesn’t support WordPress custom taxonomies. This is something that would have to be fixed on their end.
thanks for posting your solution here Bruce!
If you are comfortable editing code you can apply the fix yourself in the interim instead of having to wait for the release:
Open
orgSeries-taxonomy.php, on line 643 you will see the following:
$series_icon = isset( $_POST['series-icon_loc'] ) ? $_POST['series_icon_loc'] : null;
change it to:
$series_icon = isset($_POST['series_icon_loc'] ) ? $_POST['series_icon_loc'] : null;
Please report back if this fixes the issue for you. If there are other issues still remaining let me know. Thanks!
maybe we just noticed it with 3.5… either way we’re working on fix.
Hi there,
This is a known issue that appeared with the release of 3.5. The fix will make it into the next release. At this point no ETA on that but we’re working to get it out soon.Marking this as resolved because we haven’t heard back any more information.
David as per the twitter conversation we had over the Christmas holidays regarding another issue you were having… I suspect that you are having something else on your site causing issues (i.e. another plugin conflicting, or theme).
Also, if you are using a caching plugin try flushing the cache.
If you’d like any further help troubleshooting this issue which is specific to your site, there are three options you have
1. Leave this post here and hopefully someone else will volunteer some time to help you resolve this.
2. Try and troubleshoot yourself (search for a plugin or theme conflict or try what I mentioned above).
3. Purchase the Basic Support package at http://organizeseries.com and you’ll have access to the private support forums on our site where we will be happy to help you troubleshoot your problems.Yeah it’s just a warning saying they don’t know of that namespace. Your feed actually does validate. I use the namespace so I can add the ‘<series>’ tag to the feed. Otherwise I’d just have to drop that tag from the feed.
thanks for posting on the google group asking that they add the namespace.