John Havlik

You shouldn’t add a field for post-your_post_type. In my example code, you have to replace post-your_post_type with post-page if you want to target the page post type (if you want to target a different post type, you will need to replace the your_post_type with the post type name. The following code makes this replacement and should work:

add_filter('bcn_breadcrumb_title', 'my_breadcrumb_title', 3, 10);

function my_breadcrumb_title($title, $type, $id)
{
    if(in_array('post-page', $type) && get_post_meta($id, 'last_breadcrumb_title', true)) {
        $title = get_post_meta($id, 'last_breadcrumb_title', true)
    }

    return $title;
}

Normally, the home breadcrumb should be linked, as long as you’re not on the home page, especially when using the default settings for the breadcrumb templates. Assuming the template is correct, my guess is there is code hooking into the bcn_breadcrumb_linked filter and returning false for the home breadcrumb. If the home breadcrumb seems to use the unlinked breadcrumb template, this may be the case. Otherwise, there may be something else unique about your setup which is throwing Breadcrumb NavXT off/making it think that the home breadcrumb should never be linked for some reason.

In this case, you want to replace post-your_post_type with post-page since you’re using the page post type. The in_array() function is a PHP function, not a WordPress function, so it doesn’t understand the post_type=page argument format.

Is “Best Bar Asia” a post or a term?

A point of clarification, bcn_breadcrumb_title operates on every breadcrumb in the trail. You have to within it check for the specific type of breadcrumb you’d like to modify the title for. It is not specifically operating on the last breadcrumb in the trail.

I’m not exactly sure where you found the code you started with for the filter, but it looks similar to something recently posted to the support forums which had a couple of similar issues. You only want to return $tittle rather than trying to return all three parameters that are passed into the filter (the second two returns are literally doing nothing so they shouldn’t be there). Additionally, using get_post() within this filter is not necessarily safe/not guaranteed to yield the desired results, instead you want to use the information passed into the filter (the $type array and the $id). An example is presented below:

add_filter('bcn_breadcrumb_title', 'my_breadcrumb_title', 3, 10);

function my_breadcrumb_title($title, $type, $id)
{
    if(in_array('post-your_post_type', $type) && get_post_meta($id, 'last_breadcrumb_title', true)) {
        $title = get_post_meta($id, 'last_breadcrumb_title', true)
    }

    return $title;
}

However, this code is only going to target posts. If “Best Bar Asia” is a term, then you will need to use get_term_meta() instead of get_post_meta() for that one. And, in the code above, you will want to check for ‘tax-your_taxonomy_type’ instead of ‘post-your_post_type’ where your_taxonomy_type or your_post_type is the taxonomy or post type you’re wanting to try to get the meta for. An example of code that would do both:

add_filter('bcn_breadcrumb_title', 'my_breadcrumb_title', 3, 10);

function my_breadcrumb_title($title, $type, $id)
{
    //Handle posts of type your_post_type
    if(in_array('post-your_post_type', $type) && get_post_meta($id, 'last_breadcrumb_title', true)) {
        $title = get_post_meta($id, 'last_breadcrumb_title', true)
    }
    //Handle terms of taxonomy your_taxonomy
    if(in_array('tax-your_taxonomy', $type) && get_term_meta($id, 'last_breadcrumb_title', true)) {
        $title = get_term_meta($id, 'last_breadcrumb_title', true)
    }
    return $title;
}

Lastly, if you really don’t want to go through with the write code to do all of this path, the Title Trixx extension (premium) provides the metaboxes for both posts and terms (of any type) to allow you to override what is used for the breadcrumb title.

bcn_breadcrumb_title is the correct filter to use. However, you filter function has some problems with it that are worth discussing.

First, it should just have one return, return $title;. Since PHP executes in order, the behavior will be the same as what you currently have (it will return right away so the second 2 returns never get executed). For WordPress filters with multiple parameters, only the first is the item to be filtered (and the one you need to return), the others provide context for the filter.

I don’t think the conditions within your if statement are going to yield what you want. It would be better to check the $type array for the post type you care about, and then make your call to get_field. In fact, I would not call get_the_ID() either. If you want this to only apply when the breadcrumb is for the current item (not sure if that is the intent), you can check the $type array for 'current_item' being a member. This really is only necessary if the post type is hierarchical as for non-hierarchical post types aren’t going to have children (so a breadcrumb for said posts will always be the current item).

It appears get_field is not a WordPress function, the best practice is to check for its existence before calling (to prevent PHP errors if the plugin providing that function isn’t present for some reason).

With these changes, you code would look more like the following:

add_filter('bcn_breadcrumb_title', 'my_breadcrumb_title', 3, 10);

function my_breadcrumb_title($title, $type, $id)
{
    if(in_array('your_cpt', $type) && function_exists('get_field')) {
        $title = get_field('your_meta_tax', $id);
    }

    return $title;
}

As a follow up, Breadcrumb NavXT 7.2 was released yesterday and should fix PHP 8.1 compatibility issues present in the previous versions. Please let me know if you are still experiencing issues with PHP 8.1.

From looking at the code, my assumption is wp_kses_allowed_html() is returning something other than an array on your site. This may be due to something hooking into one of the several filters within that function and not returning an array like it should. You could try deactivating all plugins other than Breadcrumb NavXT to see if the warnings go away. What page/where do these PHP warnings end up showing up, is it on the front end of the site, on the Breadcrumb NavXT settings page, only on the plugins page immediately after activating, or somewhere else?

The current development version (on GitHub) has PHP8.1 support fixed. Hopefully, within the next couple of weeks I will be able to get the next release (7.2) out which will include this fix.