John Havlik
Forum Replies Created
-
Forum: Plugins
In reply to: [Breadcrumb NavXT] Version 7.4.0 removed all breadcrumbs from my siteThat screenshot is helpful. It appears to be the legacy widget that is getting pulled in there. I’ll have to dig into what may be causing the widget to not load (hopefully it isn’t something weird that Elementor is doing like whitelisting widget versions).
Forum: Plugins
In reply to: [Breadcrumb NavXT] Version 7.4.0 removed all breadcrumbs from my siteThanks for the additional information. Since I don’t have access to Elementor, I’m going to have to rely on Elementor users to help debug this. Do you know if Elementor is using the widget or block? At some point WordPress moved to using blocks by default instead of widgets (even when in the widget editor). Other than the version number changing, nothing else about the legacy widget changed between 7.3.1 and 7.4.
Forum: Plugins
In reply to: [Breadcrumb NavXT] Breadcrump on Search ResultsWithin a search results page, as long as the call to
bcn_display()is before the loop/outside of the loop, it should figure out that it is on a search results page. If you trying calling this within the loop, it is likely to not figure out that it is a search results page.- This reply was modified 1 year, 5 months ago by John Havlik.
Forum: Plugins
In reply to: [Breadcrumb NavXT] Version 7.4.0 removed all breadcrumbs from my siteHow are you calling the breadcrumb trail (calling
bcn_display(), using the widget, using the Breadcrumb Trail block, or something else)?Yeah, this was previously reported in this thread: https://wordpress.org/support/topic/function-_load_textdomain_just_in_time-was-called-incorrectly-11/. A fix is in the development branch (on github), a release will show up some time before the end of the year.
Forum: Plugins
In reply to: [Breadcrumb NavXT] Plugin settings – Private root page not accessibleLooks like this is due to the default behavior of
wp_dropdown_pages, which is used in the Breadcrumb NavXT settings page for the Root Page selector. Normally, it isn’t a great idea to have the root page be private (unless the entire post type is private), so having only public/published pages would be the most expected behavior from the dropdown. I can look at what makes the most sense for allowing private pages to show up in the dropdown (likely a filter for the arguments that are used) for the next release of Breadcrumb NavXT.Forum: Plugins
In reply to: [Breadcrumb NavXT] Fatal Error TriggerYou are likely breaking a translation string for Breadcrumb NavXT/adminKit, hence the error. I don’t know what the
GP_remove_comments_are_closed_herefunction looks like, but my guess is you’re returningNULL(or simply failing to return anything) on the Breadcrumb NavXT translation strings. Generally speaking, filters should not break the API (you should not be returning NULL for something that must return a string).Thanks for reporting this. I was able to reproduce it in my development environment and am tracking it in the following github issue: https://github.com/mtekk/Breadcrumb-NavXT/issues/303. An initial fix has been pushed to the vollyballer branch (development branch for Breadcrumb NavXT 7.4).
Forum: Plugins
In reply to: [Breadcrumb NavXT] Warnings in PHP error_logInteresting, ultimately, it still sounds like something (MailPoet in this case) is breaking the WordPress API. That said, the function that gets tripped up here is slated to get refactored soonish (next major release), in the meantime, a check is being added to prevent the warning.
I’m tracking this in the following github issue: https://github.com/mtekk/Breadcrumb-NavXT/issues/302
Forum: Reviews
In reply to: [Breadcrumb NavXT] HUGE drawbackShortcodes have come up a few times in the years I have been maintaining Breadcrumb NavXT. Traditionally, they are a very poor way to call breadcrumb trails (manually adding them to every page/post that you want a breadcrumb trail is tedious). Now that the block editor exists (with block templates and block themes), it was decided that supporting the block editor with a Breadcrumb Trail block was a much better option. Breadcrumb NavXT can be called using the
bcn_display()function, using the Breadcrumb Trail block, or the included widget.Since shortcodes are on their way to being deprecated within WordPress, the core of Breadcrumb NavXT will not add shortcode support. You can always create your own shortcode in a site specific plugin that calls
bcn_display(), there is also an extension to Breadcrumb NavXT that includes a shortcode.Forum: Plugins
In reply to: [Breadcrumb NavXT] use primary categoryThe “Primary Category” feature is not something that is part of WordPress itself (Yoast is adding that). You’ll need extra code to tell Breadcrumb NavXT to use the primary category. You can use the bcn_pick_post_term filter to do this, there are also plugins that exist that allow you to specify what term/category Breadcrumb NavXT uses (Order Bender, and Breadcrumb NavXT Paths).
As for where the breadcrumb trail is showing up on your site, that is likely due to differences in how the theme handles posts and pages. It looks like in both cases the breadcrumb trail is placed below the title, it’s just on posts the title is below the post image while on pages it is above the post image. You’ll likely need to modify your theme/the location where
bcn_display()is called within the theme to get the breadcrumb trail where you want.Forum: Plugins
In reply to: [Breadcrumb NavXT] Why i cant use “itemListElement” to as attribute?If you want to wrap your breadcrumbs in
<li>elements, you probably want to use thebcn_display_list()function instead ofbcn_display(). With this, you don’t need to add<li>elements to your breadcrumb templates.If you really want to add
<li>elements to your breadcrumb templates, you can use thebcn_allowed_htmlfilter to modify what’s allowed. See the following article for an example of how to do this: https://mtekk.us/archives/guides/how-to-add-li-and-other-tags-to-breadcrumb-templates/Forum: Plugins
In reply to: [Breadcrumb NavXT] Internal Server Error when saving settingsThis is most likely caused by overly aggressive ModSecurity rules. You will need to work with your webhost to identify the rules causing the problem and adequately adjust them. I expect that the HTML within the breadcrumb templates is causing the overly aggressive rules to trigger.
Forum: Reviews
In reply to: [Breadcrumb NavXT] doesn’t work after activationBreadcrumb NavXT doesn’t include a shortcode (and does not advertise having a shortcode). Breadcrumb NavXT does include a widget, an editor block (Gutenberg block), and there are instructions on how to call the breadcrumb trail using the
bcn_display()function (see https://mtekk.us/archives/guides/calling-the-breadcrumb-trail/). If you need help with getting Breadcrumb NavXT integrated with your theme, you should open a support ticket: https://wordpress.org/support/plugin/breadcrumb-navxt/Forum: Plugins
In reply to: [Breadcrumb NavXT] Fatal error in class.bcn_breadcrumb_trail.php on line 124@coriolis_too thanks for digging into this farther. Given the error I was expecting something like this but was lead astray by the line number PHP was giving.
@juliemoynat thanks for fixing the translation and notifying the translation team. I’m not sure why your replies were deleted from the thread, I think they provided important context.
@audrasjb thanks for getting the fixed translation string approved and following up on this. It looks like there may be an opportunity to improve the translation tool and WordPress itself here. WordPress should check for PHP errors when loading a translation package, similar to what it does on plugin activation. Additionally, the translation tool could warn on strings that would cause a sprintf/printf error, the tool already identifies these printf tags in the original string (maybe it could even prevent such a translation from being approved).