lucspe

I understand your point of view about keeping things simple.

However the point is that – as it stands – the plugin assumes that the footer text is hardcoded into “storefront_footer” action hook.

I believe the use case of moving the footer text after the footer (so hooked into storefront_after_footer) is not uncommon and whilst this can be achieved manually by a developer, I think the overall concept of the plugin is to make managing footer credits easy on the end user.

So it is not an “advanced or overly complicated” modification (as it just adds a select box in customizer so the user can choose whether to place the text in the footer or after) and would make this otherwise very useful plugin a bit more flexible 🙂

At any rate, case closed. Ultimately, this is your work so I respect your decision.

I just would have preferred to avoid having to mantain a forked version of this for my sites, which is the reason why I approached you in the first place about this 🙂

Cheers,
Luca

You’re welcome. I am glad that is useful.

btw: I just wanted to mention that it is kind of standard practice (at least in my experience on patches I sent for other plugins) to give props in the changelog when you incorporate changes contributed by other people, even if – like in this case – is a small one 🙂

Cheers,
Luca

Hi Christina,

Sorry for the delay in answering, I was away for a few days.

I have filled the contact form as requested.

I was also wondering if – in the meantime – you guys have found out what the problem was, since it has been a few days and this seems to be a quite widespread issue.

Thanks,
Luca

Hi Christina,

This happened both on PHP 5.5 (5.5.38) and PHP 7 (7.0.15)

Cheers,
Luca

Thanks!

Hi thanks for the quick reply.

Indeed it works as you described.

However, I have a followup question.

Given that the opening time is the same Mon-Fri, is there a way to avoid having a super-long list repeating the same information and shrink it up to simply “Mon-Fri” and then the time?
Then next line “Sat-Sun” closed?

I tried the show_opening_hours_brief=1 attribute however this way it shows as:

Mo,Tu,We,Th,Fr 09:00 – 13:00; Mo,Tu,We,Th,Fr 14:30 – 18:30

which is not very friendly to read.

• This reply was modified 9 years, 6 months ago by lucspe.

Hi,

I see you have just released 1.2.34. Thank you for continuing the work on this excellent and free plugin.

However – 1 month later from your initial reply – you still have not updated the github repo.

As I said, that makes kind of difficult to keep forked versions updated, let it alone to contribute to the main development branch.

Could you please clarify if you intend to continue supporting github or not? I really like your plugin but availability on github was a critical decision-making factor for me.

Also it would be nice to consider for inclusion the pull request I sent you as I can imagine a number of use cases where users without admin priviledges would need to be given permission to manage the cookie settings options page….or at least close the pull request if you think it is not the case to include it 🙂

Thanks a lot and thanks again for this great plugin.