Trân Minh-Quân

“We as programmers don’t necessarily know what is better for the user… only they do.”, I’m OK with your proposition, just wanted to make it the way WordPress is, which is you cannot delete or change your account 🙂

As an openid has the only login way is by openid (if the user does not update the password field), we should not show that only openid to the user in order to avoid the deletion of that openID.

Users can add others openIDs, if they have more than 1 openID they can delete the openID used for registration.

if( count($urls)==1 && strpos($userdata->user_login,'oid-')===0 ) :
echo '
<p class="error">You cannot delete your only OpenID.</p>';
else:

I propose to add ‘oid-‘ at the beginning of ‘user_login’ to facilitate the verification if it’s an openID account or not.

return "oid-".$username;

LOGIC.PHP

function generate_new_username($url) {
			$base = $this->normalize_username($url);
			$i='';
			while(true) {
				$username = $this->normalize_username( $base . $i );
				$user = get_userdatabylogin($username);
				if ( $user ) {
					$i++;
					continue;
				}
				return "oid-".$username;
			}
		}

INTERFACE.PHP

function profile_panel() {
	  global $userdata;

		if( !current_user_can('read') ) {
			return;
		}

		$this->logic->late_bind();

		if( 'success' == $this->logic->action ) {
			echo '<div class="updated"><p><strong>Success: '.$this->logic->error.'</strong></p></div>';
		}
		elseif( $this->logic->error ) {
			echo '<div class="error"><p><strong>Error: '.$this->logic->error.'</strong></p></div>';
		}

		?>

		<div class="wrap">
			<h2>Your Identity URLs</h2>

			<p>The following Identity URLs <a title="What is OpenID?" href="http://openid.net/">?</a>
			are tied to this user account. You can login with equivalent permissions using any of the
			following identities.</p>

		<?php

		$urls = $this->logic->store->get_my_identities();

		if( count($urls) ) :
		  if( count($urls)==1 && strpos($userdata->user_login,'oid-')===0 ) :
		    echo '
			<p class="error">You cannot delete your only OpenID.</p>';
		  else:
		  ?>
			<p>There are <?php echo count($urls); ?> identities associated with this WordPress user.</p>

			<table class="widefat">
			<thead>
				<tr>
					<th scope="col" style="text-align: center">ID</th>
					<th scope="col">Identity Url</th>
					<th scope="col" style="text-align: center">Action</th>
				</tr>
			</thead>

			<?php foreach( $urls as $k=>$v ): ?>

				<tr class="alternate">
					<th scope="row" style="text-align: center"><?php echo $v['uurl_id']; ?></td>
					<td><a href="<?php echo $v['url']; ?>"><?php echo $v['url']; ?></a></td>
					<td style="text-align: center"><a class="delete" href="<?php
					echo wp_nonce_url(sprintf('?page=%s&action=drop_identity&id=%s', $this->profile_page_name, $v['uurl_id']),
					'wp-openid-drop-identity_'.$v['url']);
					?>">Delete</a></td>
				</tr>

			<?php endforeach; ?>

			</table>

			<?php
			endif;
		else:
			echo '
			<p class="error">There are no OpenIDs associated with this WordPress user.</p>';
		endif; ?>

		<p>
			<form method="post">Add identity:
				<?php wp_nonce_field('wp-openid-add_identity'); ?>
				<input id="openid_url" name="openid_url" />
				<input type="submit" value="Add" />
				<input type="hidden" name="action" value="add_identity" >
			</form>
		</p>
		</div>
		<?php
	}

I propose to change profile.php to users.php (in interface.php) due to the fact the profile Menu and users Menu locate differently in Admin and Non-Admin accounts.

$hookname =	add_submenu_page('users.php', 'Your Identity URLs', 'Your Identity URLs',
				'read', $this->profile_page_name, array($this, 'profile_panel') );

In fact, everything is fine, i just forgot to edit the hash for the record of the openid I use to test.

🙂

Try to Rebuild Tables of openid plugin first, specify your PHP version btw.

For me everything works well, I did not touch anything.

Thank you so much for the new version 😉