Jakub Klapka
Forum Replies Created
-
Forum: Plugins
In reply to: [Secure post with link] WP5 compatibility & 404 errorHello,
indeed, the plugin is not ready for WP5 with Gutenberg. It is definitely my nuber one priority for this plugin, but there are still few technical hurdles. I think, I’ll be able to make it sometime during April.
Anyway, with disabled Gutenberg, it should work in WP5. (I have not yet thoroughly tested it though)
I’m thinking, if your disabling and enabling plugins won’t mess with rewrite rules. Can you try going to Settings -> Permalinks and hit Save (without any changes)?Forum: Plugins
In reply to: [Shortcake (Shortcode UI)] Select2 conflict with Advanced Custom FieldsHello,
In ACF 5.5, they have added filter, which would resolve it in much better way.
TLDR:add_filter( 'acf/settings/select2_version', function( $version ) { return 4; });More on that on https://support.advancedcustomfields.com/forums/topic/select2-conflict-with-awesome-support/#post-46856 .
Well, that is unfortunate 🙂 I wonder, if that is really common, that plugins have more than one textdomain?
It would be nice, if there was some way, how to “bypass” the string, which is used as textdomain to look for strings. For example if I could set, that this plugins “textdomain” is “$this->config->get(‘textdomain’)” (or regexp would be awesome). Or just option, to use same logic as v1 for specific plugin.
Loco is really handy for plugin authors, as the interface and usability is even better, than usual standalone apps – like poedit. And I think, that hardcoded textdomain is not really good practice.But I understand, that this is subject of demand, so just count my vote in 🙂
Thanks for your time, J.
Forum: Plugins
In reply to: [Timber] template_uri doesn't work since updateHello, just a thought, deprecation in minor version shouldn’t mean “break for good” by my standards. I just went through rollback on several sites after regular updates. :-/
I believe, that for framework plugin, updates should be really more thought through, as sites are much more dependent on it’s funcionality. And geting rid of deprecated stuff is little harder for larger projects…Just saying, still love the plugin 😉
Hello, I do confirm, that this fixed the issue with my custom made theme. Thanks a lot!
I actually don’t use Underscores or anything like that. I have from scratch custom made theme, but i believe, that problem would be in some js library I’m using. I have theme here: https://github.com/jakub-klapka/linnette_2015-wp (frontend here: https://github.com/jakub-klapka/linnette_2015-html ), but we might wait, if you fix the problem with underscores and I let you know, if that fixes it for me too.
If not, or if you want more information about that, I can give you access to my staging web with this template, so you don’t have to dig into my github repo.Hello,
I have exactly same problem with one of my CPTs. I’ve enabled SCRIPTS_DEBUG and on page load, I get those errors:Uncaught TypeError: Cannot read property 'id' of undefined media-audiovideo.js?ver=4.2.1:86Uncaught TypeError: Cannot read property 'id' of undefined media-models.js?ver=4.2.1:1229Then on click on “Add Media” I got this:
Uncaught TypeError: Cannot read property 'audio' of undefined media-views.js?ver=4.2.1:5089Hope that helps, Jakub
Forum: Plugins
In reply to: [Loco Translate] [Feature request] Keyboard shortcutsPOEdit uses Ctrl+Down and Ctrl+Up. Which makes sense also in your plugin, where strings are below each other.
Forum: Plugins
In reply to: [Wp Favs - Plugin Manager] [Feature suggestion] Uninstall plugins in FavAwesome, thanks!
I just realized, that redirecting to some unique page slug could be also kind of feature. If you would wp_redirect to something like
/aiowps-hidden-adminusers will normally get 404 (working one). But they can create page with this exact slug and they can maybe put some notification for human-users, where they can really find admin or something like that…Thanks. I have looked into your code a little bit more and the dealbreaker is really
is_admin()conditional. This is set to betrue, as/wp-admininitialy acts as admin request. Since processing of rename login page is onwp_loadedfilter, that is far after all the theme and plugin files are loaded. The problem is, that themes and plugins are sometimes usingis_admin()to load just appropriate files depending on type of request (I believe, that good themes and plugs shloud do that 🙂 ).
When the execution hits your 404 loading, you call$wp_query->set_404()and the conditionals get right at this point, but this is too late for themes/plugs to load files depending onis_admin().Cleanest way of solution I see here is to
wp_redirectto brand new 404 page anddie(). In this case all conditionals would be OK from begining of the request and bots, who don’t followLocation:will get blank page, which is still fine (maybe even bettter for sake of server processing time 🙂 ).Just little example from my life, why is can be quite deal: I load all my
add_shortcode()only on frontend request (because there is no reason to load them on admin actually). In my footer, I have my e-mail address wraped in shortcode, which will obfuscate it against bots. What this bug do at the end is that on/wp-adminURL my e-mail gets printed out in plantext, since there are no shortcodes registered for that request. Not to mention styles and scripts, which won’t load either, since I don’t run all my frontend functions (including registering frontend styles) for admin requests.
This is just for better understanding of consequences, I don’t want you to deal with those specific problems 🙂So thanks a lot once more, for considering this and thank you for great plugin.
Jakub KlapkaYes, actually it behaves correctly on all pages even with Rename login page turned on, except the one 404 page generated by visiting /wp-admin. All other 404 pages are fine.
Thanks a lot!
Thanks! I’ve reviewed the class for htaccess writing and there are probably several ways how to handle it. All folowing is about wp-security-utility-htaccess.php in classes dir.
The one, that concerns my problems on my host is ServerSignature directive. So something like this would help me:
(line 422)
//disable the server signature $rules .= apply_filters('aiowps_htaccess_server_signature', 'ServerSignature Off' . PHP_EOL);But I can imagine, that others might have problems with different directives and adding filters to every line that is added to htaccess is probably not worth it. Maybe you have some statistics, which directives usualy make problems and put filters to those?
Other way would be adding filter for whole array which gets writen into htaccess. Than we could easily go through that array and via string functions find those, we want to modify. That way we could modify any rule this plugins write into htaccess, which can save more people. Downside of this approach is, that we would have o depend on string find and replace functions, so if you change some rule – like add spaces, change word to uppercase or those kind of things – our modifications will probably stop to work.
The code I’m talking about could be something like this:
(line 130)$rulesarray = explode( PHP_EOL, $rules ); $contents = array_merge( apply_filters('aiowps_htaccess_rules', $rulesarray), $ht );Combining both ways woud be best of course 🙂
Hope you’ll get the point, Thanks a lot, JK
I’m getting 404 (through WP). I’ve tried to flush rewrite rules, but no change.
I’ll try to pull the site to my local machine and run it through some debugger. Do you have any ideas, what to look for (bad rewrite rules or something like that?)
Thanks a lot, JK