jbx

I have 163 events.

Yes on the original setup which is just a shared hosting the index page comes up in less than 2 seconds. On the index page (and all pages) I have the events widget.

Thanks, issue seems fixed now.

Hi Marcus,

The filter I am using at the moment was very convenient because it passes the number of pages, current page etc. all as separate arguments.

The other hook (at least the one I know of) just receives the string with the page links. My page links are substantially different and I don’t want to hack around with some messy solution of trying to parse the default link and extract the links from that, apart from the fact that it will be difficult to know whether there are more pages left to enable/disable the Next (or Prev) buttons.

If you want to introduce a new filter that provides the same information (base link, number of pages, number of items, current page etc.) so that one could structure it as needed I guess it would be fine. However I don’t really see why you should leave the old filter broken like that in the codebase honestly, especially when it was working fine up till a few versions ago. Isn’t there any way to use the new centralised $page_link_template function correctly in the old filter in some way?

Any idea if this fix was incorporated in version 5.5.1 just released? I don’t want to update and lose this fix.

I fixed it by changing the output line to the following in events-manager/classes/em-events.php:

$page_link_template = preg_replace('/(&|\?)pno=\d+/i','',$_SERVER['REQUEST_URI']);
$page_link_template = em_add_get_params($page_link_template, array('pno'=>'%PAGE%'), false); //don't html encode, so em_paginate does its thing;

$output .= apply_filters('em_events_output_pagination', self::get_pagination_links($args, $events_count, 'search_events', self::get_default_search()), $page_link_template, $events_count, $limit, $page);

However, it will be lost the moment I update to a newer Events Manager version. Can it be included in the next version before a new update is issued?

thanks

Hi,

I compared events-manager/classes/em-events.php of the latest version with the newest version, and I think the bug is in this line, in functions output() and output_grouped().

$output .= apply_filters('em_events_output_pagination', self::get_pagination_links($args, $events_count, 'search_events_grouped', self::get_default_search()), '', $events_count, $args['limit'], $args['page']);

The $link_template parameter passed to the filter is explicitly being set to '', no wonder I am getting an empty string.

In the old version when it worked it used to be:

$page_link_template = preg_replace('/(&|\?)pno=\d+/i','',$_SERVER['REQUEST_URI']);
$page_link_template = em_add_get_params($page_link_template, array('pno'=>'%PAGE%'), false); //don't html encode, so em_paginate does its thing;

$output .= apply_filters('em_events_output_pagination', em_paginate( $page_link_template, $events_count, $limit, $page), $page_link_template, $events_count, $limit, $page);

The $page_link_template was explicitly being set. Now it disappeared.

Can you schedule a fix to bring this back to work properly?