Jason Hendriks
Forum Replies Created
-
Forum: Plugins
In reply to: [Contact Form 7] Contact Form 7Also, this is showing in the header info,
Can you post an entire email with all headers.
Forum: Plugins
In reply to: [Contact Form 7] Contact Form 7 or any other isnt workingits Locaweb (www.locaweb.com.br) a brazilian host.
Not that useful. How about posting the email domain you are trying to send from/to and the SMTP server you are using.
I cant find out what is interrupting the emails
See WordPress emails are sent but not received and https://wordpress.org/tags/email-not-received
Forum: Fixing WordPress
In reply to: Registration emails not sending, while other notifications areSimple:Press takes over and breaks registration emails?
Not that Simple:IsIt ? 😉
Forum: Plugins
In reply to: [Postman SMTP Mailer/Email Log] Swedish translation of PostmanWould you post your email domain name, and the hostname of the SMTP server you are using.
Forum: Plugins
In reply to: [SendPress Newsletters] Confirmation-mail stuck in queueFollowing
Ok. I was wondering if GoDaddy was forwarding your port externally because of that setting but obviously not. They just haven’t firewalled you permanently.
Lucky you!
Yup
AFAIK, ports 25, 465 and 587 are never open to Google from GoDaddy.
The Gmail API was implemented in Postman specifically as a solution for GoDaddy-hosted websites.
I don’t know why your GoDaddy site works differently from the norm, but I recommend switching to the Gmail API to avoid future problems.
Question: do you have Remote Mail Exchangers enabled in your cPanel?
Forum: Plugins
In reply to: [SendGrid] Sendgrid plugin is polluting the Global namespaceUpdate.
I found this $plugin codex example:
static $plugin; if (!isset($plugin)) $plugin = plugin_basename(__FILE__);I think this is probably where the SendGrid author got the idea from. Except s/he omitted the static keyword causing the collision with global.
Also, I take back what I said about $plugin, I misunderstood what you said about WP setting it in a loop. Turns out WordPress does not set this variable at all, so it’s not part of the API or the codex. It’s just a badly used global variable, you are right.
Forum: Plugins
In reply to: [Postman SMTP Mailer/Email Log] ErrorI’m really confused how you triggered this as your Editor should not have been able to enter the block on line 376 because of the PostmanUtils::isAdmin() check in initializeAdminPage().
Apparently they passed that check, which means they have an administrator capability, and they would have passed the same check in registerHooks() and then $this->oauthScribe would not have been null.
So really scratching my head here 😀
I added a custom capability for Postman, in case the failure is in
current_user_can ($role). The codex says it’s okay but maybe it’s not. Would you install v1.6.25c and see if the changes I made fix it?Also, do me a favour and make this topic title a little more specific? Thanks!
Forum: Plugins
In reply to: [SendGrid] Sendgrid plugin is polluting the Global namespace1) $plugin is not a documented WordPress global variable.
Assuming a global variable exists and is set to a particular value is bad practice in any case.
The Codex is full of examples of Global variables, $pagenow and $wpdb for instance.In the case of WordPress, global variables exist as part of the API. We have to work with what we’re given.
Specifically, line 13 of wpsendgrid.php is setting a global variable $plugin:
$plugin = plugin_basename( __FILE__ );100% this is wrong on SendGrid’s part, because $plugin is implicitly a reserved WordPress global variable.
But to say the other plugin shouldn’t expect $plugin to be there is nonsense.
I appreciate and enjoyed your point of view though.
Cheers,
Jason 🙂Forum: Plugins
In reply to: [Postman SMTP Mailer/Email Log] ErrorYa, I found the issue. In PostmanAdminController I do have the administrator role check:
public function registerHooks() { // only administrators should be able to trigger this if (PostmanUtils::isAdmin ()) {Except by here it’s too late. The editor is already inside the AdminController. Should be easy to fix.
Forum: Plugins
In reply to: [Postman SMTP Mailer/Email Log] ErrorI can’t reproduce this error.
On a multisite install I:
- installed User Role Editor
- Installed and configured Postman 1.6.24
- modified the Editor role (your posted roles were insufficient to show the link; I also had to check list_users and promote_users)
- assigned a new user as Editor and went to the Users > Add New page
Nothing. Everything works as expected. Except the warning “WordPress is still handling email delivery, not Postman. Configure the plugin.” appeared when it shouldn’t have. That’s for admins only.
I also tried non-multisite. And I also tried with Postman unconfigured. Have I missed a step?
However, I can see a potential problem, even though I can’t reproduce one here. In Postman.php:
// load the administration screens if (is_admin ()) { // the is_admin check only tells us that we are not on the public pages $this->setup_admin (); }That’s wrong. I should be checking for the administrator role there as well as checking is_admin(). I’ll find a fix and let you know.
Forum: Reviews
In reply to: [Postman SMTP Mailer/Email Log] FantasticAwww. Thanks!! 😀