Jake Hall

Hi @lnikj,

This issue has been resolved. Would you mind giving it a shot now?

– jake

Hi @tronix-ex,

Can you confirm the 1.4.1 update has worked on your demo site?

Jake

Hi @tronix-ex,

Hopefully fully resolved now… the issue is due to how bbPress format those statistics… completely flew over my head and is a bug that affects ALL versions since 1.1.1! (which was released a year and a half ago… wow!) Thank you for assisting with this, it feels good to get this bug out of the way.

Could you deactivate the current version you have installed, delete it and then upload and install this version? You should then see the issue is corrected, regardless of whether or not the merge option is enabled.

https://downloads.wordpress.org/plugin/bbpress-improved-statistics-users-online.zip

– Jake

• This reply was modified 9 years, 5 months ago by Jake Hall.

@tronix-ex,

Can you uncheck it and see what happens. That will then display the replies.

It seems to be an issue when adding the replies and topics… could you try this code with the option ticked and let me know what happens?

$stats = bbp_get_statistics();
                
                $stat_replies = $stats['reply_count'];
                
                if( $this->parent->option['bbpress_statistics_merge'] == "on" ) {
                    $stat_replies = ( intval($stats['reply_count']) + intval($stats['topic_count']) );
                }
                
                $HTMLOutput["forum_stats"] = $this->shortcode_tool_build_title( __('Forum Statistics', 'bbpress-improved-statistics-users-online'), false );
                
                if( $this->parent->option['bbpress_statistics'] == "on" ) {
                    $HTMLOutput["forum_stats"] .= '<span class="bbpas-title">' . __('Threads', 'bbpress-improved-statistics-users-online') . ": </span>{$stats['topic_count']}, " 
                    . '<span class="bbpas-title">' . __('Posts', 'bbpress-improved-statistics-users-online') . ": </span>{$stat_replies}, "
                    . '<span class="bbpas-title">' . __('Members', 'bbpress-improved-statistics-users-online') . ": </span>{$stats['user_count']}<br>";
                }

Thank you

Hi @tronix-ex,

Glad you managed to suss that – do note with the change you have made you will not be able to count the original post within each topic in the stats.

Could you do me a quick test? Before I push this fix out, can you update class.online.php with the following code and let me know if it works?

Replace:
$stat_replies = ( ( $this->parent->option['bbpress_statistics_merge'] == "on" ) ? ( $stats['reply_count'] + $stats['topic_count'] ) : $stats['reply_count'] );

with:

$stat_replies = $stats['reply_count'];
                
                if( $this->parent->option['bbpress_statistics_merge'] == "on" ) {
                    $stat_replies = $stats['reply_count'] + $stats['topic_count'];
                }

and change the variable you changed earlier back to $stat_replies? That should hopefully fix the issue fully!

– Jake

So for some forums this is working.

Others, such as your own, it isn’t. I have actually create a test plugin for this, would you mind installing it and letting me know what it returns? Simply add the code below to your functions.php file:

<?php
function bbp_get_stats_bf() {
     $stats = bbp_get_statistics();
     return "Replies: ." . $stats['reply_count'] . "<br>Topics: " . $stats['topic_count'];
}

add_shortcode( 'bbp-get-stats', 'bbp_get_stats_bf' );

All it will do is fetch the stats, and, return them in a shortcode. Once you install this, can you add the shortcode ‘bbp-get-stats’ to the others you’ve setup and get back to me? Can I also have a link to your forum if possible?

Thanks,

@tronix-ex,

Can you confirm [bbp-stats] and [bbpas-activity] return the same data? (They are shortcodes, pop them on a page somewhere)

• This reply was modified 9 years, 6 months ago by Jake Hall.
• This reply was modified 9 years, 6 months ago by Jake Hall.