fredd500

Sorry Dan, this doesn’t look like it has fixed it.

I deleted the plug in and re-installed it. While the settings screen now performs better in that it reliably allows me to enable ghostscript after setting the path which it didn’t before. It still doesn’t generate thumbnails as it should.

The reason for this is that the call to getThumbnail() calls self::getThumbers(). getThumbers() checks whether ghostscript is now active (which it is because I set it in the settings screen) then calls getGhostscriptExecutable() which is still calling exec(‘which gs’) to find the executable which we know fails.

I also had a problem in that after finding that the new version didn’t work I patched it as above but the document_gallery options already contained a lot of [‘thumber’][‘thumb’][ID] = false settings. The only way I could clear these was to uninstall, re-install, patch then enable the plug-in again. Not often needed perhaps, but how about adding a ‘regenerate thumbnails’ button to the settings screen which will clear out all of these settings forcing the plugin to regen. This could also help if a user upgrades ghostscript or chooses to change options etc.

Right, I think I am getting somewhere.

I am thinking at the moment, that the problem lies in how document-gallery decides whether I am able to run Ghostscript. On re-installing the plugin, it failed to detect Ghostscript. I can run it from the command line, but I think that is irrelevant. I’m using TSOHost in the UK and I SSH to a different IP address to where my web server sits. I think the path on the web server might not be set correctly.

I defined the path to Ghostscript manually by setting it to the standard gs path on linux (and the same as it is on the box I ssh to) /usr/bin/gs.

The getGhostscriptThumb function uses $options[‘gs’] to identify the binary to call. Since I have set this, it works.

The problem lies in the fact that getGhostscriptExecutable() fails because it doesn’t appear to reference my setting at all and insists on calling exec(‘which gs’). This in turn results in getThumbers() not adding the getGhostscriptThumbnail() function to $thumbers and so it is never called. I think the ‘which’ command fails – probably because the path isn’t set or something like that.

I’m making some progress. I haven’t done your last step, but can confirm that exec() is available and get_tmp_file() returns the path to the root of my uploads/ directory.

Checking in there, I can see some temporary jpgs. Woohoo. Browsing to them http://site/wp-content/uploads/md5hashstring.jpg displays a JPG version of the last page* of my PDF. Double WooHoo.

So, the issue I guess is either the script is timing out before it completes the move of the temporary file to it’s final resting place, or, for whatever reason, the temporary JPG is created, but it’s path not passed to the function which then moves it.

* I recall Ghostscript generating a JPG of the last page before. You kindly fixed that for me, but I don’t recall how.

Martin,

I’m using [dg category=fox localpost=false] on my pages and this works well – notwithstanding the issues I am now having with Ghostscript not working after the upgrade to 2.x.

Chris

Managed to do this myself by editing the plugin code.

diff --git a/bbp-mark-as-read.php b/bbp-mark-as-read.php
index b08d0e3..1a79a6d 100644
--- a/bbp-mark-as-read.php
+++ b/bbp-mark-as-read.php
@@ -380,11 +380,15 @@ class BBP_Mark_As_Read {
                global $post, $user_ID;
                if( 'topic' != get_post_type( $post ) )
                        return $classes;
-
-               if( $this->is_read( $user_ID, $post->ID ) )
-                       $classes[] = 'bbp-topic-read';
-               else
-                       $classes[] = 'bbp-topic-unread';
+
+               if( is_user_logged_in() ) {             // Don't bother unless the user is actually logged in - CPM
+                       if( $this->is_read( $user_ID, $post->ID ) ) {
+                               $classes[] = 'bbp-topic-read';
+                       }
+                       else {
+                               $classes[] = 'bbp-topic-unread';
+                       }
+               }

                return $classes;
        }

Any chance this could be incorporated in to the master code?