Shaun Williams
Forum Replies Created
-
Forum: Plugins
In reply to: [Code Snippets] Multisite QuestionPlugins do currently work like this.
If I am logged in a Network admin, and am under the Network Admin area, I can see all plugins. I can network activate any plugin from there.
If I then go to a subsite admin->plugins, I can see all plugins, I can activate a plugin for that subsite, and I can see which plugins are network activated. I can’t touch the network activated ones from the subsite, but I can see they are there and enabled.
Forum: Plugins
In reply to: [Gift Wrapper for WooCommerce] Breaks ThemeI think I have shown that my knowledge is enough to fix these last things using CSS, I was more pointing it out to make sure you have your classes set for the buttons according to WooCommerce standards. This way it will take the formatting applied via the Theme automatically.
Forum: Plugins
In reply to: [Gift Wrapper for WooCommerce] Breaks ThemeJust done some testing and yes, thank you it has fixed a large number of the issues.
Just a couple of outstanding ones for your reference thou.
1. The Add Gift Wrapping to Order button is in the standard WooCommerce styling. Not sure if its a problem on your end or my theme is missing the CSS for that button, but my theme styles all other buttons in WooCommerce.
2. Laout:
Model +
Before Checkout: Good
Under Coupon Field: Good
Above Totals: There is a very large gap between the form and the Gift wrap text. Can’t find the error yet, but my theme has the items and totals side by side on 1 line. Not room for before totals. So may be my theme.No Model
Before Checkout: Good, shows as a hidden form (if this is normal than rest is not as I don’t get that elsewhere).
Under Coupon Field: Good, shows form directly under the items list (after coupon).
Above Totals: Shows and works, but same issue as above with a large gap between.If I can find what is causing the gap, will let you know.
Forum: Plugins
In reply to: [Edit Flow] Calendar Navigation not workingIs this plugin actually supported?
Forum: Plugins
In reply to: [Code Snippets] Multisite QuestionI think I just saw the issue.
If I select the snippet sharing, I can’t network activate, but if I deselect sharing then it does network activate, although I can’t see the snippet on the subsite list.
Not sure if this is intentional or not, but from the description, I had the impression and hope that it worked like the plugins. If I network activate a snippet I should see the snippet in the subsite, I just shouldn’t be able to deactivate from the subsite.
Forum: Plugins
In reply to: [Code Snippets] Multisite QuestionJust trying out the plugin.
The snippets are showing as available on all subsites when I enter it in the Network Admin page.
But when I select the snippet to be network activated, it isn’t. After activating I go to the subsite and the snippet isn’t active. I can activate from the subsite itself, but that will be annoying as my point of trying this is to avoid having to manually go to each subsite to make changes on common code.
Im not getting errors or anything either, just network activate a snippet, seems to go thru but when checking it isn’t activated on subsites.
Forum: Plugins
In reply to: [Invisible reCaptcha for WordPress] Not working with Google AuthenticatorAny progress with this?
Forum: Plugins
In reply to: [Gift Wrapper for WooCommerce] Breaks ThemeHave already hard coded a fix for now. Will await an update. thanks.
Forum: Plugins
In reply to: [Code Snippets] Multisite QuestionPerfect, that’s sounds exactly like what I need.
Thank you for the in-depth information.
Forum: Plugins
In reply to: [Gift Wrapper for WooCommerce] Breaks ThemeOffical answer from the Theme Developer:
Hey there,
This is Traian and I am a developer here at GetBowtied. The Retailer actually does not modify the cart or checkout page templates, either by overriding or function/hooks, the aspect of those pages is done strictly by CSS and JS.
I did checkout the plugin you mentioned, looking at the latest version ( 1.3.3 ) I was able to find this in the code:
https://www.screencast.com/t/AJCBlxD5wk
Notice how the “modal-body” div is opened outside the form but closed inside it? And the “modal-footer” div is opened inside the form and closed outside it?
Furthermore if you do a simple validation you’ll notice the mentions of several form/div issues with opening and closing them: https://www.screencast.com/t/8x12QeF3
My suggestion would be that you kindly ask the plugin author to look at fixing those tags and I imagine any layout problems should be fixed. Alternatively you could try to fix these yourself with some custom CSS, there’s no need to do any child theme or in-theme code editing. But in the long run you should get those plugin issues fixed, the issue you are seeing may not be the only one and it may vary depending on browser and how it handles broken tags.I’ll leave you to my colleagues if you have any more questions.
Cheers,
TraianForum: Plugins
In reply to: [Gift Wrapper for WooCommerce] Breaks ThemeDon’t get me wrong, I just don’t understand your answer. If my theme was doing something that is not supported by your plugin, then how does it work at all? If what you’re saying is true, then your plugin couldn’t put anything in the page at all.
Did some more reading thru the code, and speaking to the developers (Getbowtied, The Retailer theme), the theme is not using the cart page as it is only editing the header footer and CSS.
The whole cart table and buttons are coming from the Woocommerce plugin directly.
And after having a look at the default Woocommerce cart.php page gives credence to my fix.
I have been thoroughly reading thru your code, Woocommerce code and theme code.
I can confirm my theme doesn’t do anything at all to the cart. My theme has the header and footer but pulls the cart contents directly using the Woocommerce cart.php template.
Now I know I said before that the </form> tag after removing solved it, but I think I finally worked out why that works. In your code you have:
<form method=”post” action=”” class=”giftwrap_products”>
Now this one is very strange, in the raw source code, the above line shows. In Chrome Developer tools, it’s not there. I believe that dev tools is correct as it then makes sense, that if the <form.. is missing, then the corresponding </form> closes the primary form too early. Hence My “fix”. Also according to standards, you shouldn’t have nested forms.
On top of all that, I tried your plugin without the <form… or </form> tags. I removed them completely and everything is working fine. You have no action assigned to them anyway so I don’t understand why they are even needed.
Looks like my post wasn’t read properly.
It has nothing to do with the frontend. Clearly stated that it is in the Edit Posts Backend.
Thought it was clear enough above that it happens when both plugins are on, and goes away when I turn either one off.
Forum: Plugins
In reply to: [User Role Editor] Multisite ManageOK, I think that makes sense.
So basically the capabilities/menu/widget items etc., are collected from the site I am currently on. And if there are other capabilities available on subsites only, they don’t get picked up.
So for now, best thing to do is to edit Roles on a per site basis and not worry about the apply to network options.
Forum: Plugins
In reply to: [Gift Wrapper for WooCommerce] Breaks ThemeFinally found the problem.
If I delete the closing </form> tags in your plugin. Then the layout is fixed.
Still, has the issue of the Add gift wrapping to order button in both model on or off, not using the themes style.
I don’t know why this works, other than maybe woocommerce puts in the tag itself, and therefore your code doubles it up. Maybe?
Forum: Plugins
In reply to: [Gift Wrapper for WooCommerce] Breaks ThemeThere is no files.
Have been looking in the theme folder there are no cart.php or checkout.php files.