dtynan

I believe I fixed that problem on mine by changing one line in email-before-download.php. If you would like to try it, first make a copy of email-before-download.php and put it off in some other directory if you haven’t already done so (just in case).

Then, at about line 561 you should see these two lines:

// single download for the download monitor file or file lnk
   else if(!empty($d) || !empty($ebd_item->file) ){

change it so that it looks like this:

// single download for the download monitor file or file lnk
   else if($dIds && (!empty($d) || !empty($ebd_item->file)) ){

see if that fixes it.

Thoughts:

Try both Chrome & Firefox for clicking on the download link. They exhibit different behaviors sometimes and it might help to see if they do the same thing (for example, one may give an error & not save the file, the other may save a zero byte file).

Are you using the latest version of Download Monitor (note that it’s Download Monitor, not Download Manager)?

In your Downloads section (where Download Monitor shows which files you’ve uploaded), you can get to a detail type page that displays info about the file you uploaded. In the top right area of the screen there will be a URL. That URL is the direct URL for the file you uploaded. You should be able to copy that URL & paste it into your browser & download the file. If that doesn’t download, then the problem is with your file or your environment or webserver config or a conflict with a plugin or your Download Monitor setup — not a problem with Email Before Download. If it does download the file, then the problem is more likely a plugin conflict or something weird in the filename itself or a theme conflict or something like that (more related to how Email Before Download deals with the file).

Try doing another file that is not a PDF … upload a jpg & try that.

Are you set to Inline or Both in the EBD settings? If you are set to Inline, then the email you are receiving is the “notification email” that goes to the Administrator (you). If you are set to Both then 2 emails should go out — one is the notification email and the other is to the web surfer who filled in the EBD form & left his email address (when testing, this is also you, though you should use a different email address so you can see which email is which & that you are really getting both of them). ……… IF you are getting both emails, then you could turn on Attachments in the EBD config settings and then try again and see if the email you receive (that would go to the web surfer who filled in the form) has the file attached — if not, then you know the issue is with the filename or the file itself somehow.

EBD sends the email itself using PHP and it sets the From: itself. You have a couple of choices:

1. Most people encountering that problem install the Postman SMTP plugin by Jason Hendriks. Everyone using that plugin has been able to get things working, so that’s your best bet.

2. Alternatively, you can install https://wordpress.org/plugins/custom-sender-for-email-before-download/ which will let you set the From: value in the outgoing email. You will need to set it to a real account associated with your domain name (or to a real account on the system doing the sending .. it kind of depends on how you’re configured) in order to get the email to make it through to certain providers like Yahoo.

You could also set up the various spam-related email things like SPF, Domainkeys, DKIM, etc

When you press Submit on your form it never does a POST. It is getting stopped before that point. Most likely due to some javascript validation I’m guessing.

That said, there is another issue that I’ve seen occasionally on other people’s pages — your page is issuing an AJAX GET back to itself along with some Contact Form 7 query string parameters. The requested URL looks like:

http://www.cordelta.com/tools/pen-testing/?_wpcf7_is_ajax_call=1&_wpcf7=5553&_wpcf7_request_ver=1450242132132

That may not be an issue, but it might. It looks like it’s probably related to some plugin that is related to Ajax or POSTing or debuggging or redirecting or something like that. Or it could a different symptom related to the same javascript or javascript validation issue with pressing the Submit button.

If I were you I would make a simpler test page without any stuff on it (if possible) an also disable as many plugins as possible — particularly anything mucking around with forms, validation, ajax, submitting, redirecting, etc.

In the meantime, if you have a couple of minutes & want to try something else, I think you should upload a new file (using a new file name that you have never used before). It should get a new Download ID number. Change your shortcode to use the new Download ID and resave your page (or, preferably, make a new test page & put the new shortcode with the new Download ID in that page). Then test that.

In certain situations, Email Before Download can retain information from past attempts (like a bad filename). If you try and change things but continue using the same shortcode, it may have trouble. Thus, it may be worth a few minutes to do a new file name & get a new downloadID and either update your shortcode or make a new page as I said.

can you remove that location on the on_sent_ok for a couple minutes so I can try again and see exactly what it does?

Ok I just tried again, this time with Firefox rather than Chrome. As soon as I press Proceed To Download on the form it pops up a file save window to save the .msi file. It also changes the page to show the big blue download button. After it downloaded the .msi, I went ahead and clicked the big blue download button and Firefox displayed a “The page isn’t redirecting properly” error.

Ok, I assume you made a backup copy of email-before-download.php and put it off in some other directory, per my earlier instructions. Do the same now for download.php because we need to change that too.

Alright, this may not work, but we’ll give it a shot and see .. if it doesn’t work, you can put your backup copies of those two files back in place & then check back in a day or two after I’ve updated with a better solution.

Ok, you need to change WP_PLUGIN_DIR to this exact string:
plugin_dir_path( __FILE__ ).”..”

That __FILE__ inside the parentheses there is two underscores then the word FILE then two underscores and that’s all together. I have a space after the starting parenthesis and a space before the ending parenthesis, but that spacing doesn’t really matter. After the closing parenthesis is a period then a double quote then two periods then another double quote. So all of that replaces the word WP_PLUGIN_DIR and you leave everything else on the line alone (what comes after it is a space then a period then a space then “/download-monitor/” and some more junk after that.

So for example, here is what line 147 of email-before-download.php should now look like:
$pd = &get_file_data( plugin_dir_path( __FILE__ ).".." . "/download-monitor/download-monitor.php", array("Version"=>"Version"), 'plugin');

I gave you that example and spelled out the exact changes because I’m not certain if you can cut’n’paste out of this wordpress forum and get the right characters or if it would give you like html junk or something. You may be able to cut’n’paste it, which would be easier, but pay attention & make sure it looks right.

Anyway, give that a shot. So it’s 3 lines you’re changing in two files. Then, retest and see if that’s any better and let me know on here.

WP_PLUGIN_DIR occurs on line 147 and line 378 of email-before-download.php so you’ll change it in both places there. It also occurs on line 25 of download.php so you’ll change it there as well.