George Botsev
Forum Replies Created
-
I will mark this ticket as resolved now due to lack of activity.
Forum: Plugins
In reply to: [WPML Multilingual & Multicurrency for WooCommerce] version of WPMLI am marking this ticket as resolved.
Please let me know if you need further assistance, or open a new ticket.Hello, I need to update you here as well.
Our compatibility team is unable to obtain the cooperation of the author.
After the initial response from him (5 months ago), he is no longer responding to their queries.Yes – the release should be pretty soon.
To patch the file – you need to save the code above as a file – in example – patch.diff, and copy it to /wp-content/plugins/woocommerce-multilingual/inc/
Then via terminal you can go to that folder and execute the command:
patch < patch.diffThis will apply the patch.
Of course, you can do it by hand – by going to the file /wp-content/plugins/woocommerce-multilingual/inc/class-wcml-endpoints.php
and removing the lines that are indicated with minus (-) and adding the lines that are indicated by plus (+) from the code above.@andresmolina is the workaround that I mentioned not working for you?
If you wish you could apply this diff patch:diff --git a/inc/class-wcml-endpoints.php b/inc/class-wcml-endpoints.php index 7a3ff45..99a5542 100644 --- a/inc/class-wcml-endpoints.php +++ b/inc/class-wcml-endpoints.php @@ -14,8 +14,9 @@ class WCML_Endpoints{ if( !is_admin() ){ //endpoints hooks - $this->register_endpoints_translations(); $this->maybe_flush_rules(); + $this->register_endpoints_translations(); + add_filter('pre_get_posts', array($this, 'check_if_endpoint_exists')); } @@ -106,9 +107,9 @@ class WCML_Endpoints{ } function update_rewrite_rules( $value, $old_value ){ - remove_filter( 'pre_update_option_rewrite_rules', array( $this, 'update_rewrite_rules' ), 100, 2 ); $this->add_endpoints(); - flush_rewrite_rules(); + $this->flush_rules_for_endpoints_translations(); + return $value; }WPML.org account comes with active subscription for WPML plugin -> https://wpml.org/purchase/
I can try to help you, yes.
Did you try my suggested workaround?
I have escalated the issue to our compatibility team – they will attempt to contact the plugin author – if he is willing to cooperate with us and fix the issue.
This may take some time, so perhaps a good idea will be that you also contact the plugin author and ask him about this.Hello, yes – this is issue that will be fixed in the next upcoming release of WooCommerce Multilingual.
As a workaround – you can go to WPML-> WooCommerce Multilingual -> Store URLs (/wp-admin/admin.php?page=wpml-wcml&tab=slugs) -> Select ANY endpoint as if you translate them, and click on save button in the dialog.
This will force refresh of the rewrite rules responsible for the endpoint work.Hello,
What plugin are we talking exactly here? Is this WooCommerce Cost Of Goods?
I am not sure if we have that plugin covered. It would be better if you could open a new ticket in our forum at wpml.org so that we can investigate this further.
Perhaps as a workaround, you can temporary disable WooCommerce Multilingual, add the price to the translated product and re-enable WooCommerce Multilingual.
Hello,
Thank you for letting us know about this issue, and for providing a code.
We will review it and test it further.Ok, I think that I see one error.
We changed some things recently, and you are calling for:
$fee = $woocommerce_wpml->multi_currency->convert_price_amount($fee);While the function convert_price_amount is not in multi_currency class, but in multi_currency_prices class.
I hope that this helps.
Hello,
Would you mind to share the error that you are getting?Where are you using this snippet exactly?
It might be that the class that contains that function is not loaded, I need more information in order to investigate properly.Yes, it seems that I misunderstood your message.
The improvements to String Translation are still in development, as I mentioned above. they will be released either separately, or in the next release of WPML 3.5. I have no other information at this time.
Thank you very much for testing it again!
It is very nice that you have some performance improvement – we changed a bit WooCommerce Multilingual, and our colleagues improved a bit WPML String Translation.
For the future – our teammates from the WPML String Translation team are cooking on bigger improvements related to how strings are handled – but they are still in development, testing and profiling, and would be released maybe in the next release of WPML (3.5).Could you please illustrate the behaviour that you are reporting? One screenshot illustrating the load times would be nice.
Also, could you tell me if the timings that you report here include ?wc-ajax=get_refreshed_fragments
In my testing setup, this request takes about a second.Would you mind to test if there would be any change if you try with minimal set of plugins? At this time I suspect that there might be some plugins (maybe related to cache) that may be affecting your site.
Please try with all non WPML and WooCommerce plugin switched off.Hello again Andres,
Today we released a new version – WooCommerce Multilingual 3.8.1 – and also our teammates released a new fix version of WPML 3.4.1 + addons.
I would suggest that you backup your site, and test both of these versions.
There should be a performance improvement.
Of course, we are not stopping here – for the next releases, my colleagues are working on further optimising WPML String Translation.
Please test the latest release, and let us know how it is for you.