berchca
Forum Replies Created
-
Forum: Plugins
In reply to: [Sticky Menu & Sticky Header] Incompatible with Page scroll to id@mark: Yeah, seems to work great. My fix was about getting the menu highlighting to work correctly, which, now that I see this page in action, doesn’t seem to be a factor here.
Forum: Plugins
In reply to: [Sticky Menu & Sticky Header] Incompatible with Page scroll to id@mantella: I did fix my conflict, though I’m using Page Scroll to ID instead of Easy Smooth Scroll. I didn’t do a very comprehensive fix, but if your Sticky Element is an anchor tag (hash prefix), then my fix might work for you.
The thing is, I didn’t see that your menu was sticking at all. Is that part working?
Forum: Plugins
In reply to: [Sticky Menu & Sticky Header] Incompatible with Page scroll to idHey Mark,
To start with, yes, I admit I have an extremely myopic point of view on this, having only tried this plugin with the one theme (Gravit), and really only encountering the problem when I started running it in parallel with the Page Scroll to Id plugin. That said, if you happened to have a set of themes you test with, I’d be happy to run through them myself, just for the sake of curiosity.
I definitely hear you about how if it’s working for most people, so why get too hung up on the fringe cases (we’re always the worst, aren’t we?)
Anyway, I had initially thought that by switching the code to insertBefore I had solved my problem, because the highlighting function of Page Scroll was acting on the first version of the menu, visible or not. But then I discovered that the menu highlighting would stutter when scrolling near the top, which I discovered was because menu items would be highlighted on one copy of the menu, and then, by the time the item was changing, the other menu was in effect. But, yes, it did work better.
Incidentally, when I first started to think about fixing my own problem, I was wondering if I could create a placeholder of the same dimensions. I was dubious, though, that such a solution wouldn’t require all sorts of cross-browser exceptions. Perhaps that situation isn’t so bad these days?
I would think that removing the original element is just a long way around to simply skipping the clone altogether and modifying the properties of the original div when you reach the end of the scrollpoint. Am I wrong? I had seen this in a another floating menu plugin (which didn’t work very well, and I don’t remember which one it was now).
If I can be any help, just let me know,
BrettForum: Plugins
In reply to: [Sticky Menu & Sticky Header] Incompatible with Page scroll to idHey Mark,
I certainly wasn’t trying to imply I felt there was anything wrong with using clone(); it looks to be the right call for the job. All I did was change the div id when ‘clone’ is spawned, as with the other attributes you change, ala:
$(‘.original’).clone().insertBefore($(‘.original’)).addClass(‘cloned’).css…….removeClass(‘original’).attr(‘id’, ‘non’).hide();and then flip-flop the ID as the div is shown and hidden.
Anyway, didn’t know if you’d be interested. And thanks for the reminder about having my mod overwritten (I did take the precaution to change the version number on the modified to 100.2, so that should cover it for a few months, anyway).
Thanks again for the plugin,
BrettForum: Plugins
In reply to: [Sticky Menu & Sticky Header] Incompatible with Page scroll to idHey Mark,
Just wanted to follow up: my earlier solution proved to be buggy, so I dug a little deeper. Apparently clone() can cause trouble with divs that have ID tags (which mine does, and that’s what I use to specify it in Sticky Menu’s settings). What I ended up doing was modding your code to swap the ID tag between the ‘original’ and ‘clone’ divs as each was displayed/hidden.
It wasn’t anything particularly clever, but let me know if you want the details.
– Brett
Forum: Plugins
In reply to: [Sticky Menu & Sticky Header] Incompatible with Page scroll to idNo, not a bug, certainly. Just one of the unfortunate aspects about having a completely open platform like WordPress (IMHO). Just wanted to make sure my solution was okay, or find out if you had a different recommendation.
Thank you for the plug-in, by the way. It’s fantastic.
-Brett