benshepp
Forum Replies Created
-
Forum: Themes and Templates
In reply to: [JustWrite] I believe I found a bug in functions.php@hannahstrange, Short answer: Yes, You need that mod to get your child theme to work. Otherwise your local CSS mods will never get loaded.
Without the calls to: get_stylesheet_directory_uri(), The path to your custom CSS mods will never get selected and therefore your CSS rules will never get loaded on the site.
Once update (v1.0.4) gets approved, (as Alex reported above) you will no longer need your mod after updating the theme. After you upgrade, be sure to go back in and REMOVE your temporary fix from your local functions.php… You won’t need to override the parent on that function anymore…
Forum: Themes and Templates
In reply to: [JustWrite] I believe I found a bug in functions.phpI am happy to have helped. Its been a good WP Theme learning experience for me!
Forum: Themes and Templates
In reply to: [JustWrite] cannot create childthemeOK.. I think this is another misguided child case…
I found a bug (i believe) in JustWrite’s Functions.php (its very subtle)
See my post here for the solution… cheers!
Forum: Themes and Templates
In reply to: [JustWrite] newbie: child themeHey folks.. the problem is in the Parent’s functions.php
You have to override the function that gets style sheets… The way its working in there is blocking child’s ability to use local .css!
See my post here for the fix…
Forum: Themes and Templates
In reply to: [JustWrite] child theme – i can´t edit style cssI believe I may have solved your problem… All child themes will have this problem if I am correct!
See my post hereHope you can understand my English better than I can understand your Deutsch! 😉
It may be this: see my post here
[ Moderator note: Link fixed. Don’t forget the
http://part. ]Forum: Themes and Templates
In reply to: [JustWrite] child theme – justwrite makes me crazy – child themeHey everyone… problem solved! See my last post here. Cheers!
Forum: Themes and Templates
In reply to: [JustWrite] Scaling Titles & HeadingsOK… I never told anyone, but the reason I asked for help above was because no matter what I tried to do in my child theme… there was no change on the rendered site… It was really bothering me… I thought was doing something wrong, and that i needed to learn how to do child themes better. This is my first one… 😉
I reasoned my style sheets were not being used and thought I had missed some step.. but when I looked in the theme editor window I could clearly see that my child’s style.css was there. Days later I looked at source code of a rendered page and clearly saw the style sheets belonged to the parent, NOT the child! There were no paths to any child .css to be found. So then I really started digging through the code doing a lot of head scratching…
Tonight, I found the problem, and fixed it. I need confirmation on this though. Is anyone else making child themes from this experiencing difficulty changing style parameters, or even adding new styles? Everyone with a JustWrite-child should be seeing this problem, not just me…
Here is what’s happening:
Functions.php contains the following Load CSS function: ac_css_files()
Inside that function, calls to wp_enqueue_style() are getting the stylesheets using get_template_directory_uri().
Code Example from ac_css_files() near line 100:
// Enqueue wp_enqueue_style( 'ac_style', get_template_directory_uri() . '/style.css', array(), '1.0.1', 'all' ); wp_enqueue_style( 'ac_media_queries', get_template_directory_uri() . '/assets/css/media-queries.css', array(), '1.0.1', 'all' ); wp_enqueue_style( 'ac_icons', get_template_directory_uri() . '/assets/icons/css/font-awesome.min.css', array(), '4.0.3', 'all' );I read a bunch of docs in WP Codex about themes and they all talk of using get_stylesheet_directory_uri() to make the theme work correctly when you need to insure the theme can be easily turned into a child theme later.
So.. I changed it in my child’s functions.php so it looks like this:
// Enqueue wp_enqueue_style( 'ac_style', get_stylesheet_directory_uri() . '/style.css', array(), '1.0.1', 'all' ); wp_enqueue_style( 'ac_media_queries', get_stylesheet_directory_uri() . '/assets/css/media-queries.css', array(), '1.0.1', 'all' ); wp_enqueue_style( 'ac_icons', get_stylesheet_directory_uri() . '/assets/icons/css/font-awesome.min.css', array(), '4.0.3', 'all' );That did it… Everything works fantastic now… I can change anything and see it working! I hope this helps anyone else struggling to make this fantastic professional looking theme into a child!
cheers!Forum: Themes and Templates
In reply to: [JustWrite] Scaling Titles & HeadingsHi @acosmin,
Thanks for any help you can provide! I understand its a free theme. Just providing the theme alone was fantastic! I don’t need extensive help… The few pointers you provided above really speed things up for me!I see the link to media-queries.css inside a comment at the bottom of style.css and now realize this must be major place I needed to do things to customize the responsive part. Thanks for that…
So, I copied assets/css/media-queries.css into my JustWrite-child theme to see if that overrides the parent. I have ‘Display Element Info’ via a Developer plug-in for Firefox and use those all the time, (not being a particular fan of Chrome, Blink or Webkit).
So… I made some changes to my instance of media-queries.css, but the font size values are not changing… Maybe I am missing a step for properly setting up a child theme? The WP docs seem to indicate that any file (except style.css) copied into the child will override the parent’s.
So I am back reading the WordPress docs on that again… This is my first attempt at really customizing a WP theme although I am a veteran programmer from past years…
I am also trying to modify the way the logo responds to screen size on top as well. I am using a longer logo (banner with logo and title integrated in a fancy graphic). I don’t need the default HTML title part in the header. So I need to take up the slack on that and float the logo (banner) to the left rather than centering it in some cases as the Theme is doing by default.
I saw the .logo{} style def in media-queries.css as well, so I will fiddle around with that and see what happens. Again not to ask for too much of your time, any ‘gotchas’ you may think of will be truly helpful! Thanks!
– Ben