alanft
Forum Replies Created
-
Forum: Plugins
In reply to: [Plugin: Widget Logic] This plugin is potentially dangerouscan i ask the same question again. Does the ability to get code exec’d go beyond the rights to edit widgets? that would be disastrous and warrant an immediate fix.
i’ll also make the next release provide the option of locking out non-admins to cover the case i mentioned.
then we’ll have three whole options, and perhaps that would warrant a settings page of its own
Forum: Plugins
In reply to: [Plugin: Degradable HTML5 audio and video] Default code is not workingplease do!
Forum: Plugins
In reply to: [Plugin: Degradable HTML5 audio and video] Doesn’t work on iPad/iPhone Safarips soukie – loving this plugin. i’m going to play with it more when our current audio-based project is over, and play with some custom controls. if i have any bright ideas about how to make custom controls simpler, would you mind me posting up some code suggestions?
right now i am just amazed that firefox won’t do an audio embed with mp3 – no way i’m re-encoding our massive mp3 archive. I know the mozilla dudes are so anti MPEG-LA, but can’t they get the browser so it hands off mp3 rendering to the host OS apis? (don’t most OS’s these days cope with mp3 natively)
note, i am a total amateur coder and have no clue what i am talking about really 🙂
Forum: Plugins
In reply to: [Plugin: Widget Logic] This plugin is potentially dangerousSomething like this concerned me when I first released it way back when. But I
it’s not come back to bite me til now.Now, obviously, anyone with rights to edit widgets can execute code – are you saying the ability to get code exec’d goes beyond those rights?
I can see a case where non-admins are extended widget/appearance privs, that the admin might not want them to edit the logic/code. So there’s def a case for restricting the WL code to admin-only editing. Will think about adding that to the code asap if it’s a real concern
cheers
Forum: Plugins
In reply to: [Plugin: Degradable HTML5 audio and video] Doesn’t work on iPad/iPhone Safarii don’t know about the podcasting plugin, but the syntax for the audio player as specified on
http://wordpress.org/extend/plugins/degradable-html5-audio-and-video/
lets you put in a format=”mp3″ within the [audio… shortcode. try adding that format in there to see if that helps.
if you read the FAQ at http://wordpress.org/extend/plugins/degradable-html5-audio-and-video/faq/ you’ll read that there are cases where “use the format option to manually specify the available file formats” will fix the player not working.
Forum: Plugins
In reply to: [Plugin: Degradable HTML5 audio and video] Default code is not workinga lot of people use the WP audio player plugin (as we do) with its old-fashioned (pre-shortcode) syntax, so it would help people to switch to this plugin if there was a ‘compatibility mode’
I’m hoping the blog authors will let me switch to your plugin, but to do that would take a bit of magic to go back and update all our audio embed codes. there’s a couple of global search and replace plugins i know could do this, but until everyone is happy with the switch, I don’t want to make those changes.
so instead I’ve added this extra code after your “extract( shortcode_atts …” line (at about line 56)
# get audio player attributes if ($src=="" && $atts[0]!="") { $src=trim($atts[0],": \t"); $src=explode("|",$src); $src=$src[0]; # just parse out the src for now. other params like Titles= could be used in a later version }(I have another plugin that makes your autodetect fail, so added a $format=”mp3″ in there too)
hope this helps
Forum: Plugins
In reply to: [Plugin: Degradable HTML5 audio and video] Doesn’t work on iPad/iPhone Safarifor some reason the audio tag on that page has no source sub-tag.
try setting the format explicity as mp3.
Forum: Plugins
In reply to: Widget Logic Illegal Offsetthis turns out to be a clash between widget logic and the semiologic plugin ‘inline widgets’.
i’ve given pat a quick fix to put in the inline widgets plugin as it *seems* to be doing something unusual with widget data. (if what it’s doing is valid, or if the developers say ‘well it’s working ok’ then i’ll add code to WL to code around it.)
Forum: Plugins
In reply to: Widget Logic Illegal Offset(that’s odd, thought i just posted a reply…)
just e-mailed you. thanks for this opportunity. really appreciate it
Forum: Plugins
In reply to: Widget Logic Illegal Offsetmy guess is that their code stops/interferes with the re-wiring of widgets that Widget Logic needs. (it sneaks the widget ID into the widgets ‘params’). but i don’t have access to the semiologic code, so i don’t have much chance of helping you out, sorry.
Forum: Plugins
In reply to: Widget Logic Array Warning/ Errorit suggests that you have a misbehaving widget somewhere. all the widgets in the main WP code are OK, so it must be from a plugin or widget code in your theme.
try deactivating widget-providing plugins one at a time. and if your theme provides widgets, try switching temporarily to the default WP theme to see if that helps.
alternatively if you are up to some hacking of my plugin you could try changing line 137 to
if (!$wp_registered_widgets[$id][‘callback_wl_redirect’] && array_key_exists(‘params’,$wp_registered_widgets[$id]) )
however that won’t fix the misbehaving widget, so it’s appearance won’t be controlled by widget logic, but it will stop the error appearing.
i’d be interested to see the code of the problematic widget so that i can make it work tho. so let me know.
Forum: Plugins
In reply to: post order by discussion/activityit’s been working well BTW, if anyone could advise me on what hooks etc to use to make it work with pretty URLs, rather than GET parameters, that would be awesome.
The last 2 examples in the other notes section should give you the right idea
Forum: Plugins
In reply to: WP_DEBUG throws lots of warnings with Widget Logicah good catch. will look at that too. thanks all.
Forum: Plugins
In reply to: WP_DEBUG throws lots of warnings with Widget Logicquick look over seems to imply the only major issue is on line 137 where
if (!$wp_registered_widgets[$id][‘callback_wl_redirect’])
should be changed to
if (!array_key_exists(‘callback_wl_redirect’, $wp_registered_widgets[$id]))
if you see any other lines being referenced in your dubug.log, let me know.
Thanks for the tip by the way. though this has shown up lots of debug problems like this with my theme and some plugins (google analytics!)